mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Denis OSTERLAND <denis.osterland@diehl.com>
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] systemd: install systemd-timesync.list in ntp-units.d
Date: Thu, 2 Jan 2020 09:46:21 +0000	[thread overview]
Message-ID: <3862086864bf5dab3f40b227eb7e5784681b210d.camel@diehl.com> (raw)
In-Reply-To: <20191223144552.93947-1-clemens.gruber@pqgruber.com>

Hi Clemens,

Am Montag, den 23.12.2019, 15:45 +0100 schrieb Clemens Gruber:
> When systemd-timesyncd is used, there should be an entry in ntp-units.d.
> Otherwise, timedatectl set-ntp sometimes fails with "NTP not supported".
> 
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> ---
>  projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list | 1 +
>  rules/systemd.make                                               | 1 +
>  2 files changed, 2 insertions(+)
>  create mode 100644 projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list
> 
> diff --git a/projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list b/projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list
> new file mode 100644
> index 000000000..d5959ade8
> --- /dev/null
> +++ b/projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list
> @@ -0,0 +1 @@
> +systemd-timesyncd.service
> diff --git a/rules/systemd.make b/rules/systemd.make
> index 5564d893f..6b7ec83ab 100644
> --- a/rules/systemd.make
> +++ b/rules/systemd.make
> @@ -432,6 +432,7 @@ ifdef PTXCONF_SYSTEMD_TIMEDATE
>  		/var/lib/systemd/timesync)
>  	@$(call install_link, systemd, ../systemd-timesyncd.service,  \
>  		/usr/lib/systemd/system/sysinit.target.wants/systemd-timesyncd.service)
> +	@$(call install_tree, systemd, 0, 0, -, /usr/lib/systemd/ntp-units.d/)
why install_tree and not install_alternative just this file?
Is there no other valid content of this file?
Is it unlikely that other packages will install to this directory?

Regards Denis
>  endif
>  
>  ifdef PTXCONF_SYSTEMD_VCONSOLE


Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
- For general information on data protection and your respective rights please visit https://www.diehl.com/group/en/transparency-and-information-obligations/
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2020-01-02  9:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-23 14:45 Clemens Gruber
2020-01-02  9:46 ` Denis OSTERLAND [this message]
2020-01-02 13:19   ` Clemens Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3862086864bf5dab3f40b227eb7e5784681b210d.camel@diehl.com \
    --to=denis.osterland@diehl.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox