Re: [ptxdist] [PATCH 5/7] u-boot: add u-boot{-dtb, -with-spl-pbl}.bin image installation options

[Alexander Dahl <ada@thorsis.com>]

Hei hei,

I had another look at this series, because I'm currently building u-boot for a 
new target. This patch looks good I think (see below).

However, what is the status of this whole series? Will there be a v2?

Am Mittwoch, 10. Oktober 2018, 14:03:36 CET schrieb Ahmad Fatoum:
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  platforms/u-boot.in | 14 ++++++++++++++
>  rules/u-boot.make   | 13 +++++++++++--
>  2 files changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> index 38684a03a376..bcb78cfc3f5a 100644
> --- a/platforms/u-boot.in
> +++ b/platforms/u-boot.in
> @@ -75,5 +75,19 @@ config U_BOOT_INSTALL_U_BOOT_IMX
>  	  Installing the U-Boot image with imx header (u-boot.imx) into platform
>  	  image directory. Say yes if you are building for freescale i.MX SOC
> 
> +config U_BOOT_INSTALL_U_BOOT_DTB
> +	prompt "install u-boot-dtb.bin"
> +	bool
> +	help
> +	  Installing the U-Boot binary concatenated with the device tree
> +	  into platform image directory.
> +
> +config U_BOOT_INSTALL_U_BOOT_WITH_SPL_PBL
> +	prompt "install u-boot-with-spl-pbl.bin"
> +	bool
> +	help
> +	  Installing the U-Boot binary which contains as well the SPL and PBL.
> +	  Say yes if you are building for Layerscape SoCs
> +
>  endif
> 
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index 24f3fe3983f5..d9bcdf5ca64d 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -93,6 +93,14 @@ ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_IMG
>  endif
>  ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_IMX
>  	@install -v -D -m644 $(U_BOOT_DIR)/u-boot.imx $(IMAGEDIR)/u-boot.imx
> +endif
> +ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_DTB
> +	@install -v -D -m644 $(U_BOOT_DIR)/u-boot-dtb.bin \
> +		$(IMAGEDIR)/u-boot-dtb.bin
> +endif
> +ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_WITH_SPL_PBL
> +	@install -v -D -m644 $(U_BOOT_DIR)/u-boot-with-spl-pbl.bin \
> +		$(IMAGEDIR)/u-boot-with-spl-pbl.bin
>  endif
>  	@$(call touch)
> 
> @@ -103,8 +111,9 @@ endif
>  $(STATEDIR)/u-boot.clean:
>  	@$(call targetinfo)
>  	@$(call clean_pkg, U_BOOT)
> -	@rm -vf $(IMAGEDIR)/u-boot.bin $(IMAGEDIR)/u-boot.srec
> $(IMAGEDIR)/u-boot.elf -	@rm -vf $(IMAGEDIR)/u-boot.imx
> +	@rm -vf $(IMAGEDIR)/u-boot.bin $(IMAGEDIR)/u-boot.srec
> +	@rm -vf $(IMAGEDIR)/u-boot.elf $(IMAGEDIR)/u-boot.imx
> +	@rm -vf	$(IMAGEDIR)/u-boot-dtb.bin $(IMAGEDIR)/u-boot-with-spl-pbl.bin
> 
>  #
> ---------------------------------------------------------------------------
> - # oldconfig / menuconfig

The "u-boot-dtb.bin" and clean parts look fine.

However, in upstream u-boot 2019.01 I could not find a defconfig which 
actually creates a file "u-boot-with-spl-pbl.bin" although there seems to be a 
make target for that. Could you name a defconfig for testing?

Greets
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de