From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 10 Dec 2021 09:49:02 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mvbaQ-001uBa-8e for lore@lore.pengutronix.de; Fri, 10 Dec 2021 09:49:02 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mvbaP-00082r-NG; Fri, 10 Dec 2021 09:49:01 +0100 Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvbZf-00082c-LG; Fri, 10 Dec 2021 09:48:18 +0100 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 3FA6DDB7; Fri, 10 Dec 2021 09:48:14 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LJ4vnuY7ZXDA; Fri, 10 Dec 2021 09:48:09 +0100 (CET) Received: by mail.thorsis.com (Postfix, from userid 109) id C3BEA324F; Fri, 10 Dec 2021 09:48:09 +0100 (CET) From: Alexander Dahl To: Roland Hieber Date: Fri, 10 Dec 2021 09:48:06 +0100 Message-ID: <3608335.H6dVxhGl9V@ada> In-Reply-To: <20211205221106.240253-1-rhi@pengutronix.de> References: <20211205221106.240253-1-rhi@pengutronix.de> X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 1/2] dropbear: license review X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hello Roland, Am Sonntag, 5. Dezember 2021, 23:11:05 CET schrieb Roland Hieber: > Commit 80326bc43e7 (2020-11-16, Alexander Dahl: "dropbear: version bump > 2019.78 -> 2020.79") mentioned: > > The curve25519 implementation was replaced with the one by TweetNaCl, > which induced a change in 'LICENSE' summary. The old implementation was > licensed BSD-3-Clause and the new is public domain. > > This was wrong; even though curve25519.c is based on the public domain > TweetNaCl library, as mentioned in LICENSE, it carries a BSD-2-Clause > license header like most other files. Therefore remove the first > public_domain sub-expression. That header is actual MIT license. See the spdx-license-match tool or for reference: https://metadata.ftp-master.debian.org/changelogs//main/d/dropbear/ dropbear_2020.81-3_copyright This does not affect the diff of your patch, but the commit message would not be correct. With that changed: Acked-by: Alexander Dahl > The second public_domain sub-expression referred to the libtomcrypt > license, which is licensed as, alternatively, WTFPL, or "LibTomCrypt is > public domain. As should all quality software be.". Classify it as a > custom license, as we deprecated the public_domain license identifier in > commit 76d1f680233955839298 (2021-08-06, Roland Hieber: "doc: working > with licensing information in packages"). > > Fixes: 80326bc43e71d1b012b3 ("dropbear: version bump 2019.78 -> 2020.79") > Cc: Alexander Dahl > Signed-off-by: Roland Hieber Ack. Greets Alex > --- > rules/dropbear.make | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rules/dropbear.make b/rules/dropbear.make > index 102825ed6ab4..678bd7d85778 100644 > --- a/rules/dropbear.make > +++ b/rules/dropbear.make > @@ -24,7 +24,7 @@ DROPBEAR_URL := > http://matt.ucc.asn.au/dropbear/releases/$(DROPBEAR).$(DROPBEAR > DROPBEAR_SOURCE := $(SRCDIR)/$(DROPBEAR).$(DROPBEAR_SUFFIX) > DROPBEAR_DIR := $(BUILDDIR)/$(DROPBEAR) > DROPBEAR_LICENSE := \ > - MIT AND BSD-2-Clause AND public_domain AND SSH-short AND (public_domain OR > WTFPL) AND Unlicense + MIT AND BSD-2-Clause AND SSH-short AND (custom OR > WTFPL) AND Unlicense DROPBEAR_LICENSE_FILES := \ > file://LICENSE;md5=25cf44512b7bc8966a48b6b1a9b7605f \ > file://libtomcrypt/LICENSE;md5=71baacc459522324ef3e2b9e052e8180 \ -- _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de