[ptxdist] Bug on ptxdist-2016.05.0

[ptxdist] Bug on ptxdist-2016.05.0

[Raimundo Sagarzazu]

[-- Attachment #1.1: Type: text/plain, Size: 273 bytes --]

Hello,

I've found a bug on the "ptxd_make_xpkg_pkg.sh" script related to the strip option of the "install_*" function. It leads to a stripping of all kernel modules that can't be loaded because they have no symbols. I attach the patch.

Regards,

  Raimun.





[-- Attachment #1.2: Type: text/html, Size: 2442 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Bug on ptxdist-2016.05.0

[Wim Vinckier]

On 30 June 2016 at 16:10, Michael Olbrich <m.olbrich@pengutronix.de> wrote:
> On Thu, Jun 30, 2016 at 10:39:45AM +0200, Wim Vinckier wrote:
>> On 10 June 2016 at 12:08, Michael Olbrich <m.olbrich@pengutronix.de> wrote:
>> > On Thu, Jun 09, 2016 at 04:15:12PM +0200, Ladislav Michl wrote:
>> >> On Thu, Jun 09, 2016 at 01:07:51PM +0000, Carsten Schlote wrote:
>> >> > I tried that patch as it really looks like a typo. Anyway, with the patch
>> >> > applied you get a problem when target-installing the
>> >> >
>> >> > kernel modules. It tried to strip module.symbols and obviously fails.
>> >>
>> >> Problem is caused by commit 535944fdf5b2a32a856cbaa92463d519f75e206f.
>> >> Reverting it makes things work again.
>> >>
>> >> > So this fix might need further fixes.
>> >>
>> >> Indeed :-)
>> >
>> > Take the first commit in the master branch after the release tag. That
>> > should fix the problem (by going back to the old behavior). Later commit do
>> > what I actually wanted to achieve but that required some more changes.
>> >
>> > Michael
>> >
>>
>> Do I understand it correctly that this should be fixed in ptxdist-2016.06.0?
>
> That is correct. However, 'make install' can fail for ptxdist-2016.06.0.
> I've posted a workaround for that issue[1].
>
> Michael
>
> [1] http://article.gmane.org/gmane.comp.embedded.ptxdist.devel/13931
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>


With a little delay: it seems to work. :-)

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Bug on ptxdist-2016.05.0

[Michael Olbrich]

On Thu, Jun 30, 2016 at 10:39:45AM +0200, Wim Vinckier wrote:
> On 10 June 2016 at 12:08, Michael Olbrich <m.olbrich@pengutronix.de> wrote:
> > On Thu, Jun 09, 2016 at 04:15:12PM +0200, Ladislav Michl wrote:
> >> On Thu, Jun 09, 2016 at 01:07:51PM +0000, Carsten Schlote wrote:
> >> > I tried that patch as it really looks like a typo. Anyway, with the patch
> >> > applied you get a problem when target-installing the
> >> >
> >> > kernel modules. It tried to strip module.symbols and obviously fails.
> >>
> >> Problem is caused by commit 535944fdf5b2a32a856cbaa92463d519f75e206f.
> >> Reverting it makes things work again.
> >>
> >> > So this fix might need further fixes.
> >>
> >> Indeed :-)
> >
> > Take the first commit in the master branch after the release tag. That
> > should fix the problem (by going back to the old behavior). Later commit do
> > what I actually wanted to achieve but that required some more changes.
> >
> > Michael
> >
> 
> Do I understand it correctly that this should be fixed in ptxdist-2016.06.0?

That is correct. However, 'make install' can fail for ptxdist-2016.06.0.
I've posted a workaround for that issue[1].

Michael

[1] http://article.gmane.org/gmane.comp.embedded.ptxdist.devel/13931

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Bug on ptxdist-2016.05.0

[Wim Vinckier]

On 10 June 2016 at 12:08, Michael Olbrich <m.olbrich@pengutronix.de> wrote:
> On Thu, Jun 09, 2016 at 04:15:12PM +0200, Ladislav Michl wrote:
>> On Thu, Jun 09, 2016 at 01:07:51PM +0000, Carsten Schlote wrote:
>> > I tried that patch as it really looks like a typo. Anyway, with the patch
>> > applied you get a problem when target-installing the
>> >
>> > kernel modules. It tried to strip module.symbols and obviously fails.
>>
>> Problem is caused by commit 535944fdf5b2a32a856cbaa92463d519f75e206f.
>> Reverting it makes things work again.
>>
>> > So this fix might need further fixes.
>>
>> Indeed :-)
>
> Take the first commit in the master branch after the release tag. That
> should fix the problem (by going back to the old behavior). Later commit do
> what I actually wanted to achieve but that required some more changes.
>
> Michael
>

Do I understand it correctly that this should be fixed in ptxdist-2016.06.0?

wimpunk

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Bug on ptxdist-2016.05.0

[Michael Olbrich]

On Thu, Jun 09, 2016 at 04:15:12PM +0200, Ladislav Michl wrote:
> On Thu, Jun 09, 2016 at 01:07:51PM +0000, Carsten Schlote wrote:
> > I tried that patch as it really looks like a typo. Anyway, with the patch
> > applied you get a problem when target-installing the
> > 
> > kernel modules. It tried to strip module.symbols and obviously fails.
> 
> Problem is caused by commit 535944fdf5b2a32a856cbaa92463d519f75e206f.
> Reverting it makes things work again.
> 
> > So this fix might need further fixes.
> 
> Indeed :-)

Take the first commit in the master branch after the release tag. That
should fix the problem (by going back to the old behavior). Later commit do
what I actually wanted to achieve but that required some more changes.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Bug on ptxdist-2016.05.0

[Ladislav Michl]

On Thu, Jun 09, 2016 at 01:07:51PM +0000, Carsten Schlote wrote:
> Hi Raimundo,
> 
> I tried that patch as it really looks like a typo. Anyway, with the patch
> applied you get a problem when target-installing the
> 
> kernel modules. It tried to strip module.symbols and obviously fails.

Problem is caused by commit 535944fdf5b2a32a856cbaa92463d519f75e206f.
Reverting it makes things work again.

> So this fix might need further fixes.

Indeed :-)

	ladis

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Bug on ptxdist-2016.05.0

[Carsten Schlote]

[-- Attachment #1.1: Type: text/plain, Size: 1043 bytes --]

Hi Raimundo,

I tried that patch as it really looks like a typo. Anyway, with the patch applied you get a problem when target-installing the
kernel modules. It tried to strip module.symbols and obviously fails.

So this fix might need further fixes.

Carsten

Von: ptxdist [mailto:ptxdist-bounces@pengutronix.de] Im Auftrag von Raimundo Sagarzazu
Gesendet: Donnerstag, 9. Juni 2016 10:40
An: ptxdist@pengutronix.de
Betreff: [ptxdist] Bug on ptxdist-2016.05.0

Sorry, the patch:

diff -rup a/scripts/lib/ptxd_make_xpkg_pkg.sh b/scripts/lib/ptxd_make_xpkg_pkg.sh
--- a/scripts/lib/ptxd_make_xpkg_pkg.sh          2016-05-30 16:41:31.000000000 +0200
+++ b/scripts/lib/ptxd_make_xpkg_pkg.sh       2016-06-09 09:23:50.372027049 +0200
@@ -314,7 +314,7 @@ install ${cmd}:
               echo "using '$(ptxd_print_path "${src}")' instead"
     fi &&

-    if [ -z "${stip}" ]; then
+    if [ -z "${strip}" ]; then
               if readelf -h "${src}" &> /dev/null; then
                   strip="y"
               else



[-- Attachment #1.2: Type: text/html, Size: 6947 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] Bug on ptxdist-2016.05.0

[Raimundo Sagarzazu]

[-- Attachment #1.1: Type: text/plain, Size: 569 bytes --]

Sorry, the patch:

diff -rup a/scripts/lib/ptxd_make_xpkg_pkg.sh b/scripts/lib/ptxd_make_xpkg_pkg.sh
--- a/scripts/lib/ptxd_make_xpkg_pkg.sh          2016-05-30 16:41:31.000000000 +0200
+++ b/scripts/lib/ptxd_make_xpkg_pkg.sh       2016-06-09 09:23:50.372027049 +0200
@@ -314,7 +314,7 @@ install ${cmd}:
               echo "using '$(ptxd_print_path "${src}")' instead"
     fi &&

-    if [ -z "${stip}" ]; then
+    if [ -z "${strip}" ]; then
               if readelf -h "${src}" &> /dev/null; then
                   strip="y"
               else



[-- Attachment #1.2: Type: text/html, Size: 4480 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de