From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1jeEAm-0007qy-QA for ptxdist@pengutronix.de; Thu, 28 May 2020 10:45:56 +0200 References: <20200527210425.2525-1-bst@pengutronix.de> <20200528064601.tyhkpnpmflxgejxw@falbala.internal.home.lespocky.de> From: Bastian Krause Message-ID: <35094473-825d-72b6-20ba-37214127347b@pengutronix.de> Date: Thu, 28 May 2020 10:45:56 +0200 MIME-Version: 1.0 In-Reply-To: <20200528064601.tyhkpnpmflxgejxw@falbala.internal.home.lespocky.de> Content-Language: en-US Subject: Re: [ptxdist] [PATCH 1/3] libmodbus3: correct license List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Hi Alex, On 5/28/20 8:46 AM, Alexander Dahl wrote: > I sent a patch for the libmodbus3 license issue last year, Message-Id > was <20190510092434.15019-17-ada@thorsis.com> and Michael gave some > feedback, see: > > https://www.mail-archive.com/ptxdist@pengutronix.de/msg14488.html > > On Wed, May 27, 2020 at 11:04:23PM +0200, Bastian Krause wrote: >> libmodbus reverted its license with v3.0.0, commit 1275387 ("Revert >> libmodbus licence from LGPLv3 to LGPLv2.1") to LGPL-2.1-or-later. >> 820e15f ("SPDX: change LGPL-2.1+ to LGPL-2.1-or-later") updates the SPDX >> identifier in file headers to the recent version. > > My initial analysis was this, copied from my old patch: > > When introduced to ptxdist back in 2011 with version 3.0.1 libmodbus > was already licensed LGPL-2.1-or-later for the library part and > GPL-3.0-or-later for the tests. This did not change upstream since > then. Thanks for the feedback. Will send a v2. > > Fixes: a8f85be09c663bfad8a34a162b1a63fb3d499985 > > This is of course better: > > Fixes: a8f85be09c66 ("libmodbus3: add new package") Okay, this also fixes a76b31d5b ("libmodbus3: version bump 3.0.6 -> 3.1.4") since the test license changed with v3.1.2 from GPL-3.0-or-later to BSD-3-Clause. > >> >> Signed-off-by: Bastian Krause >> --- >> rules/libmodbus3.make | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/rules/libmodbus3.make b/rules/libmodbus3.make >> index f206ec4aa..412401cbe 100644 >> --- a/rules/libmodbus3.make >> +++ b/rules/libmodbus3.make >> @@ -21,7 +21,7 @@ LIBMODBUS3_SUFFIX := tar.gz >> LIBMODBUS3_URL := http://libmodbus.org/site_media/build/$(LIBMODBUS3).$(LIBMODBUS3_SUFFIX) >> LIBMODBUS3_SOURCE := $(SRCDIR)/$(LIBMODBUS3).$(LIBMODBUS3_SUFFIX) >> LIBMODBUS3_DIR := $(BUILDDIR)/$(LIBMODBUS3) >> -LIBMODBUS3_LICENSE := LGPL-3.0-only >> +LIBMODBUS3_LICENSE := LGPL-2.1-or-later > > This is probably not sufficient, see my original patch, and feedback > by Michael on that and by Roland in the other mail. This will be LGPL-2.1-or-later AND BSD-3-Clause. I'll also add LIBMODBUS3_LICENSE_FILES. This license stuff never gets boring :) Regards, Bastian -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de