Re: [ptxdist] [PATCH] ncdu: new package

[Alexander Dahl <post@lespocky.de>]

Hello Michael,

Am 2016-08-04 08:49, schrieb Michael Olbrich:
> NCDU_CONF_OPT	:= \
> 	$(CROSS_AUTOCONF_USR) \
> 	...
> 
> Are you sure there are no other options?

Yes. This tool just needs ncurses in some form, this is the part of
./configure with all the options:


Optional Packages:
  --with-PACKAGE[=ARG]    use PACKAGE [ARG=yes]
  --without-PACKAGE       do not use PACKAGE (same as --with-PACKAGE=no)
  --with-ncurses          compile/link with ncurses library
  --with-ncursesw         compile/link with wide-char ncurses library
                          [default]
  --with-shell            used interpreter as default shell (default is
                          /bin/sh)

>> +ifdef PTXCONF_NCURSES_WIDE_CHAR
> 
> Don't use symbols from other packages. PTXdist won't know when it needs to
> rebuild your package when the option changes. 

Well, someone should go fix alsa-utils then. ;-)

> Add a local symbol like this:
> 
> config NCDU_NCURSESW
> 	bool
> 	default NCURSES_WIDE_CHAR
> 
>> +NCDU_CONF_OPT	+= --with-ncursesw
> 
> Use ptx/wwo for this.
> 
>> +else
>> +NCDU_CONF_OPT	+= --with-ncurses

Maybe I didn't understand this ncurses vs. ncursesw thing correctly yet.
Isn't it always one xor the other, or are both at the same time
possible?

> This needs a ptx/wow. That does not exist yet, but it's easy to add.
> It should be defined in rules/pre/000-option-disabled.make with ptx/wwo
> just with reversed arguments, just like ptx/endis vs. ptx/disen.

That's easy, I would make a separate patch for that.

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: C28E E6B9 0263 95CF 8FAF  08FA 34AD CD00 7221 5CC6 ***

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de