From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: References: <20191129115134.6402-1-bst@pengutronix.de> <20191129115134.6402-2-bst@pengutronix.de> From: Bastian Krause Message-ID: <316be637-614d-7512-b7cd-0eb6916d2f6c@pengutronix.de> Date: Wed, 18 Dec 2019 09:57:24 +0100 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [ptxdist] [PATCH v3 2/3] tpm2-tools: version bump 3.1.4 -> 4.1 List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de, Bruno Thomsen Hi Bruno, On 12/17/19 4:16 PM, Bruno Thomsen wrote: > Den fre. 29. nov. 2019 kl. 12.52 skrev Bastian Krause : >> -TPM2_TOOLS_VERSION := 3.1.4 >> -TPM2_TOOLS_MD5 := 61b4a382d24c950148a3f5fe41ac2306 >> +TPM2_TOOLS_VERSION := 4.1 > > I just tested your version bump and found that our build still need > a minor change otherwise the prepare stage fails. > > $ ptxdist prepare tpm2-tools > > checking whether C compiler accepts -Wall... yes > checking whether C compiler accepts -Wextra... yes > checking whether C compiler accepts -Werror... yes > checking whether C compiler accepts -Wformat... yes > checking whether C compiler accepts -Wformat-security... yes > checking whether C compiler accepts -Wstack-protector... yes > checking whether C compiler accepts -fstack-protector-all... yes > checking whether C compiler accepts -Wstrict-overflow=5... yes > checking whether C compiler accepts -Wbool-compare... yes > checking whether C compiler accepts -O2... yes > checking whether to add -D_FORTIFY_SOURCE=2 to CPPFLAGS... yes > checking whether C compiler accepts -fPIC... yes > checking whether the linker accepts -shared... no > configure: error: Cannot enable -shared, consider configuring with > --disable-hardening > > > ptxdist platformconfig: > # > # hardening options > # > # PTXCONF_TARGET_HARDEN_STACK_NONE is not set > # PTXCONF_TARGET_HARDEN_STACK is not set > # PTXCONF_TARGET_HARDEN_STACK_STRONG is not set > PTXCONF_TARGET_HARDEN_STACK_ALL=y > PTXCONF_TARGET_HARDEN_STACKCLASH=y > PTXCONF_TARGET_HARDEN_FORTIFY=y > PTXCONF_TARGET_HARDEN_RELRO=y > PTXCONF_TARGET_HARDEN_BINDNOW=y > PTXCONF_TARGET_HARDEN_PIE=y > PTXCONF_TARGET_HARDEN_GLIBCXX_ASSERTIONS=y > > Disabling PIE does not change anything when using arm-v7a-linux-gnueabihf-gcc. > >> # ---------------------------------------------------------------------------- >> # Prepare >> @@ -34,10 +34,12 @@ TPM2_TOOLS_LICENSE_FILES := file://LICENSE;md5=91b7c548d73ea16537799e8060cea819 >> TPM2_TOOLS_CONF_TOOL := autoconf >> TPM2_TOOLS_CONF_OPT := \ >> $(CROSS_AUTOCONF_USR) \ >> + --enable-debug=info \ >> --disable-code-coverage \ >> --disable-unit \ >> --enable-hardening \ >> - --without-gcov >> + --without-gcov \ >> + --without-bashcompdir > > TPM2_TOOLS_CFLAGS := \ > -fPIC > > > I don't know if this is the correct fix or something else is the root cause. Looks okay to me. Let's wait what Michael has to say about it. Regards, Bastian -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de