mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: Re: [ptxdist] [PATCH 07/34] figlet: Fix license and add license file hashes
Date: Mon, 13 May 2019 12:20:25 +0200	[thread overview]
Message-ID: <3101229.dZIzDvBaGb@ada> (raw)
In-Reply-To: <20190513094112.pcoszwtgnus3eq5c@pengutronix.de>

Hello Roland,

thanks for your review. Comments below.

Am Montag, 13. Mai 2019, 11:41:12 CEST schrieb Roland Hieber:
> On Fri, May 10, 2019 at 11:24:07AM +0200, Alexander Dahl wrote:
> > Added information based on what the Debian project found out.
> > 
> > https://metadata.ftp-master.debian.org/changelogs//main/f/figlet/figlet_2.
> > 2.5-2_copyright
> > 
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > ---
> > 
> >  rules/figlet.make | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/rules/figlet.make b/rules/figlet.make
> > index b22d22e17..8886beab3 100644
> > --- a/rules/figlet.make
> > +++ b/rules/figlet.make
> > @@ -25,7 +25,13 @@ FIGLET_SUFFIX		:= tar.gz
> > 
> >  FIGLET_URL		:=
> >  ftp://ftp.figlet.org/pub/figlet/program/unix/$(FIGLET).$(FIGLET_SUFFIX)
> >  FIGLET_SOURCE		:= $(SRCDIR)/$(FIGLET).$(FIGLET_SUFFIX)
> >  FIGLET_DIR		:= $(BUILDDIR)/$(FIGLET)
> > 
> > -FIGLET_LICENSE		:= figlet
> > +FIGLET_LICENSE		:= BSD-3-Clause AND MIT-CMU AND ISC AND Unicode-
DFS-2016
> > AND WTFPL +FIGLET_LICENSE_FILES	:= \
> > +	file://LICENSE;md5=1688bcd97b27704f1afcac7336409857 \
> > +	file://
inflate.c;startline=7;endline=27;md5=74ed6158b8244dbc4d91afaf8a39
> > bec2 \
> > +	file://utf8.c;startline=2;endline=16;md5=eb9cc57cf60ac24044670bf8dc4755
> > 79 \
> > +	file://fonts/8859-2.flc;startline=9;endline=23;md5=1cecb984063248f29ffe
> > 5c46f5c04f34 \
> > +	file://tests/emboss.tlf;startline=3;endline=10;md5=8e317e9236ffade21fed
> > c39e3496eac2
> I was trying to reproduce these, but I got a better match for HPND
> instead of MIT-CMU for inflate.c. 

See lines 29 to 33 in inflate.c, it is explicitly licensed under MIT. However 
the license text for MIT itself does not match very well, but for MIT-CMU 
quite well.

It's a little tricky to interpret the output of your tool. One has to look 
very closely at the brackets! Sometimes comparing manually with the annotated 
license text at spdx.org got me a better result. I often had the case your 
tool had a higher matching value for BSD-2-Clause, when the license was 
actually BSD-3-Clause, for example.

> And I cannot reprocude the match from
> fonts/8859-2.flc, which apparently should be Unicode-DFS-2016? It seems
> to me this is a bug in the Debian package you referenced above.

I was not sure about this, I actually tried to compare with upstream unicode 
files, but the licensing was rather unclear to me. From the three Unicode 
licenses listed by SPDX that one seemed to match best. If someone has a better 
idea on that, let me know.

Greets
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2019-05-13 10:20 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10  9:24 [ptxdist] [PATCH 00/34] License updates Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 01/34] at: Add license identifiers and hashes Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 02/34] at91bootstrap: Add license information Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 03/34] boost: Add license file hash Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 04/34] busybox: " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 05/34] libnl3: Fix license and add license hash Alexander Dahl
2019-05-28 21:43   ` Roland Hieber
2019-05-29  7:12     ` Michael Olbrich
2019-06-06 13:40       ` Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 06/34] dropbear: Add license information Alexander Dahl
2019-05-13  9:42   ` Roland Hieber
2019-05-29  7:49   ` Michael Olbrich
2019-05-29  8:00     ` Alexander Dahl
2019-05-29  9:12       ` Michael Olbrich
2019-05-29  9:31       ` Roland Hieber
2019-05-29  9:40         ` Michael Olbrich
2020-03-10 14:23         ` Alexander Dahl
2020-03-10 14:31           ` Roland Hieber
2019-05-10  9:24 ` [ptxdist] [PATCH 07/34] figlet: Fix license and add license file hashes Alexander Dahl
2019-05-13  9:41   ` Roland Hieber
2019-05-13 10:20     ` Alexander Dahl [this message]
2019-05-22 11:56       ` Roland Hieber
2019-05-29  7:29         ` Michael Olbrich
2019-05-10  9:24 ` [ptxdist] [PATCH 08/34] flex: Fix license and add license file hash Alexander Dahl
2019-05-28 21:07   ` Roland Hieber
2019-05-29  7:03     ` Michael Olbrich
2019-05-29  9:35       ` Roland Hieber
2019-05-10  9:24 ` [ptxdist] [PATCH 09/34] json-c: Add " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 10/34] coreutils: " Alexander Dahl
2019-05-29  7:53   ` Michael Olbrich
2019-05-10  9:24 ` [ptxdist] [PATCH 11/34] libarchive: " Alexander Dahl
2019-05-29  7:56   ` Michael Olbrich
2019-05-10  9:24 ` [ptxdist] [PATCH 12/34] libfaketime: " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 13/34] libgmp: Fix license Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 14/34] libgmp: Add license file hashes Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 15/34] libmnl: Fix license and add " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 16/34] libmodbus3: " Alexander Dahl
2019-05-29  8:04   ` Michael Olbrich
2019-05-29  8:13     ` Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 17/34] libnet: Add license information Alexander Dahl
2019-05-29  8:10   ` Michael Olbrich
2019-05-10  9:24 ` [ptxdist] [PATCH 18/34] libnftnl: Fix license and add license file hash Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 19/34] libpcap: " Alexander Dahl
2019-05-29  8:22   ` Michael Olbrich
2019-05-10  9:24 ` [ptxdist] [PATCH 20/34] libpopt: Add " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 21/34] libxml2: Fix license and add " Alexander Dahl
2019-05-29  8:28   ` Michael Olbrich
2019-05-10  9:24 ` [ptxdist] [PATCH 22/34] lighttpd: Fix licenses and add more license file hashes Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 23/34] lm_sensors: Add " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 24/34] log4cplus: Fix licenses and add license file hash Alexander Dahl
2019-05-29  9:09   ` Michael Olbrich
2019-05-10  9:24 ` [ptxdist] [PATCH 25/34] mtd-utils: Add " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 26/34] ncurses: Use 'COPYING' for " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 27/34] net-snmp: Fix licenses and add " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 28/34] nftables: Add " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 29/34] opkg: " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 30/34] readline: " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 31/34] rt-tests: Fix licenses and add " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 32/34] sudo: " Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 33/34] tree: Fix licenses and add license file hashes Alexander Dahl
2019-05-10  9:24 ` [ptxdist] [PATCH 34/34] u-boot-tools: " Alexander Dahl
2019-05-29  9:38 ` [ptxdist] [PATCH 00/34] License updates Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3101229.dZIzDvBaGb@ada \
    --to=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox