From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 30 Jun 2022 13:57:55 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o6snw-001z0q-91 for lore@lore.pengutronix.de; Thu, 30 Jun 2022 13:57:55 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o6sny-0001ff-SW; Thu, 30 Jun 2022 13:57:54 +0200 Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o6snL-0001ex-PS for ptxdist@pengutronix.de; Thu, 30 Jun 2022 13:57:16 +0200 From: Alexander Dahl To: dropbear@ucc.asn.au, ptxdist@pengutronix.de Date: Thu, 30 Jun 2022 13:57:14 +0200 Message-ID: <3029238.yBh1puBK4d@ada> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Clacks-Overhead: GNU Terry Pratchett X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: [ptxdist] build failure with recent dropbear 2022.82 on ptxdist for arm-v5te X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hello, trying to build dropbear as part of a ptxdist based embedded BSP for an=20 armv5te target, more precisely I try to upgrade dropbear from 2020.81 to=20 2022.82, the previous version builds fine, the new one fails to build. Cross toolchain is OSELAS.Toolchain-2016.06.1/arm-v5te-linux-gnueabi/ gcc-5.4.0-glibc-2.23-binutils-2.26-kernel-4.6-sanitized According to config.log =E2=80=A6 Invocation command line was $ ./configure --prefix=3D/usr --sysconfdir=3D/etc --localstatedir=3D/var = =2D- libdir=3D/usr/lib --build=3Dx86_64-host-linux-gnu --host=3Darm-v5te-linux-g= nueabi -- enable-harden --enable-largefile --disable-zlib --disable-pam --enable-open= pty=20 =2D-enable-syslog --enable-shadow --disable-plugin --disable-fuzz --enable- bundled-libtom --disable-lastlog --disable-utmp --disable-utmpx --disable-w= tmp=20 =2D-disable-wtmpx --disable-loginfunc --disable-pututline --disable-pututxl= ine And localoptions.h was set to this: /* localoptions.h created by ptxdist */ #define DROPBEAR_X11FWD 0 #define DROPBEAR_CLI_LOCALTCPFWD 1 #define DROPBEAR_CLI_REMOTETCPFWD 1 #define DROPBEAR_SVR_LOCALTCPFWD 1 #define DROPBEAR_SVR_REMOTETCPFWD 1 #define DROPBEAR_SVR_AGENTFWD 0 #define DROPBEAR_CLI_AGENTFWD 0 #define DROPBEAR_AES128 1 #define DROPBEAR_3DES 0 #define DROPBEAR_AES256 1 #define DROPBEAR_ENABLE_CBC_MODE 0 #define DROPBEAR_ENABLE_CTR_MODE 1 #define DROPBEAR_SHA1_HMAC 0 #define DROPBEAR_DH_GROUP1 0 #define DROPBEAR_DH_GROUP14_SHA1 0 #define DROPBEAR_SHA1_96_HMAC 0 #define DROPBEAR_SHA2_256_HMAC 1 #define DROPBEAR_SHA2_512_HMAC 1 #define DROPBEAR_DSS 0 #define DROPBEAR_RSA 1 #define DROPBEAR_ECDSA 0 #define DROPBEAR_ECDH 0 #define DROPBEAR_CURVE25519 0 #define DROPBEAR_SVR_PASSWORD_AUTH 1 #define DROPBEAR_CLI_PASSWORD_AUTH 1 #define DROPBEAR_SVR_PUBKEY_AUTH 1 #define DROPBEAR_CLI_PUBKEY_AUTH 1 The compile error is like this: arm-v5te-linux-gnueabi-gcc -c -Os -W -Wall -Wno-pointer-sign -fno-strict- overflow -fPIE -fstack-protector-strong -D_FORTIFY_SOURCE=3D2 -I./libtomcr= ypt/ src/headers/ -DLOCALOPTIONS_H_EXISTS -I. -I. -DDROPBEAR_SERVER - DDROPBEAR_CLIENT signkey.c -o signkey.o In file included from signkey.c:31:0: sk-ecdsa.h:11:44: error: unknown type name 'ecc_key' signkey.c: In function 'buf_get_pub_key': signkey.c:318:17: error: 'DROPBEAR_SIGNKEY_SK_ECDSA_NISTP256' undeclared = =20 (first use in this function) signkey.c:318:17: note: each undeclared identifier is reported only once = for =20 each function it appears in signkey.c: In function 'buf_verify': signkey.c:688:17: error: 'DROPBEAR_SIGNKEY_SK_ECDSA_NISTP256' undeclared = =20 (first use in this function) signkey.c:689:3: error: unknown type name 'ecc_key' signkey.c:689:20: error: 'ecc_key' undeclared (first use in this function) signkey.c:689:29: error: expected expression before ')' token make[1]: *** [Makefile:154: signkey.o] Error 1 I looked into the dropbear code, and sk-ecdsa.h includes "includes.h" which= =20 itself includes "tomcrypt.h" and in some file of that 'ecc_key' is defined,= so=20 I don't know why the compiler complains here. =20 Did not look into the other errors however. Any ideas? Greets Alex