From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 26 Sep 2024 10:39:26 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1stk21-002vv2-19 for lore@lore.pengutronix.de; Thu, 26 Sep 2024 10:39:26 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1stk21-00021A-RC; Thu, 26 Sep 2024 10:39:25 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stk1j-0001yO-CH; Thu, 26 Sep 2024 10:39:07 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1stk1i-001e7M-WA; Thu, 26 Sep 2024 10:39:07 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1stk1i-0001hx-34; Thu, 26 Sep 2024 10:39:06 +0200 Message-ID: <2ea6dda2934aef3b597e42058bc4be85a61f905d.camel@pengutronix.de> From: Philipp Zabel To: Michael Olbrich Date: Thu, 26 Sep 2024 10:39:06 +0200 In-Reply-To: References: <20240920082126.1593831-1-p.zabel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: Re: [ptxdist] [PATCH v2] mesalib: version bump 24.2.2 -> 24.2.3 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Do, 2024-09-26 at 09:18 +0200, Michael Olbrich wrote: > On Fri, Sep 20, 2024 at 10:21:26AM +0200, Philipp Zabel wrote: > > Signed-off-by: Philipp Zabel > > --- > > v2: don't install libgallium_drv_video.so, link VA drivers to ../libgal= lium-24.2.3.so > > --- > > rules/mesalib.make | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > >=20 > > diff --git a/rules/mesalib.make b/rules/mesalib.make > > index c18056a97db7..379bbdf1173c 100644 > > --- a/rules/mesalib.make > > +++ b/rules/mesalib.make > > @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_MESALIB) +=3D mesalib > > # > > # Paths and names > > # > > -MESALIB_VERSION :=3D 24.2.2 > > -MESALIB_MD5 :=3D 2efcf055c7d48b12cd2c9df2fc41f1b0 > > +MESALIB_VERSION :=3D 24.2.3 > > +MESALIB_MD5 :=3D e3a195842c5cfbfb7234ed45f70af787 > > MESALIB :=3D mesa-$(MESALIB_VERSION) > > MESALIB_SUFFIX :=3D tar.xz > > MESALIB_URL :=3D \ > > @@ -294,12 +294,10 @@ ifdef PTXCONF_MESALIB_EGL_X11 > > endif > > endif > > ifneq ($(strip $(MESALIB_DRI_VA_LIBS-y)),) > > - @$(call install_copy, mesalib, 0, 0, 0644, -, /usr/lib/dri/libgallium= _drv_video.so) > > - > > @$(foreach lib, $(MESALIB_DRI_VA_LIBS-y), \ > > test -f $(MESALIB_PKGDIR)/usr/lib/dri/$(lib)_drv_video.so || \ > > ptxd_bailout "missing va driver $(lib)_drv_video.so"$(ptx/nl) \ > > - $(call install_link, mesalib, libgallium_drv_video.so, \ > > + $(call install_link, mesalib, ../libgallium-$(MESALIB_LIBGALLIUM_VER= SION).so, \ >=20 > I'm pretty sure that this is not quite correct. _If_ > libgallium-$(MESALIB_LIBGALLIUM_VERSION).so ist installed, then this work= s. > But if it is not built, then libgallium_drv_video.so is still created and > used. At least, that's what the upstream commit suggests. In practice, only the PTXCONF_MESALIB_DRI_R600/RADEONSI/NOUVEAU options enable VA drivers. All of them also enable a gallium driver that causes libgallium to be installed. regards Philipp