From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from vps-1010511-3500.united-hoster.de ([81.20.132.56] helo=rohieb.name) by metis.ext.pengutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1bkHoA-0004R9-Ee for ptxdist@pengutronix.de; Wed, 14 Sep 2016 23:33:30 +0200 Received: from [192.168.178.246] (p5DDFD9DD.dip0.t-ipconnect.de [93.223.217.221]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: rohieb@rohieb.name) by rohieb.name (Postfix) with ESMTPSA id BD68E2595A68 for ; Wed, 14 Sep 2016 23:32:59 +0200 (CEST) References: <1472811254-8592-1-git-send-email-guille.rodriguez@gmail.com> From: Roland Hieber Message-ID: <2d56a057-d0a8-6efb-73bd-211f652a99ec@rohieb.name> Date: Wed, 14 Sep 2016 23:32:49 +0200 MIME-Version: 1.0 In-Reply-To: Subject: Re: [ptxdist] [PATCH] New package: imagemagick List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0991027135==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0991027135== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SJHcV8T6RqjOP9toGcI5qJc2eMRbtNlig" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SJHcV8T6RqjOP9toGcI5qJc2eMRbtNlig Content-Type: multipart/mixed; boundary="w9sMEdhUakBh4fm8M9p75vXr7K3b65OHI"; protected-headers="v1" From: Roland Hieber To: ptxdist@pengutronix.de Message-ID: <2d56a057-d0a8-6efb-73bd-211f652a99ec@rohieb.name> Subject: Re: [ptxdist] [PATCH] New package: imagemagick References: <1472811254-8592-1-git-send-email-guille.rodriguez@gmail.com> In-Reply-To: --w9sMEdhUakBh4fm8M9p75vXr7K3b65OHI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey hey, On 14.09.2016 08:31, Guillermo Rodriguez Garcia wrote: > Hello, any feedback on this one? >=20 > Guillermo >=20 > 2016-09-02 12:14 GMT+02:00 Guillermo Rodriguez : >> This adds a new package for ImageMagick 7. Some configuration >> options are set to sensible defaults for embedded targets (quantum >> depth set to 8 pixels, HDRI disabled). See notes in imagemagick.make. >> >> Signed-off-by: Guillermo Rodriguez >> >> --- >> rules/imagemagick.in | 41 ++++++++++++++ >> rules/imagemagick.make | 142 +++++++++++++++++++++++++++++++++++++++= +++++++++ >> 2 files changed, 183 insertions(+) >> create mode 100644 rules/imagemagick.in >> create mode 100644 rules/imagemagick.make >> >> diff --git a/rules/imagemagick.in b/rules/imagemagick.in >> new file mode 100644 >> index 0000000..90a0eb6 >> --- /dev/null >> +++ b/rules/imagemagick.in >> @@ -0,0 +1,41 @@ >> +## SECTION=3Dmultimedia_tools >> + >> +menuconfig IMAGEMAGICK >> + tristate >> + select ZLIB if IMAGEMAGICK_USE_ZLIB >> + select LIBPNG if IMAGEMAGICK_USE_LIBPNG >> + select LIBJPEG if IMAGEMAGICK_USE_LIBJPEG I guess these should be tab-aligned before "if", at least I got that as feedback for my patch :) >> + prompt "imagemagick " >> + help >> + ImageMagick=C2=AE is a software suite to create, edit, compo= se, or convert >> + bitmap images. It can read and write images in a variety of = formats >> + (over 200) including PNG, JPEG, JPEG-2000, GIF, TIFF, DPX, E= XR, WebP, >> + Postscript, PDF, and SVG. Use ImageMagick to resize, flip, m= irror, >> + rotate, distort, shear and transform images, adjust image co= lors, apply >> + various special effects, or draw text, lines, polygons, elli= pses and >> + B=C3=A9zier curves. >> + >> +if IMAGEMAGICK >> + >> +config IMAGEMAGICK_USE_ZLIB >> + bool >> + default y >> + prompt "Enable ZLIB" >> + help >> + Enable ZLIB support >> + >> +config IMAGEMAGICK_USE_LIBPNG >> + bool >> + default y >> + prompt "Enable PNG" >> + help >> + Enable PNG support >> + >> +config IMAGEMAGICK_USE_LIBJPEG >> + bool >> + default y >> + prompt "Enable JPEG" >> + help >> + Enable JPEG support >> + >> +endif >> diff --git a/rules/imagemagick.make b/rules/imagemagick.make >> new file mode 100644 >> index 0000000..f07bab7 >> --- /dev/null >> +++ b/rules/imagemagick.make >> @@ -0,0 +1,142 @@ >> +# -*-makefile-*- >> +# >> +# Copyright (C) 2016 by Guillermo Rodriguez >> +# >> +# See CREDITS for details about who has contributed to this project. >> +# >> +# For further information about the PTXdist project and license condi= tions >> +# see the README file. >> +# >> + >> +# >> +# We provide this package >> +# >> +PACKAGES-$(PTXCONF_IMAGEMAGICK) +=3D imagemagick >> + >> +# >> +# Paths and names >> +# >> +IMAGEMAGICK_VERSION :=3D 7.0.2-10 >> +IMAGEMAGICK_MD5 :=3D e1cb23d9c10a8eff228ef30ee281711a >> +IMAGEMAGICK :=3D ImageMagick-$(IMAGEMAGICK_VERSION) >> +IMAGEMAGICK_SUFFIX :=3D tar.xz >> +IMAGEMAGICK_URL :=3D ftp://ftp.nluug.nl/pub/ImageMagic= k/$(IMAGEMAGICK).$(IMAGEMAGICK_SUFFIX) >> +IMAGEMAGICK_SOURCE :=3D $(SRCDIR)/$(IMAGEMAGICK).$(IMAGEMAGICK_SU= FFIX) >> +IMAGEMAGICK_DIR :=3D $(BUILDDIR)/$(IMAGEMAGICK) >> +IMAGEMAGICK_LICENSE :=3D Apache-2.0 >> + >> +# -------------------------------------------------------------------= --------- >> +# Prepare >> +# -------------------------------------------------------------------= --------- >> + >> +IMAGEMAGICK_QUANTUM_DEPTH :=3D 8 If this is an option which is changed often, make it a text field in the =2Ein file. >> + >> +IMAGEMAGICK_PATH :=3D PATH=3D$(CROSS_PATH) >> +IMAGEMAGICK_ENV :=3D $(CROSS_ENV) >> + >> +# >> +# See: http://www.imagemagick.org/script/advanced-unix-installation.p= hp >> +# >> +# Notes: >> +# - Threading is disabled as it brings in a dependency with libgomp.s= o >> +# (OpenMP) which fails at runtime; disabling openmp itself doesn't = seem >> +# to be enough. >> +# - Quantum depth is set to 8. Most display adapters and image format= s >> +# don't support more than 8 bits per pixel quantum (i.e. per each o= f the >> +# R, G, B, and alpha components), and higher values have an impact = in >> +# runtime performance. >> +# - HDRI is disabled. It is not supported by most image formats, and = has >> +# a severe impact in runtime performance. >> +# - The configure script will try to detect external "helper" program= s >> +# available in the host and store their paths in delegates.xml. The= se >> +# are obviously not applicable on the target. Just ignore the gener= ated >> +# delegates.xml file. >> +# >> +IMAGEMAGICK_AUTOCONF :=3D \ >> + $(CROSS_AUTOCONF_USR) \ >> + --disable-docs \ >> + --enable-shared \ >> + --disable-static \ >> + --disable-openmp \ >> + --without-threads \ >> + --without-modules \ >> + --with-quantum-depth=3D$(IMAGEMAGICK_QUANTUM_DEPTH) \ >> + --disable-hdri \ >> + --without-autotrace \ >> + --without-bzlib \ >> + --without-djvu \ >> + --without-dps \ >> + --without-fftw \ >> + --without-flif \ >> + --without-fpx \ >> + --without-fontconfig \ >> + --without-freetype \ >> + --without-gslib \ >> + --without-gvc \ >> + --without-jbig \ >> + --without-lcms \ >> + --without-lqr \ >> + --without-lzma \ >> + --without-magick-plus-plus \ >> + --without-openexr \ >> + --without-openjp2 \ >> + --without-pango \ >> + --without-perl \ >> + --without-raqm \ >> + --without-rsvg \ >> + --without-tiff \ >> + --without-webp \ >> + --without-wmf \ >> + --without-x \ >> + --without-xml \ These options mostly look like they should be additional flags in the =2Ein file, and pull in the respective packages. >> + --$(call ptx/wwo, PTXCONF_IMAGEMAGICK_USE_ZLIB)-zlib \ >> + --$(call ptx/wwo, PTXCONF_IMAGEMAGICK_USE_LIBPNG)-png \ >> + --$(call ptx/wwo, PTXCONF_IMAGEMAGICK_USE_LIBJPEG)-jpeg =2E.. like here :) >> + >> +# -------------------------------------------------------------------= --------- >> +# Target-Install >> +# -------------------------------------------------------------------= --------- >> + >> +$(STATEDIR)/imagemagick.targetinstall: >> + @$(call targetinfo) >> + >> + @$(call install_init, imagemagick) >> + @$(call install_fixup, imagemagick, PRIORITY, optional) >> + @$(call install_fixup, imagemagick, SECTION, base) >> + @$(call install_fixup, imagemagick, AUTHOR, "Guillermo Rodrigu= ez ") >> + @$(call install_fixup, imagemagick, DESCRIPTION, missing) >> + >> + @$(call install_copy, imagemagick, 0, 0, 0755, -, /usr/bin/mag= ick) >> + @$(call install_lib, imagemagick, 0, 0, 0644, libMagickCore-7.= Q$(IMAGEMAGICK_QUANTUM_DEPTH)) >> + @$(call install_lib, imagemagick, 0, 0, 0644, libMagickWand-7.= Q$(IMAGEMAGICK_QUANTUM_DEPTH)) >> + >> + @$(call install_link, imagemagick, magick, /usr/bin/compare) >> + @$(call install_link, imagemagick, magick, /usr/bin/composite)= >> + @$(call install_link, imagemagick, magick, /usr/bin/conjure) >> + @$(call install_link, imagemagick, magick, /usr/bin/convert) >> + @$(call install_link, imagemagick, magick, /usr/bin/identify) >> + @$(call install_link, imagemagick, magick, /usr/bin/magick-scr= ipt) >> + @$(call install_link, imagemagick, magick, /usr/bin/mogrify) >> + @$(call install_link, imagemagick, magick, /usr/bin/montage) >> + @$(call install_link, imagemagick, magick, /usr/bin/stream) >> +# These require X11 support: >> +# @$(call install_link, imagemagick, magick, /usr/bin/animate) >> +# @$(call install_link, imagemagick, magick, /usr/bin/display) >> +# @$(call install_link, imagemagick, magick, /usr/bin/import) =2E.. then you can also install those when the user selects --with-x >> + >> + @$(call install_alternative, imagemagick, 0, 0, 0644, /etc/Ima= geMagick-7/coder.xml) >> + @$(call install_alternative, imagemagick, 0, 0, 0644, /etc/Ima= geMagick-7/colors.xml) >> +# This file contains paths to external programs detected in the host:= >> +# @$(call install_alternative, imagemagick, 0, 0, 0644, /etc/Ima= geMagick-7/delegates.xml) >> + @$(call install_alternative, imagemagick, 0, 0, 0644, /etc/Ima= geMagick-7/log.xml) >> + @$(call install_alternative, imagemagick, 0, 0, 0644, /etc/Ima= geMagick-7/magic.xml) >> + @$(call install_alternative, imagemagick, 0, 0, 0644, /etc/Ima= geMagick-7/mime.xml) >> + @$(call install_alternative, imagemagick, 0, 0, 0644, /etc/Ima= geMagick-7/policy.xml) >> + @$(call install_alternative, imagemagick, 0, 0, 0644, /etc/Ima= geMagick-7/quantization-table.xml) >> + @$(call install_alternative, imagemagick, 0, 0, 0644, /etc/Ima= geMagick-7/thresholds.xml) >> + >> + @$(call install_finish, imagemagick) >> + >> + @$(call touch) >> + >> +# vim: syntax=3Dmake >> -- >> 1.7.9.5 >> --w9sMEdhUakBh4fm8M9p75vXr7K3b65OHI-- --SJHcV8T6RqjOP9toGcI5qJc2eMRbtNlig Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJX2cICAAoJELJBPGbdLD/qcU4QAJ/Sa0LnA0ENhmJCy5NCjo4y 9kQ5wavk9ukdKUdA3BUZ0thFongUrypDdF+CZtXmnkHWnk6xcKjneE05hUd0FdM6 B05ivSs0oserlHRdT7Y8EfH6jX+R9XsiksllhamS9I2eIaoz0WfhOW5at9axeMad Oml7N9/+dN987idz0Efrn9+loLcE8iNZ2Y2WJXXV5PNSocvnoCiQrF1d4+f8I0Pk hx3HADgcHaE6kB+ilpH3pORLvK7pShnqfIz6I0TdmJ43ZSjAY7UI/RseDf/VAE/7 F7TlJq65EkAPBUUjmWOTaqeXZIOhR2wqTiZ1YmgWJlaKYEJ8CPvIjIo8o6ry388C BxNtQ3FdpeVfRGz3g7arTj0BZsBJTFnJo9WSNL+zXCjTwF6/LyXc2oFJvg6rhbCM bTgvlKz072PHHsiA/RSiYN3w/gz6w49dMj0QDGQIVx3ZImoD7pr2Bf7iMt2zyn2h wyyL0Tdewl+jLx4i0cVM8JAN9qWAhzAp09H8J4g0CO/5nk1RPo5joedW1m60ouEJ Yo8cgKIHNfc8Pb7vr2S63DMxrcE3Y8m6Foov/2ZNOyTSn01Kei3Mr7eeI5p2TK8w OR/fIOlgxXay3VUJVpYLRMZxruk+A412S6/3BmUf/S/TC1g1TKb3eCqTA1aWdSGX iWRjTeS0DywNi/Dwan0d =yF/n -----END PGP SIGNATURE----- --SJHcV8T6RqjOP9toGcI5qJc2eMRbtNlig-- --===============0991027135== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============0991027135==--