Re: [ptxdist] [PATCH] python3-pycparser: version bump 2.18 -> 2.21

["Artur Wiebe" <artur@4wiebe.de>]

Hi Michael,

On Tuesday, 30 January, 2024 08:59 CET, Michael Olbrich <m.olbrich@pengutronix.de> wrote:

> Hi,
> 
> On Mon, Jan 29, 2024 at 11:05:53AM +0100, Artur Wiebe wrote:
> > LICENSE file change:
> > "Slightly tweak the LICENSE file to be more canonical"
> 
> Please look at the differences of the file in the old and new version.
> You'll note that the only difference is the copyright year.
> 
> The commit message you mentioned is from a change that was made _after_ the
> new release.
Sorry, you are right. I'll be more careful next time!

> 
> The whole point of the checksum is, that we notice if something changes.
> That means, actually looking at the files, comparing the two versions. So
> we can decided if the license needs to be changed. And finally document the
> whole process in the commit message.
Thank you for the explanation. Maybe it should be mentioned in the docs:
https://www.ptxdist.org/doc/contributing.html#updating-a-package-to-a-new-version

Best Regards,
Artur
> 
> If you are unsure what to do with a change then ask here on the list.
> 
> Regards,
> Michael
> 
> 
> > Signed-off-by: Artur Wiebe <artur@4wiebe.de>
> > ---
> >  rules/python3-pycparser.make | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/rules/python3-pycparser.make b/rules/python3-pycparser.make
> > index 484410713..a4a644778 100644
> > --- a/rules/python3-pycparser.make
> > +++ b/rules/python3-pycparser.make
> > @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_PYTHON3_PYCPARSER) += python3-pycparser
> >  #
> >  # Paths and names
> >  #
> > -PYTHON3_PYCPARSER_VERSION	:= 2.18
> > -PYTHON3_PYCPARSER_MD5		:= 72370da54358202a60130e223d488136
> > +PYTHON3_PYCPARSER_VERSION	:= 2.21
> > +PYTHON3_PYCPARSER_MD5		:= 48f7d743bf018f7bb2ffc5fb976d1492
> >  PYTHON3_PYCPARSER		:= pycparser-$(PYTHON3_PYCPARSER_VERSION)
> >  PYTHON3_PYCPARSER_SUFFIX	:= tar.gz
> >  PYTHON3_PYCPARSER_URL		:= $(call ptx/mirror-pypi, pycparser, $(PYTHON3_PYCPARSER).$(PYTHON3_PYCPARSER_SUFFIX))
> > @@ -23,7 +23,7 @@ PYTHON3_PYCPARSER_SOURCE	:= $(SRCDIR)/$(PYTHON3_PYCPARSER).$(PYTHON3_PYCPARSER_S
> >  PYTHON3_PYCPARSER_DIR		:= $(BUILDDIR)/$(PYTHON3_PYCPARSER)
> >  PYTHON3_PYCPARSER_LICENSE	:= BSD-3-Clause
> >  PYTHON3_PYCPARSER_LICENSE_FILES := \
> > -	file://LICENSE;md5=86f1cedb4e6410a88ce8e30b91079169
> > +	file://LICENSE;md5=2c28cdeabcb88f5843d934381b4b4fea
> >  
> >  # ----------------------------------------------------------------------------
> >  # Prepare
> > -- 
> > 2.43.0
> > 
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>