From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 04 Jul 2022 14:31:25 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o8LEX-005XzH-Ri for lore@lore.pengutronix.de; Mon, 04 Jul 2022 14:31:25 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o8LEa-0006HL-FW; Mon, 04 Jul 2022 14:31:24 +0200 Received: from smtp127.iad3b.emailsrvr.com ([146.20.161.127]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8LEQ-0006Dy-7q for ptxdist@pengutronix.de; Mon, 04 Jul 2022 14:31:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20190130-41we5z8j; t=1656937871; bh=URyhS6irojJN6RUivt59Ru2x9bE42wnsT3YRzzUTpg8=; h=Date:Subject:To:From:From; b=lOG97vxHskK//L/DPmE9YDExDZztoA2x6HLKsMzu60NSxvf+4eQpjmr0/y8I8jnH+ JJloT+5xvCjXSrEYIMPybFt32ZdcDW0NOOhwAh1kcjLpqJCb7HBW4oBtZgcJ0g45EP RFyzc68E5qg+Lm6+51U1nSpFpPj4aQ+rYBLMnpH8= X-Auth-ID: abbotti@mev.co.uk Received: by smtp24.relay.iad3b.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 62B80400F4; Mon, 4 Jul 2022 08:31:11 -0400 (EDT) Message-ID: <2c07edab-1c42-7fe3-29d7-ff8e401a40ca@mev.co.uk> Date: Mon, 4 Jul 2022 13:31:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-GB To: ptxdist@pengutronix.de, Alexander Dahl References: <20220704121831.23787-1-ada@thorsis.com> <20220704121831.23787-7-ada@thorsis.com> From: Ian Abbott Organization: MEV Ltd. In-Reply-To: <20220704121831.23787-7-ada@thorsis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Classification-ID: 509df850-d126-46a8-b1a9-f9340e407190-1-1 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.2 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 6/8] dropbear: Rework key exchange algorithm options X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Bruno Thomsen Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 04/07/2022 13:18, Alexander Dahl wrote: > The options for diffie-hellman key exchange were mixed up with message > integrity hmacs. > > Signed-off-by: Alexander Dahl > --- > rules/dropbear.in | 43 +++++++++++++++++++++++++++++++++++++++++-- > rules/dropbear.make | 36 ++++++++++++++++++++++++++++++++---- > 2 files changed, 73 insertions(+), 6 deletions(-) > > diff --git a/rules/dropbear.in b/rules/dropbear.in > index f7f96a762..043b0e76d 100644 > --- a/rules/dropbear.in > +++ b/rules/dropbear.in [snip] > config DROPBEAR_CURVE25519 > bool > - prompt "curve25519-donna" > + prompt "curve25519" > help > Enable curve25519-donna for key exchange. The name in the prompt now differs from the name in the help text, which might be confusing. > This is another elliptic curve method with good security properties. > This algorithm does not rely on NIST-based curves > and gives us more security confidence against a possible > backdoor in nistp-256 curve. > + > + Small systems should generally include either curve25519 or > + ecdh for performance. > + > +config DROPBEAR_DH_GROUP1 > + bool > + prompt "group1 (legacy, client only)" > + help > + 1024 bit, sha1. > + is too small for security though is necessary if you need > + compatibility with some implementations such as Dropbear > + versions < 0.53. > + Client only! Missing word "This"? -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-