mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 5/7] vulkan-tools: version bump 1.3.231.0 -> 1.3.231.1
Date: Fri, 04 Nov 2022 12:39:52 +0100	[thread overview]
Message-ID: <2bf31f1f93ced90285714f52d37b015f0e0c5062.camel@pengutronix.de> (raw)
In-Reply-To: <Y2TXMvYqw75GAwPZ@pengutronix.de>

On Fr, 2022-11-04 at 10:11 +0100, Michael Olbrich wrote:
> On Thu, Nov 03, 2022 at 05:57:05PM +0100, Philipp Zabel wrote:
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> 
> Fails to build:
> 
> CMake Error at cube/CMakeLists.txt:274 (install):
>   install TARGETS given target "vkcube" which does not exist.   
> 
> 
> CMake Error at cube/CMakeLists.txt:321 (install):
>   install TARGETS given target "vkcubepp" which does not exist.
> 
> 
> CMake Error at cube/CMakeLists.txt:353 (install):
>   install TARGETS given target "vkcube-wayland" which does not exist.

I missed that cube/CMakeList.txt still contains the

  if(${CMAKE_SYSTEM_PROCESSOR} STREQUAL ${CMAKE_HOST_SYSTEM_PROCESSOR})

checks.

> And there are issues with the 1.3.231.0 patches as well, so please
> fix and squash the two series.

Fixed, squashed, and resent. Marked the VULKAN_TOOLS_CUBE option as
BROKEN again.

regards
Philipp



  reply	other threads:[~2022-11-04 11:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 16:57 [ptxdist] [PATCH 1/7] glslang: " Philipp Zabel
2022-11-03 16:57 ` [ptxdist] [PATCH 2/7] spirv-headers: " Philipp Zabel
2022-11-03 16:57 ` [ptxdist] [PATCH 3/7] spirv-tools: " Philipp Zabel
2022-11-03 16:57 ` [ptxdist] [PATCH 4/7] vulkan-loader: " Philipp Zabel
2022-11-03 16:57 ` [ptxdist] [PATCH 5/7] vulkan-tools: " Philipp Zabel
2022-11-04  9:11   ` Michael Olbrich
2022-11-04 11:39     ` Philipp Zabel [this message]
2022-11-03 16:57 ` [ptxdist] [PATCH 6/7] vulkan-validationlayers: " Philipp Zabel
2022-11-03 16:57 ` [ptxdist] [PATCH 7/7] shaderc: version bump v2022.1 -> v2022.3 Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bf31f1f93ced90285714f52d37b015f0e0c5062.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox