From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 17 Jun 2022 13:47:39 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o2ARt-0059qL-S9 for lore@lore.pengutronix.de; Fri, 17 Jun 2022 13:47:39 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o2ARu-0006xo-9u; Fri, 17 Jun 2022 13:47:38 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o2ARW-0006xO-To; Fri, 17 Jun 2022 13:47:15 +0200 Message-ID: <2a5e1e8a93ac948c1e940df0f59398a5f7455b5f.camel@pengutronix.de> From: Enrico =?ISO-8859-1?Q?J=F6rns?= To: Michael Olbrich , ptxdist@pengutronix.de, jlu@pengutronix.de Date: Fri, 17 Jun 2022 13:47:14 +0200 In-Reply-To: <20220617104814.GR13709@pengutronix.de> References: <20220615142217.990960-1-ejo@pengutronix.de> <20220615142217.990960-3-ejo@pengutronix.de> <20220617102750.GQ13709@pengutronix.de> <20220617104814.GR13709@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2-1 MIME-Version: 1.0 Subject: Re: [ptxdist] [PATCH 2/5] RAUC: add option to enable streaming support X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ejo Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Am Freitag, dem 17.06.2022 um 12:48 +0200 schrieb Michael Olbrich: > On Fri, Jun 17, 2022 at 12:27:50PM +0200, Michael Olbrich wrote: > > On Fri, Jun 17, 2022 at 11:47:19AM +0200, Enrico J=C3=B6rns wrote: > > > Am Freitag, dem 17.06.2022 um 08:28 +0200 schrieb Michael Olbrich: > > > > On Wed, Jun 15, 2022 at 04:22:14PM +0200, Enrico Jorns wrote: > > > > > Enable it by default so that default installation can benefit fro= m this. > > > > > Can be deactivated for saving space or for deactivating network > > > > > functionality. > > > > > Web server must support HTTP range requests for this and NBD supp= ort > > > > > must be enabled in kernel. > > > > >=20 > > > > > Signed-off-by: Enrico Jorns > > > > > --- > > > > > rules/rauc.in | 11 +++++++++++ > > > > > rules/rauc.make | 1 + > > > > > 2 files changed, 12 insertions(+) > > > > >=20 > > > > > diff --git a/rules/rauc.in b/rules/rauc.in > > > > > index aee162b83..832967b44 100644 > > > > > --- a/rules/rauc.in > > > > > +++ b/rules/rauc.in > > > > > @@ -13,6 +13,7 @@ menuconfig RAUC > > > > > select BUSYBOX_FEATURE_SEAMLESS_GZ if BUSYBOX_TAR > > > > > select DBUS if RAUC_SERVICE > > > > > select LIBCURL if RAUC_NETWORK > > > > > + select LIBNL3 if RAUC_STREAMING > > > > > select JSON_GLIB if RAUC_JSON > > > > > select UTIL_LINUX_NG_LIBFDISK if RAUC_GPT > > > > > select SQUASHFS_TOOLS if RUNTIME > > > > > @@ -44,6 +45,16 @@ config RAUC_NETWORK > > > > > Note that network is primarily designed to be used for RAUC'S= casync > > > > > capabilities, not for fetching full bundles. > > > > > =20 > > > > > +config RAUC_STREAMING > > > > > + bool > > > > > + prompt "Enable streaming support" > > > > > + default y > > > >=20 > > > > Why 'default y'? I think most users won't need this. > > >=20 > > > I am not convinced that streaming is not required for most users. I g= uess that > > > being able to download bundles form HTTP directly is a use case that = is more and > > > more common. With network and streaming enabled, one can download bun= dles only > > > externally or install from USB sticks etc. > > >=20 > > > In Yocto we have this enabled by default, too. If it's ptxdist's phil= osophy to > > > ship as little features as possible by default (i.e. focus on small s= ize), we > > > can also make this default n. > >=20 > > The thing is, nobody changes the defaults unless they notice something = is > > not working as expected. And enabling things in PTXdist is easy. Indeed. > > How does this work anyways? If I call 'rauc install ', will t= his > > use streaming implicitly or does it require an explicit option? No explicit option required. Streaming will be used by default. But require= d NBD support to be enabled in the kernel. Without streaming enabled (only network enabled), the download size of RAUC= is limited by default to allow only casync bundles that do not have any image inside (only index files). > > How about 'default RAUC_NETWORK'? This way those that use networking al= so > > get streaming by default. >=20 > Grr, kconfig does not allow that. So it'll be disabled by default. >=20 > Hmmm, or maybe just use the same option? What would the consequences be? As up to now the use case for RAUC_NETWORK was primarily casync support, I = would assume that most of these existing users do not require/benefit from built-= in streaming. Thus maybe just make it 'n' then. Note that I have to rebase this series anyway in case the other rauc series= I sent (for pinning configure options) is applied. Regards, Enrico > Michael >=20 --=20 Pengutronix e.K.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Enrico J=C3=B6rns=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Embedded Linux Consulting & Support=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| https://www.pengutronix.de/ | Steuerwalder Str. 21=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| Phone: +49-5121-206917-180=C2=A0=C2=A0| 31137 Hildesheim, Germany=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Fax:=C2=A0=C2= =A0=C2=A0+49-5121-206917-9=C2=A0=C2=A0=C2=A0=C2=A0|