From: Alexander Dahl <ada@thorsis.com>
To: ptxdist@pengutronix.de
Cc: Denis OSTERLAND <denis.osterland@diehl.com>
Subject: Re: [ptxdist] [PATCH v2] yajl: add new package
Date: Fri, 22 Jun 2018 10:52:15 +0200 [thread overview]
Message-ID: <2841062.rOQmo8klO0@ada> (raw)
In-Reply-To: <1529656375.4757.22.camel@diehl.com>
Hello Denis,
> > > +#
> > > +# autoconf
> > > +#
> > > +YAJL_CONF_TOOL := cmake
> >
> > Comment does not match assignment. ;-)
>
> You are guess configtool as comment would be better.
From the 'src-cmake-prog' template you would get:
#
# cmake
#
FOO_CONF_TOOL := cmake
> Shall we patch it in the template?
I guess you used the 'target' template, which got you this:
#
# autoconf
#
FOO_CONF_TOOL := autoconf
I would not touch this in the template, it is consistent.
So I would say, just change the comment to 'cmake' or remove those comment
lines. The line assigning the conf tool speaks for itself.
Greets
Alex
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-06-22 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 12:56 [ptxdist] [PATCH] " Denis OSTERLAND
2018-06-22 7:19 ` Michael Olbrich
2018-06-22 7:37 ` Denis OSTERLAND
2018-06-22 8:12 ` [ptxdist] [PATCH v2] " Denis OSTERLAND
2018-06-22 8:25 ` Alexander Dahl
2018-06-22 8:32 ` Denis OSTERLAND
2018-06-22 8:52 ` Alexander Dahl [this message]
2018-06-22 9:07 ` Denis OSTERLAND
2018-06-22 9:15 ` Alexander Dahl
2018-06-22 9:42 ` [ptxdist] [PATCH v3] " Denis OSTERLAND
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2841062.rOQmo8klO0@ada \
--to=ada@thorsis.com \
--cc=denis.osterland@diehl.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox