mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v1 2/2] ethtool: build out-of-tree
Date: Fri, 03 Jul 2020 11:18:30 +0200	[thread overview]
Message-ID: <275441b3ba26e941e8e90c66e0a1f59917bddde7.camel@pengutronix.de> (raw)
In-Reply-To: <20200703090829.GB24749@pengutronix.de>

Am Freitag, den 03.07.2020, 11:08 +0200 schrieb Michael Olbrich:
> On Mon, Jun 29, 2020 at 10:13:26AM +0200, Oleksij Rempel wrote:
> > Make it easier to work with git source shared between different BSPs.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  rules/ethtool.make | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rules/ethtool.make b/rules/ethtool.make
> > index 649e3e580..d8b957123 100644
> > --- a/rules/ethtool.make
> > +++ b/rules/ethtool.make
> > @@ -22,6 +22,7 @@ ETHTOOL		:= ethtool-$(ETHTOOL_VERSION)
> >  ETHTOOL_URL	:= $(call ptx/mirror, KERNEL, ../software/network/ethtool/$(ETHTOOL).$(ETHTOOL_SUFFIX))
> >  ETHTOOL_SOURCE	:= $(SRCDIR)/$(ETHTOOL).$(ETHTOOL_SUFFIX)
> >  ETHTOOL_DIR	:= $(BUILDDIR)/$(ETHTOOL)
> > +ETHTOOL_BUILD_OOT := YES
> 
> I don't want to do this for random packages. I've done it for the kernel
> because it's more complex there. But in this case you can just create a
> rules/post/ethtool-fixup.make and add the line there locally.

While looking into something different I noticed that the pre/post
rules mechanism isn't really documented anywhere, but I don't really
feel confident to type a documentation patch myself. Would be nice if
someone with a solid understanding of this could add some bits to the
ptxdist docs.

Regards
Lucas


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2020-07-03  9:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29  8:13 [ptxdist] [PATCH v1 1/2] ethtool: version bump 5.1 -> 5.7 Oleksij Rempel
2020-06-29  8:13 ` [ptxdist] [PATCH v1 2/2] ethtool: build out-of-tree Oleksij Rempel
2020-07-03  9:08   ` Michael Olbrich
2020-07-03  9:18     ` Lucas Stach [this message]
2020-06-29  9:17 ` [ptxdist] [PATCH v1 1/2] ethtool: version bump 5.1 -> 5.7 Lucas Stach
2020-07-03  9:06   ` Michael Olbrich
2020-07-06  6:31 ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=275441b3ba26e941e8e90c66e0a1f59917bddde7.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox