Re: [ptxdist] [PATCH 1/4] libjpeg: enable building libturbojpeg

[Philipp Zabel <p.zabel@pengutronix.de>]

Hi Christian,

On Fr, 2022-02-18 at 17:27 +0100, Christian Melki wrote:
> On 2/18/22 17:08, Philipp Zabel wrote:
> > Enable building libturbojpeg for users of the simplified API.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >  rules/libjpeg.in   | 7 +++++++
> >  rules/libjpeg.make | 5 ++++-
> >  2 files changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/rules/libjpeg.in b/rules/libjpeg.in
> > index 53a9d9e09701..3304c6ac896f 100644
> > --- a/rules/libjpeg.in
> > +++ b/rules/libjpeg.in
> > @@ -19,4 +19,11 @@ config LIBJPEG_BIN
> >           cjpeg and djpeg are simple bineries to convert some basic
> > image
> >           formats to jpeg (cjpeg) or convert them back from jpeg
> > (djpeg)
> >  
> > +config LIBJPEG_TURBO
> > +       bool
> > +       prompt "Build and install libturbojpeg"
> > +       help
> > +         In addition to the traditional libjpeg API, also provide
> > the less
> > +         powerful but more straightforward TurboJPEG API.
> > +
> >  endif
> > diff --git a/rules/libjpeg.make b/rules/libjpeg.make
> > index 559a6d08d504..704f810a4bd4 100644
> > --- a/rules/libjpeg.make
> > +++ b/rules/libjpeg.make
> > @@ -60,7 +60,7 @@ LIBJPEG_CONF_OPT := \
> >         -DWITH_JPEG8=ON \
> >         -DWITH_MEM_SRCDST=ON \
> >         -DWITH_SIMD=$(call ptx/onoff,LIBJPEG_SIMD) \
> > -       -DWITH_TURBOJPEG=OFF
> > +       -DWITHOUT_TURBOJPEG=$(call ptx/ifdef,
> > PTXCONF_LIBJPEG_TURBO,OFF,ON)
> 
> Looks weird. Didn't -DWITH work?

Thank you, that's just an artifact of parallel history. I initially
wrote this when the libjpeg rule still had -DWITHOUT_TURBOJPEG=ON and
didn't notice this was changed with the 2.0.5 -> 2.1.0 version bump.

Using -DWITH_TURBOJPEG=$(call ptx/onoff,PTXCONF_LIBJPEG_TURBO) works
just fine. Will fix and resend this patch.

regards
Philipp

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de