Re: [ptxdist] mesalib 2021.11 broken kmsro driver?

[Christian Melki <christian.melki@t2data.com>]

On 11/8/21 15:08, Lucas Stach wrote:
> Am Montag, dem 08.11.2021 um 14:37 +0100 schrieb Christian Melki:
>> On 11/8/21 14:03, Michael Olbrich wrote:
>>> Hi,
>>>
>>> On Mon, Nov 08, 2021 at 11:16:11AM +0100, Christian Melki wrote:
>>>> The kmsro driver doesn't seem to create any .so files.
>>>> According to people on #dri-devel it's builtin in other .so files?
>>>> So the idea of kmsro library names to copy will fail in the current .make.
>>>
>>> What exactly is broken?
>>
>> ptxdist: error: missing gallium driver armada-drm_dri.so
>>
>>> In general, all gallium drivers are built into a
>>> single file. 'make install' creates hardlinks for all drivers that are
>>> built. In ptxdist we just create one gallium_dri.so and symlinks for all
>>> drivers.
>>> The 'kmsro' argument for the meson 'gallium-drivers' options just means,
>>> build all KMS only drivers. So the list of hardlinks/softlinks ist
>>> different. That's why we have the '$(subst kmsro, ....'.
>>
>> kmsro doesn't create any library hardlinks named according to whatever
>> list ptxdist has. Actually, adding kmsro doesn't change built number of
>> objects or generated library hardlinks at all.
>>
>> with kmsro:
>>         Gallium drivers: kmsro virgl r600 nouveau swrast svga
>>
>> [1621/1621] Linking target src/mesa/drivers/dri/libmesa_dri_drivers.so
>>
>> $ ls -1gG platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/*
>> -rwxr-xr-x  2  94331520 nov  8 14:25
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/i965_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:25
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/kms_swrast_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:25
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/nouveau_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:25
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/r600_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:25
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/swrast_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:25
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/virtio_gpu_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:25
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/vmwgfx_dri.so
>>
>>
>> without kmsro:
>>         Gallium drivers: virgl r600 nouveau swrast svga
>>
>> [1621/1621] Linking target src/mesa/drivers/dri/libmesa_dri_drivers.so
>> $ ls -1gG platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/*
>> -rwxr-xr-x  2  94331520 nov  8 14:34
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/i965_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:34
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/kms_swrast_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:34
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/nouveau_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:34
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/r600_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:34
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/swrast_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:34
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/virtio_gpu_dri.so
>> -rwxr-xr-x 12 127009440 nov  8 14:34
>> platform-secplatform/packages/mesa-21.2.3/usr/lib/dri/vmwgfx_dri.so
>>
>> .. or something else that's apparently magic is happening.
> 
> kmsro just wraps around other drivers that support the render GPU being
> different from the scanout GPU. From the list above you have not
> enabled any of those drivers (e.g. etnaviv, freedreno, panfrost, ...),
> so there isn't anything to wrap around for kmsro, so you don't get any
> libraries built.
> 

In that case ptxdist makes a static assumption that libraries are being
built and named, regardless what is selected?
Problem is that $(firstword) from the GALLIUM_LIBS is expected to exist
if kmsro is selected?

MESALIB_DRI_GALLIUM_LIBS-y = \
        $(subst kmsro, \
                armada-drm \
                exynos \
                hx8357d \
                ili9225 \
                ili9341 \
                imx-dcss \
                imx-drm \
                ingenic-drm \
                mali-dp \
                mcde \
                mediatek \
                meson \
                mi0283qt \
                mxsfb-drm \
                pl111 \
                repaper \
                rockchip \
                st7586 \
                st7735r \
                stm \
                sun4i-drm \

> Regards,
> Lucas
> 


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de