From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
From: Alexander Dahl <ada@thorsis.com>
Date: Fri, 09 Aug 2019 12:01:33 +0200
Message-ID: <2206289.70BF7xdW8B@ada>
In-Reply-To: <20190809095203.yrnjn5gqvlm2hnkq@pengutronix.de>
References: <20190809084744.6640-1-ada@thorsis.com>
 <20190809095203.yrnjn5gqvlm2hnkq@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] mosquitto: version bump 1.4.14 -> 1.6.4
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>

Hello Michael,

Am Freitag, 9. August 2019, 11:52:03 CEST schrieb Michael Olbrich:
> On Fri, Aug 09, 2019 at 10:47:44AM +0200, Alexander Dahl wrote:
> > This includes a lot of security fixes, bug fixes, fixed build issues,
> > new features, and removed features. Notable for this package:
> > 
> > * libuuid support removed
> > * new systemd service unit
> > * copied config file from upstream example, changed unpriviledged user
> > 
> >   to "daemon" (already exists in ptxdist)
> 
> The default user is mosquitto, right? Please introduce that user and copy
> the example mosquitto.conf to the pkgdir in the install stage. This way it
> will be used as fallback if no other config is found.
> Otherwise the config in projectroot/ will become outdated if we're not very
> careful.

That came to my mind, but I was not sure if that's desired. Now I know. ;-)

> > Notes:
> >     I squeezed the version bump and the new stuff for running the broker
> >     with systemd in one commit. Let me know if I should split it up.

I will split up the patch into several patches and resend a v2 then.

Greets
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de