Re: [ptxdist] [PATCH] seatd: Update URL and hash.

[Christian Melki <christian.melki@t2data.com>]

On 3/24/23 07:51, Michael Olbrich wrote:
> On Fri, Mar 24, 2023 at 07:47:10AM +0100, Michael Olbrich wrote:
>> On Thu, Mar 23, 2023 at 09:04:48PM +0100, Christian Melki wrote:
>>> For unknown reasons, seatd tarball changed it's hash for
>>> the same version. Fortunately, I had an old copy of seatd
>>> and could compare. No differences noted (please double check).
>>> I chalk this down to a rebuild of tarballs or something.
>>> Anyway. I changed URL to the github mirror just in case.
>>> Also, hopefully less fidgety with the tarballs.
>>>
>>> Signed-off-by: Christian Melki <christian.melki@t2data.com>
>>> ---
>>>  rules/seatd.make | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/rules/seatd.make b/rules/seatd.make
>>> index 64876313a..5df69ac91 100644
>>> --- a/rules/seatd.make
>>> +++ b/rules/seatd.make
>>> @@ -16,10 +16,10 @@ PACKAGES-$(PTXCONF_SEATD) += seatd
>>>  # Paths and names
>>>  #
>>>  SEATD_VERSION		:= 0.7.0
>>> -SEATD_MD5		:= 922b8a4ca4dfdb1f43a294db9e77bcf7
>>> +SEATD_MD5		:= a326424b2fccf8d6ae630063ba735aa1
>>
>> Please add the new hash (space separated list). This way either hash is
>> accepted. This helps those with the old file in their local cache.
>>
>>>  SEATD			:= seatd-$(SEATD_VERSION)
>>>  SEATD_SUFFIX		:= tar.gz
>>> -SEATD_URL		:= https://git.sr.ht/~kennylevinsen/seatd/archive/$(SEATD_VERSION).$(SEATD_SUFFIX)
>>> +SEATD_URL		:= https://github.com/kennylevinsen/seatd/archive/refs/tags/$(SEATD_VERSION).$(SEATD_SUFFIX)
> 
> Oh, and git.sr.ht is the official upstream. So I'd like to keep that URL.
> Any reason for the change?
> 
> Michael
> 

None other than I don't like release tarballs that change hashes for no
apparent reason. Much like buildroot triggered mitm attack warnings, so
did my brain. :)

If github reverts their gzip changes and git.sr.ht picks it up, then
we'd be back to the original hash again. gleh.

I think just drop this. Now that I know the real cause behind hash
changes, I'm much less inclined to change anything.

Christian

>>>  SEATD_SOURCE		:= $(SRCDIR)/$(SEATD).$(SEATD_SUFFIX)
>>>  SEATD_DIR		:= $(BUILDDIR)/$(SEATD)
>>>  SEATD_LICENSE		:= MIT
>>> -- 
>>> 2.34.1
>>>
>>>
>>>
>>
>> -- 
>> Pengutronix e.K.                           |                             |
>> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>>
>>
>