From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iff5U-0004sC-D9 for ptxdist@pengutronix.de; Fri, 13 Dec 2019 08:10:08 +0100 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 9B7275081 for ; Fri, 13 Dec 2019 08:12:02 +0100 (CET) Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F4kiJXD4igdr for ; Fri, 13 Dec 2019 08:11:59 +0100 (CET) From: Alexander Dahl Date: Fri, 13 Dec 2019 08:09:59 +0100 Message-ID: <2155458.f02S62lH7P@ada> In-Reply-To: <20191212163058.7883-1-guille.rodriguez@gmail.com> References: <20191212163058.7883-1-guille.rodriguez@gmail.com> Subject: Re: [ptxdist] [PATCH] u-boot: Add support for u-boot.stm32 binary List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: Guillermo =?ISO-8859-1?Q?Rodr=EDguez?= Hello Guillermo, Am Donnerstag, 12. Dezember 2019, 17:30:58 CET schrieb Guillermo Rodr=EDgue= z: > Adds support for copying u-boot.stm32 (u-boot with STM32 image header) > to the platform image directory. This is used by STM32MP1 SoCs. > = > Signed-off-by: Guillermo Rodriguez > --- > platforms/u-boot.in | 7 +++++++ > rules/u-boot.make | 5 ++++- > 2 files changed, 11 insertions(+), 1 deletion(-) > = > diff --git a/platforms/u-boot.in b/platforms/u-boot.in > index aab9c57a3..1d682d1c3 100644 > --- a/platforms/u-boot.in > +++ b/platforms/u-boot.in > @@ -220,5 +220,12 @@ config U_BOOT_INSTALL_U_BOOT_WITH_SPL_PBL > Installing the U-Boot binary which contains as well the SPL and PBL. > Say yes if you are building for Layerscape SoCs > = > +config U_BOOT_INSTALL_U_BOOT_STM32 > + prompt "install u-boot.stm32" > + bool > + help > + Installing the U-Boot image with stm32 header (u-boot.stm32) into > platform + image directory. Say yes if you are building for STM32MP1 SO= C. > + > endif Trailing whitespace and lines longer than 80 chars. > = > diff --git a/rules/u-boot.make b/rules/u-boot.make > index 04d801fc6..57d69e15f 100644 > --- a/rules/u-boot.make > +++ b/rules/u-boot.make > @@ -167,6 +167,9 @@ ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_WITH_SPL_PBL > @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot-with-spl-pbl.bin \ > $(IMAGEDIR)/u-boot-with-spl-pbl.bin > endif > +ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_STM32 > + @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot.stm32 > $(IMAGEDIR)/u-boot.stm32 +endif > ifndef PTXCONF_U_BOOT_ENV_IMAGE_NONE > @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot-env.img \ > $(IMAGEDIR)/u-boot-env.img > @@ -197,7 +200,7 @@ $(STATEDIR)/u-boot.clean: > @rm -vf $(IMAGEDIR)/u-boot.img $(IMAGEDIR)/SPL $(IMAGEDIR)/MLO > @rm -vf $(IMAGEDIR)/u-boot.imx $(IMAGEDIR)/u-boot-dtb.imx > @rm -vf $(IMAGEDIR)/u-boot-env.img > - @rm -vf $(IMAGEDIR)/u-boot-dtb.bin $(IMAGEDIR)/u-boot-with-spl-pbl.bin > + @rm -vf $(IMAGEDIR)/u-boot-dtb.bin $(IMAGEDIR)/u-boot-with-spl-pbl.bin > $(IMAGEDIR)/u-boot.stm32 Also long line here. Otherwise fine, so: Reviewed-by: Alexander Dahl Greets Alex > = > # > -------------------------------------------------------------------------= -- > - # oldconfig / menuconfig _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de