From: Alexander Dahl <ada@thorsis.com>
To: ptxdist@pengutronix.de
Cc: "Guillermo Rodríguez" <guille.rodriguez@gmail.com>
Subject: Re: [ptxdist] [PATCH] u-boot: Add support for u-boot.stm32 binary
Date: Fri, 13 Dec 2019 08:09:59 +0100 [thread overview]
Message-ID: <2155458.f02S62lH7P@ada> (raw)
In-Reply-To: <20191212163058.7883-1-guille.rodriguez@gmail.com>
Hello Guillermo,
Am Donnerstag, 12. Dezember 2019, 17:30:58 CET schrieb Guillermo Rodríguez:
> Adds support for copying u-boot.stm32 (u-boot with STM32 image header)
> to the platform image directory. This is used by STM32MP1 SoCs.
>
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
> platforms/u-boot.in | 7 +++++++
> rules/u-boot.make | 5 ++++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> index aab9c57a3..1d682d1c3 100644
> --- a/platforms/u-boot.in
> +++ b/platforms/u-boot.in
> @@ -220,5 +220,12 @@ config U_BOOT_INSTALL_U_BOOT_WITH_SPL_PBL
> Installing the U-Boot binary which contains as well the SPL and PBL.
> Say yes if you are building for Layerscape SoCs
>
> +config U_BOOT_INSTALL_U_BOOT_STM32
> + prompt "install u-boot.stm32"
> + bool
> + help
> + Installing the U-Boot image with stm32 header (u-boot.stm32) into
> platform + image directory. Say yes if you are building for STM32MP1 SOC.
> +
> endif
Trailing whitespace and lines longer than 80 chars.
>
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index 04d801fc6..57d69e15f 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -167,6 +167,9 @@ ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_WITH_SPL_PBL
> @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot-with-spl-pbl.bin \
> $(IMAGEDIR)/u-boot-with-spl-pbl.bin
> endif
> +ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_STM32
> + @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot.stm32
> $(IMAGEDIR)/u-boot.stm32 +endif
> ifndef PTXCONF_U_BOOT_ENV_IMAGE_NONE
> @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot-env.img \
> $(IMAGEDIR)/u-boot-env.img
> @@ -197,7 +200,7 @@ $(STATEDIR)/u-boot.clean:
> @rm -vf $(IMAGEDIR)/u-boot.img $(IMAGEDIR)/SPL $(IMAGEDIR)/MLO
> @rm -vf $(IMAGEDIR)/u-boot.imx $(IMAGEDIR)/u-boot-dtb.imx
> @rm -vf $(IMAGEDIR)/u-boot-env.img
> - @rm -vf $(IMAGEDIR)/u-boot-dtb.bin $(IMAGEDIR)/u-boot-with-spl-pbl.bin
> + @rm -vf $(IMAGEDIR)/u-boot-dtb.bin $(IMAGEDIR)/u-boot-with-spl-pbl.bin
> $(IMAGEDIR)/u-boot.stm32
Also long line here. Otherwise fine, so:
Reviewed-by: Alexander Dahl <ada@thorsis.com>
Greets
Alex
>
> #
> ---------------------------------------------------------------------------
> - # oldconfig / menuconfig
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2019-12-13 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 16:30 Guillermo Rodríguez
2019-12-13 7:09 ` Alexander Dahl [this message]
2019-12-13 8:26 ` [ptxdist] [PATCH v2] " Guillermo Rodríguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2155458.f02S62lH7P@ada \
--to=ada@thorsis.com \
--cc=guille.rodriguez@gmail.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox