From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 01 Nov 2023 17:05:28 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qyDig-00DsUN-EW for lore@lore.pengutronix.de; Wed, 01 Nov 2023 17:05:28 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qyDif-0006pl-BO; Wed, 01 Nov 2023 17:05:25 +0100 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qyDiB-0006nf-E8 for ptxdist@pengutronix.de; Wed, 01 Nov 2023 17:05:02 +0100 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E37F93200583 for ; Wed, 1 Nov 2023 12:04:52 -0400 (EDT) Received: from imap50 ([10.202.2.100]) by compute2.internal (MEProxy); Wed, 01 Nov 2023 12:04:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emailplus.org; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1698854692; x=1698941092; bh=HjnUGpyyaJu6ErwCrl1SZjX6N vBXIrBDmyftb/l7lUM=; b=CKAQ22wHuTXXF5uj1faXgZNQoutbKcaf1fnHm3eSZ Fntd/z8buGMxY5hGAQVW/S4VB7VftoNB4QKzM+6x38vOEms5NNVLebs4J9uexnJi ilRhxmA9F76P02NoxS1p9ZPZXdrMV9VYI8oIVLdGLRCIiN0mMgC9XqGxUkPV1pcY aEx7ePbjPxw9JhJmqNAmOpr08hTm2xwaM1qOdln2BIA4j/Bm/6LAGTTNYvl06N3F HLfnxlag7h3bCCcBu/zE2AM9xhC3kHYZnII91roKMByXN3bJsqeXSaMWMrbAut/a oSvRzUl8c5iZrsH+BPTdgq9VmWJwHc8K+wkT+RfuPj4rQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698854692; x=1698941092; bh=HjnUGpyyaJu6ErwCrl1SZjX6NvBXIrBDmyf tb/l7lUM=; b=uEM0YDRN4fJGJTVG/aGSMPjteXa1G58n0Q37OfF1phNbpvUZ1Ku 8NKbSXNq5T4dyWYkIL2y8sgUuSFeKRBHlACe0VeNE5Kx9kq2hr5FEinc93Zl/sgY kD1gmIPfVKElwgM3RZPpidjg66c5+wh/9MRkKCUo/OZayc5vqN5UHj2OIR9MS6tJ C2R4R9wECvIRxCl9fiKfFuguTkEYQ3grc301WfpED4tNy4X1E24dDBFOJupjC5Y/ ss9quB7H9STh6AQyYX8H2uKugEXH6ufeq9pQMqWwm4AuJUZRm/3ZdH9gLJ0UT6j6 HMjubg+e/lRBHON1STZrqklgPHOtQfbi6pA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddtgedgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfffhffvufgtsehttdertd erredtnecuhfhrohhmpedflfgvrghnqdevlhgruhguvgcuofhonhhnihhnfdcuoehjtggp mhhonhhnihhnsegvmhgrihhlphhluhhsrdhorhhgqeenucggtffrrghtthgvrhhnpeegff dtvdeugfduhedtjeetleehvedvgeegleeugfelfeefkefhleeitdeitdekleenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjtggpmhhonhhnih hnsegvmhgrihhlphhluhhsrdhorhhg X-ME-Proxy: Feedback-ID: i00d441ac:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1966D1700089; Wed, 1 Nov 2023 12:04:51 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c MIME-Version: 1.0 Message-Id: <2140a7cd-a17c-4400-a223-7692942b1ade@app.fastmail.com> Date: Wed, 01 Nov 2023 17:04:30 +0100 From: "Jean-Claude Monnin" To: ptxdist@pengutronix.de Content-Type: text/plain X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.8 required=4.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: [ptxdist] Error building nodejs in 2023.10.0 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi, When trying to build nodejs with the latest ptxdist, I faced an error about missing a python module `ModuleNotFoundError: No module named '_bz2'` (see [1]). I'm not very proficient with ptxdist, so I would like to check if the solution I came up is correct. Feedback welcome. If solution is ok, feel free to apply it upstream or ask for a proper email patch. I think it's due to following issues: - The host python is missing the option to support BZIP2. I added an option for that. - nodejs.in says it depends on HOST_SYSTEM_PYTHON3, however it seems like the build isn't using system python but host python built by ptxdist. I think it should depend on HOST_PYTHON3 and the new HOST_PYTHON3_BZIP2. See [2] for the patch I applied. Kind regards, Jean-Claude [1] Error message ---------------------- target: nodejs.prepare ---------------------- Node.js configure: Found Python 3.11.2... Traceback (most recent call last): File "/home/jean-claude/code/test-ptxdist/platform-nanopi-rk3588/build-target/node-v18.13.0/./configure", line 28, in import configure File "/home/jean-claude/code/test-ptxdist/platform-nanopi-rk3588/build-target/node-v18.13.0/configure.py", line 14, in import bz2 File "/home/jean-claude/code/test-ptxdist/platform-nanopi-rk3588/sysroot-target/usr/lib/python3.11/bz2.py", line 17, in from _bz2 import BZ2Compressor, BZ2Decompressor ModuleNotFoundError: No module named '_bz2' [2] possible patch diff --git a/rules/host-python3.in b/rules/host-python3.in index e15b90571..64f34affa 100644 --- a/rules/host-python3.in +++ b/rules/host-python3.in @@ -6,6 +6,7 @@ config HOST_PYTHON3 select HOST_LIBFFI select HOST_OPENSSL select HOST_ZLIB if HOST_PYTHON3_ZLIB + select HOST_BZIP2 if HOST_PYTHON3_BZIP2 default y if ALLYES help Python is an interpreted, interactive, @@ -16,4 +17,7 @@ if HOST_PYTHON3 config HOST_PYTHON3_ZLIB bool +config HOST_PYTHON3_BZIP2 + bool + endif diff --git a/rules/nodejs.in b/rules/nodejs.in index 80c6aec21..c75480953 100644 --- a/rules/nodejs.in +++ b/rules/nodejs.in @@ -3,7 +3,8 @@ config NODEJS tristate prompt "Node.js " - select HOST_SYSTEM_PYTHON3 + select HOST_PYTHON3 + select HOST_PYTHON3_BZIP2 select HOST_QEMU select HOST_QEMU_USR select C_ARES