From: Rug Ros <rug2ros@gmail.com>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: Alexander Dahl <ada@thorsis.com>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] Possible bug while compiling the kernel sourced via lndir://
Date: Fri, 20 Nov 2026 09:59:18 +0100 [thread overview]
Message-ID: <20261120095918.66459d0a@laptop-RR> (raw)
In-Reply-To: <av_7XdkLztXR5K5E@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 4360 bytes --]
On Fri, 20 Nov 2026 08:48:45 +0100
Michael Olbrich <m.olbrich@pengutronix.de> wrote:
Hi Michael,
I hope the attached file is the right format.
By the way I corrected an error on my previous version:
the cleanup() function must work on ${dst_cmds}, and not on src.
To Alexander:
I'm lazy, so I copied what I already had from a different package.
The lndir:// URL makes a link to all the files in the local source,
without have to worry that a clean wipe off all the changes.
Good to know there is the alternative you mentioned, probably with less
overhead.
Best regards,
Rugggero
> Hi,
>
> On Fri, Nov 20, 2026 at 08:33:07AM +0100, Rug Ros wrote:
> > n order to make some changes to a device driver, I sourced the kernel
> > via an lndir:// URL.
>
> Why would you need lndir:// for the kernel? The kernel is built
> out-off-tree and should not touch the source tree at all, except to write
> the compile_commands.json...
>
> > The kernel compilation itself succeeds, but the
> > kernel.compile stage subsequently fails with the following error:
> >
> > make: Leaving directory
> > '/home/ruggero/phytec/i.MX6Linux/i.MX6Linux.newKernel/platform-phyFLEX-i.MX6/build-target/linux-6.12.96'
> > sed: can't read
> > /home/ruggero/phytec/i.MX6Linux/i.MX6Linux/platform-phyFLEX-i.MX6/build-target/linux-6.12.96/compile_commands.json:
> > No such file or directory make:
> > ***[/home/ruggero/phytec/i.MX6Linux/i.MX6Linux/rules/kernel.make:276:
> > /home/ruggero/phytec/i.MX6Linux/i.MX6Linux/platform-phyFLEX-i.MX6/state/kernel.compile]
> > Error 2
> >
> >
> > I traced the issue to ptxd_make_world_compile_commands_filter() in
> > ptxd_make_world_compile_commands.sh:
> >
> > In this function the file compile_commands.json is modified using sed,
> > and the source is handled properly (variable ${src_cmds}).
> >
> > If sed succeeds, ptxd_make_world_compile_commands_cleanup() is called.
> >
> > However, ptxd_make_world_compile_commands_cleanup() runs sed on
> > "${pkg_dir}/compile_commands.json". While that path is valid for
> > regular builds, it points to the wrong location when using an lndir://
> > URL.
> >
> > As a workaround, I passed the resolved path as a parameter to
> > ptxd_make_world_compile_commands_cleanup() and updated its second call
> > site in ptxd_make_world_compile.sh accordingly.
> >
> > I have attached a patch with my changes for reference.
>
> ... but the change below is correct anyways. Can you send a proper
> patch[1] please?
>
> Regards,
> Michael
>
> > diff -Naur
> > /mnt/tmp/usr/local/lib/ptxdist-2026.07.0/scripts/lib/ptxd_make_world_compile.sh
> > /usr/local/lib/ptxdist-2026.07.0/scripts/lib/ptxd_make_world_compile.sh
> > ---
> > /mnt/tmp/usr/local/lib/ptxdist-2026.07.0/scripts/lib/ptxd_make_world_compile.sh
> > 2026-06-27 13:07:38.000000000 +0000 +++
> > /usr/local/lib/ptxdist-2026.07.0/scripts/lib/ptxd_make_world_compile.sh
> > 2026-11-19 15:37:54.949219877 +0000 @@ -164,7 +164,7 @@ print "\n]" }'
> > } > "${pkg_dir}/compile_commands.json" &&
> > - ptxd_make_world_compile_commands_cleanup
> > + ptxd_make_world_compile_commands_cleanup
> > "${pkg_dir}/compile_commands.json" fi
> > }
> > export -f ptxd_make_world_compile_finish
> > diff -Naur
> > /mnt/tmp/usr/local/lib/ptxdist-2026.07.0/scripts/lib/ptxd_make_world_compile_commands.sh
> > /usr/local/lib/ptxdist-2026.07.0/scripts/lib/ptxd_make_world_compile_commands.sh
> > ---
> > /mnt/tmp/usr/local/lib/ptxdist-2026.07.0/scripts/lib/ptxd_make_world_compile_commands.sh
> > 2026-06-27 13:07:38.000000000 +0000 +++
> > /usr/local/lib/ptxdist-2026.07.0/scripts/lib/ptxd_make_world_compile_commands.sh
> > 2026-11-19 15:38:31.841776180 +0000 @@ -12,7 +12,7 @@
> > ptxd_make_world_compile_commands_cleanup() { sed -i \ -e 's/
> > *-fno-diagnostics-show-caret//g' \
> > - "${pkg_dir}/compile_commands.json"
> > + "${1}"
> > }
> > export -f ptxd_make_world_compile_commands_cleanup
> >
> > @@ -44,7 +44,7 @@
> > -e "s#\(\"command\": \" *[^ ]*\(gcc\|clang\) \)#\1
> > ${PTXDIST_CROSS_CPPFLAGS} ${pkg_cflags} #" \ -e "s#\(\"command\": \"
> > *[^ ]*++ \)#\1 ${PTXDIST_CROSS_CPPFLAGS} ${pkg_cxxflags} #" \
> > "${src_cmds}" > "${dst_cmds}" &&
> > - ptxd_make_world_compile_commands_cleanup
> > + ptxd_make_world_compile_commands_cleanup "${src_cmds}"
> > }
> > export -f ptxd_make_world_compile_commands_filter
> >
>
>
[-- Attachment #2: 0001-ptxd_make_world_compile_commands-pass-compile_comman.patch --]
[-- Type: text/x-patch, Size: 2151 bytes --]
>From 643641cd4e93295a4518b474d16dc9331becdf09 Mon Sep 17 00:00:00 2001
From: ruggero <rug2ros@gmail.com>
Date: Fri, 20 Nov 2026 09:37:15 +0100
Subject: [PATCH] ptxd_make_world_compile_commands: pass compile_commands.json
path to cleanup
When building kernel sourced via lndir://, compile_commands.json
is not located directly inside ${pkg_dir}.
Pass the resolved file path explicitly to
ptxd_make_world_compile_commands_cleanup() instead of hardcoding
"${pkg_dir}/compile_commands.json".
Signed-off-by: ruggero <rug2ros@gmail.com>
---
scripts/lib/ptxd_make_world_compile.sh | 2 +-
scripts/lib/ptxd_make_world_compile_commands.sh | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/lib/ptxd_make_world_compile.sh b/scripts/lib/ptxd_make_world_compile.sh
index 739e4fb45..033c24ca8 100644
--- a/scripts/lib/ptxd_make_world_compile.sh
+++ b/scripts/lib/ptxd_make_world_compile.sh
@@ -164,7 +164,7 @@ ptxd_make_world_compile_finish() {
print "\n]"
}'
} > "${pkg_dir}/compile_commands.json" &&
- ptxd_make_world_compile_commands_cleanup
+ ptxd_make_world_compile_commands_cleanup "${pkg_dir}/compile_commands.json"
fi
}
export -f ptxd_make_world_compile_finish
diff --git a/scripts/lib/ptxd_make_world_compile_commands.sh b/scripts/lib/ptxd_make_world_compile_commands.sh
index df6baf535..b0522d52b 100644
--- a/scripts/lib/ptxd_make_world_compile_commands.sh
+++ b/scripts/lib/ptxd_make_world_compile_commands.sh
@@ -12,7 +12,7 @@
ptxd_make_world_compile_commands_cleanup() {
sed -i \
-e 's/ *-fno-diagnostics-show-caret//g' \
- "${pkg_dir}/compile_commands.json"
+ "${1}"
}
export -f ptxd_make_world_compile_commands_cleanup
@@ -44,7 +44,7 @@ ptxd_make_world_compile_commands_filter() {
-e "s#\(\"command\": \" *[^ ]*\(gcc\|clang\) \)#\1 ${PTXDIST_CROSS_CPPFLAGS} ${pkg_cflags} #" \
-e "s#\(\"command\": \" *[^ ]*++ \)#\1 ${PTXDIST_CROSS_CPPFLAGS} ${pkg_cxxflags} #" \
"${src_cmds}" > "${dst_cmds}" &&
- ptxd_make_world_compile_commands_cleanup
+ ptxd_make_world_compile_commands_cleanup "${dst_cmds}"
}
export -f ptxd_make_world_compile_commands_filter
--
2.43.0
next prev parent reply other threads:[~2026-11-20 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 7:33 Rug Ros
2026-11-20 7:48 ` Michael Olbrich
2026-11-20 8:59 ` Rug Ros [this message]
2026-11-20 8:22 ` Alexander Dahl via ptxdist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120095918.66459d0a@laptop-RR \
--to=rug2ros@gmail.com \
--cc=ada@thorsis.com \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox