From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [APPLIED] report: spdx_sbom: Convert pkg_name into valid idstring
Date: Mon, 21 Sep 2026 08:38:21 +0200 [thread overview]
Message-ID: <20260921063821.3168463-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20260914112311.93693-4-ada@thorsis.com>
Thanks, applied as 484097bacab0b8987074a54b86b28969bbe351c9.
Michael
[sent from post-receive hook]
On Mon, 21 Sep 2026 08:38:21 +0200, Alexander Dahl <ada@thorsis.com> wrote:
> For referenced elements the SPDX spec does not allow '_' in names, but
> we have packages like for example 'lm_sensors'.
>
> Link: https://spdx.github.io/spdx-spec/v2.3/package-information/#72-package-spdx-identifier-field
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20260914112311.93693-4-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/scripts/report/spdx_sbom.py b/scripts/report/spdx_sbom.py
> index 7c4f1c6bbd1b..252828bc5136 100644
> --- a/scripts/report/spdx_sbom.py
> +++ b/scripts/report/spdx_sbom.py
> @@ -50,7 +50,7 @@ class SpdxSbomGenerator(SbomGenerator):
>
> spdx_pkg = spdx.SPDXPackage()
> spdx_pkg.name = pkg_name
> - spdx_pkg.SPDXID = "SPDXRef-" + pkg_name
> + spdx_pkg.SPDXID = "SPDXRef-" + pkg_name.replace('_', '-')
> if "version" in pkg:
> spdx_pkg.versionInfo = pkg["version"]
> if "url" in pkg:
prev parent reply other threads:[~2026-09-21 6:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 11:23 [ptxdist] [PATCH 0/3] report: spdx_sbom: Assorted minor improvements Alexander Dahl via ptxdist
2026-09-14 11:23 ` [ptxdist] [PATCH 1/3] report: spdx_sbom: Fixed "created" field format Alexander Dahl via ptxdist
2026-09-21 6:38 ` [ptxdist] [APPLIED] " Michael Olbrich
2026-09-14 11:23 ` [ptxdist] [PATCH 2/3] report: spdx_sbom: Fix externalPackageRef type in category SECURITY Alexander Dahl via ptxdist
2026-09-21 6:38 ` [ptxdist] [APPLIED] " Michael Olbrich
2026-09-14 11:23 ` [ptxdist] [PATCH 3/3] report: spdx_sbom: Convert pkg_name into valid idstring Alexander Dahl via ptxdist
2026-09-21 6:38 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921063821.3168463-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ada@thorsis.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox