From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 21 Sep 2026 08:38:38 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x8Xfi-004aVm-01 for lore@lore.pengutronix.de; Mon, 21 Sep 2026 08:38:38 +0200 Received: from [127.0.0.1] (helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1x8Xfg-0000s9-6q; Mon, 21 Sep 2026 08:38:36 +0200 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1x8XfQ-0000Ns-ET for ptxdist@pengutronix.de; Mon, 21 Sep 2026 08:38:20 +0200 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 63DB0200740; Mon, 21 Sep 2026 08:38:20 +0200 (CEST) Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x8XfQ-00213f-14; Mon, 21 Sep 2026 08:38:20 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1x8XfQ-0000000DIFg-17f1; Mon, 21 Sep 2026 08:38:20 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Mon, 21 Sep 2026 08:38:20 +0200 Message-ID: <20260921063820.3168418-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260914112311.93693-3-ada@thorsis.com> References: <20260914112311.93693-3-ada@thorsis.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] report: spdx_sbom: Fix externalPackageRef type in category SECURITY X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as f02fc7ed33f83ea82a9a728fc282ba7ce79b5a61. Michael [sent from post-receive hook] On Mon, 21 Sep 2026 08:38:20 +0200, Alexander Dahl wrote: > pyspdxtools -i image-root-tgz-spdx-sbom.json gives the following error: > > externalPackageRef type in category SECURITY must be one of ['cpe22Type', 'cpe23Type', 'advisory', 'fix', 'url', 'swid'], but is: http://spdx.org/rdf/references/cpe23Type > > Could not find any location in spec which requires that URL in the > referenceType field. > > Link: https://spdx.github.io/spdx-spec/v2.3/package-information/#721-external-reference-field > Link: https://spdx.github.io/spdx-spec/v2.3/external-repository-identifiers/#f2-security > Signed-off-by: Alexander Dahl > Message-Id: <20260914112311.93693-3-ada@thorsis.com> > Signed-off-by: Michael Olbrich > > diff --git a/scripts/report/spdx_sbom.py b/scripts/report/spdx_sbom.py > index f39b37487222..7c4f1c6bbd1b 100644 > --- a/scripts/report/spdx_sbom.py > +++ b/scripts/report/spdx_sbom.py > @@ -121,7 +121,7 @@ class SpdxSbomGenerator(SbomGenerator): > for cpe_id in self.create_cpe_ids(pkg): > cpe = spdx.SPDXExternalReference() > cpe.referenceCategory = "SECURITY" > - cpe.referenceType = "http://spdx.org/rdf/references/cpe23Type" > + cpe.referenceType = "cpe23Type" > cpe.referenceLocator = cpe_id > spdx_pkg.externalRefs.append(cpe) >