From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 14 Aug 2026 17:39:16 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wuu03-0035eP-39 for lore@lore.pengutronix.de; Fri, 14 Aug 2026 17:39:16 +0200 Received: from [127.0.0.1] (helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wutzt-00084z-Uy; Fri, 14 Aug 2026 17:39:05 +0200 Received: from mx1.white.stw.pengutronix.de ([185.203.200.13]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wutzR-0006ni-3c for ptxdist@pengutronix.de; Fri, 14 Aug 2026 17:38:38 +0200 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id E0DD4202202; Fri, 14 Aug 2026 17:38:32 +0200 (CEST) Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wutzM-001TvS-2i; Fri, 14 Aug 2026 17:38:32 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wutzM-00000007YsH-3IiJ; Fri, 14 Aug 2026 17:38:32 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Fri, 14 Aug 2026 17:38:32 +0200 Message-ID: <20260814153832.1802344-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260717131143.1109355-1-s.pueschel@pengutronix.de> References: <20260717131143.1109355-1-s.pueschel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [APPLIED] lvm2: move lvmdump and fsadm into separate options X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: =?UTF-8?q?Sven=20P=C3=BCschel?= Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 810d065ef81df6b54c096074288fd88aa40dba9f. Michael [sent from post-receive hook] On Fri, 14 Aug 2026 17:38:32 +0200, Sven Püschel wrote: > Move lvmdump and the fsadm command into a separate option, as both > commands are bash scripts and therefore need bash as a dependency. > As these commands may not be used, we don't add bash as a dependency to > the much bigger LVM2_LVM_TOOLS option but instead add distinct options > for these commands. > > The new options are guarded by the existing `if LVM2_LVM_TOOLS` to > prevent them from being enabled when the other tools are not enabled. > As this isn't necessary for the lvm2.make file, it doesn't nest the if > conditions to avoid complexity. > > Signed-off-by: Sven Püschel > Message-Id: <20260717131143.1109355-1-s.pueschel@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/lvm2.in b/rules/lvm2.in > index 3213d9c315d1..bb95799e684e 100644 > --- a/rules/lvm2.in > +++ b/rules/lvm2.in > @@ -8,6 +8,7 @@ menuconfig LVM2 > select READLINE > select NCURSES > select SYSTEMD if LVM2_SYSTEMD > + select BASH if (LVM2_FSADM || LVM2_LVMDUMP) && RUNTIME > prompt "lvm2 " > help > LVM2 refers to a new userspace toolset that provide logical volume management > @@ -32,6 +33,13 @@ config LVM2_STARTSCRIPT > depends on INITMETHOD_BBINIT > prompt "install /etc/init.d/lvm2" > > +config LVM2_FSADM > + bool > + prompt "install the fsadm command" > + > +config LVM2_LVMDUMP > + bool > + prompt "install the lvmdump command" > endif > > config LVM2_LIBDEVMAPPER_EVENT > diff --git a/rules/lvm2.make b/rules/lvm2.make > index 57773a1f7149..b5aea987347e 100644 > --- a/rules/lvm2.make > +++ b/rules/lvm2.make > @@ -110,10 +110,15 @@ $(STATEDIR)/lvm2.targetinstall: > > @$(call install_copy, lvm2, 0, 0, 0755, -, /usr/sbin/dmsetup) > > -ifdef PTXCONF_LVM2_LVM_TOOLS > +ifdef PTXCONF_LVM2_FSADM > @$(call install_copy, lvm2, 0, 0, 0755, -, /usr/sbin/fsadm) > +endif > + > +ifdef PTXCONF_LVM2_LVMDUMP > @$(call install_copy, lvm2, 0, 0, 0755, -, /usr/sbin/lvmdump) > +endif > > +ifdef PTXCONF_LVM2_LVM_TOOLS > @$(call install_copy, lvm2, 0, 0, 0755, -, /usr/sbin/lvm) > @$(call install_link, lvm2, lvm, /usr/sbin/lvchange) > @$(call install_link, lvm2, lvm, /usr/sbin/lvconvert)