mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] scripts: make checksum messages hash algorithm agnostic
Date: Mon, 18 May 2026 09:54:20 +0200	[thread overview]
Message-ID: <20260518075420.52919-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20260427142848.989702-2-p.zabel@pengutronix.de>

Thanks, applied as 7ed86f68f18fd295502c2ce53b92cb4e5e640a1f.

Michael

[sent from post-receive hook]

On Mon, 18 May 2026 09:54:20 +0200, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Replace 'md5sum' with the generic term 'checksum' in messages presented
> to the user, in preparation for supporting other checksum algorithms.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Message-Id: <20260427142848.989702-2-p.zabel@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/lib/ptxd_make_check_src.sh b/scripts/lib/ptxd_make_check_src.sh
> index db08cda0e1fe..2a25fdcb96cf 100644
> --- a/scripts/lib/ptxd_make_check_src.sh
> +++ b/scripts/lib/ptxd_make_check_src.sh
> @@ -52,9 +52,9 @@ ptxd_make_check_src() {
>      ptxd_make_check_src_impl "$@" && return
>  
>      if [ -z "${2}" ]; then
> -	ptxd_bailout "md5sum for '${1}' missing."
> +	ptxd_bailout "Checksum for '${1}' missing."
>      else
> -	ptxd_bailout "Wrong md5sum for '${1}'"
> +	ptxd_bailout "Wrong checksum for '${1}'"
>      fi
>  }
>  export -f ptxd_make_check_src
> diff --git a/scripts/lib/ptxd_make_world_check_src.sh b/scripts/lib/ptxd_make_world_check_src.sh
> index 39e49b274a24..8aaeb1137152 100644
> --- a/scripts/lib/ptxd_make_world_check_src.sh
> +++ b/scripts/lib/ptxd_make_world_check_src.sh
> @@ -38,15 +38,15 @@ ptxd_make_world_update_md5() {
>  	fi
>      done
>      if [ -z "${pkg_makefile}" ]; then
> -	ptxd_bailout "Could not update md5sum for '${pkg_label}': makefile not found"
> +	ptxd_bailout "Could not update checksum for '${pkg_label}': makefile not found"
>      fi
>      local count=$(grep "^${pkg_PKG}_MD5[ 	]*:=" "${pkg_makefile}" 2> /dev/null | wc -l)
>      if [ "${count}" -gt 1 ]; then
> -	ptxd_bailout "Could not update md5sum for '${pkg_label}': ${pkg_PKG}_MD5 found ${count} times in '$(ptxd_print_path ${pkg_makefile})'."
> +	ptxd_bailout "Could not update checksum for '${pkg_label}': ${pkg_PKG}_MD5 found ${count} times in '$(ptxd_print_path ${pkg_makefile})'."
>      fi
>      sed -i "s/^\(\<${pkg_PKG}_MD5[ 	]*:=\) *[a-f0-9]*\$/\1 ${md5}/" "${pkg_makefile}"
>      if ! grep -q "${md5}\$" "${pkg_makefile}"; then
> -	ptxd_bailout "Could not update md5sum for '${pkg_label}': ${pkg_PKG}_MD5 not found"
> +	ptxd_bailout "Could not update checksum for '${pkg_label}': ${pkg_PKG}_MD5 not found"
>      fi
>      ptxd_warning "New checksum for ${pkg_PKG}: ${md5} in $(ptxd_print_path "${pkg_makefile}")"
>  }
> diff --git a/scripts/lib/ptxd_make_world_get.sh b/scripts/lib/ptxd_make_world_get.sh
> index c2c4facae092..8c0bb0546150 100644
> --- a/scripts/lib/ptxd_make_world_get.sh
> +++ b/scripts/lib/ptxd_make_world_get.sh
> @@ -27,9 +27,9 @@ ptxd_make_world_get() {
>  	if [ "${PTXCONF_SETUP_CHECK}" = "update" ]; then
>  	    ptxd_make_world_update_md5
>  	elif [ -z "${pkg_md5}" ]; then
> -	    ptxd_bailout "md5sum for '${pkg_label}' (${pkg_src}) missing."
> +	    ptxd_bailout "Checksum for '${pkg_label}' (${pkg_src}) missing."
>  	else
> -	    ptxd_bailout "Wrong md5sum for '${pkg_label}' (${pkg_src})"
> +	    ptxd_bailout "Wrong checksum for '${pkg_label}' (${pkg_src})"
>  	fi
>      fi
>  }



  reply	other threads:[~2026-05-18  7:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 14:28 [ptxdist] [PATCH 0/4] Add SHA256 package checksum support Philipp Zabel
2026-04-27 14:28 ` [ptxdist] [PATCH 1/4] scripts: make checksum messages hash algorithm agnostic Philipp Zabel
2026-05-18  7:54   ` Michael Olbrich [this message]
2026-04-27 14:28 ` [ptxdist] [PATCH 2/4] scripts: make checksum update " Philipp Zabel
2026-05-18  7:54   ` [ptxdist] [APPLIED] " Michael Olbrich
2026-04-27 14:28 ` [ptxdist] [PATCH 3/4] scripts: add package sha256sum support Philipp Zabel
2026-05-18  7:54   ` [ptxdist] [APPLIED] " Michael Olbrich
2026-04-27 14:28 ` [ptxdist] [PATCH 4/4] ptxdist: add --update-checksum option Philipp Zabel
2026-05-18  7:54   ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260518075420.52919-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=p.zabel@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox