mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Thorsten Scherer <t.scherer@eckelmann.de>
To: ptxdist@pengutronix.de
Cc: Thorsten Scherer <t.scherer@eckelmann.de>
Subject: [ptxdist] [PATCH 24/42] openct: Remove after one year in staging
Date: Mon,  4 May 2026 14:53:01 +0200	[thread overview]
Message-ID: <20260504125302.64467-1-t.scherer@eckelmann.de> (raw)
In-Reply-To: <20260504121331.57729-1-t.scherer@eckelmann.de>

Signed-off-by: Thorsten Scherer <t.scherer@eckelmann.de>
---
 ...Handle-too-large-PC-SC-buffer-values.patch | 77 -----------------
 patches/openct-0.6.20/series                  |  4 -
 rules/openct.in                               | 54 ------------
 rules/openct.make                             | 85 -------------------
 4 files changed, 220 deletions(-)
 delete mode 100644 patches/openct-0.6.20/0001-Handle-too-large-PC-SC-buffer-values.patch
 delete mode 100644 patches/openct-0.6.20/series
 delete mode 100644 rules/openct.in
 delete mode 100644 rules/openct.make

diff --git a/patches/openct-0.6.20/0001-Handle-too-large-PC-SC-buffer-values.patch b/patches/openct-0.6.20/0001-Handle-too-large-PC-SC-buffer-values.patch
deleted file mode 100644
index 6e8ebe92ff1d..000000000000
--- a/patches/openct-0.6.20/0001-Handle-too-large-PC-SC-buffer-values.patch
+++ /dev/null
@@ -1,77 +0,0 @@
-From: =?UTF-8?q?Marcin=20Cie=C5=9Blak?= <saper@saper.info>
-Date: Sun, 15 Nov 2015 00:05:56 +0000
-Subject: [PATCH] Handle too large PC/SC buffer values
-
-pcsc-lite starting from 1.8.14 provides 65548 byte
-receive buffers to IFDHTransmitToICC(), which is
-a maximal extended APDU size. Unfortunately this
-is more than CT API can use (16 bits).
-
-If more than 65536 bytes are about to be sent,
-return IFD_PROTOCOL_NOT_SUPPORTED.
-
-Receive at most 65536 bytes. pcsc-lite will always
-specify 65548 buffer, even if the client application
-requests less; therefore we cannot return an error
-in this case.
-
-Discussion:
-https://lists.alioth.debian.org/pipermail/pcsclite-muscle/Week-of-Mon-20151109/000493.html
-
-Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
----
- src/pcsc/pcsc.c | 13 +++++++++++--
- 1 file changed, 11 insertions(+), 2 deletions(-)
-
-diff --git a/src/pcsc/pcsc.c b/src/pcsc/pcsc.c
-index 0ed9a619e53b..d769eb5625ec 100644
---- a/src/pcsc/pcsc.c
-+++ b/src/pcsc/pcsc.c
-@@ -25,6 +25,7 @@
- #ifdef DEBUG_IFDH
- #include <syslog.h>
- #endif
-+#include <limits.h>
- #ifdef __APPLE__
- #include <PCSC/wintypes.h>
- #include <PCSC/pcsclite.h>
-@@ -390,6 +391,10 @@ IFDHTransmitToICC(DWORD Lun, SCARD_IO_HEADER SendPci,
- 	ctn = ((unsigned short)(Lun >> 16)) % IFDH_MAX_READERS;
- 	slot = ((unsigned short)(Lun & 0x0000FFFF)) % IFDH_MAX_SLOTS;
- 
-+	if (TxLength > USHRT_MAX) {
-+		(*RxLength) = 0;
-+		return IFD_PROTOCOL_NOT_SUPPORTED;
-+	}
- #ifdef HAVE_PTHREAD
- 	pthread_mutex_lock(&ifdh_context_mutex[ctn]);
- #endif
-@@ -399,7 +404,7 @@ IFDHTransmitToICC(DWORD Lun, SCARD_IO_HEADER SendPci,
- #endif
- 		dad = (UCHAR) ((slot == 0) ? 0x00 : slot + 1);
- 		sad = 0x02;
--		lr = (unsigned short)(*RxLength);
-+		lr = (*RxLength > USHRT_MAX) ? USHRT_MAX : (unsigned short)(*RxLength);
- 		lc = (unsigned short)TxLength;
- 
- 		ret = CT_data(ctn, &dad, &sad, lc, TxBuffer, &lr, RxBuffer);
-@@ -438,6 +443,10 @@ IFDHControl(DWORD Lun, PUCHAR TxBuffer,
- 	ctn = ((unsigned short)(Lun >> 16)) % IFDH_MAX_READERS;
- 	slot = ((unsigned short)(Lun & 0x0000FFFF)) % IFDH_MAX_SLOTS;
- 
-+	if (TxLength > USHRT_MAX) {
-+		(*RxLength) = 0;
-+		return IFD_PROTOCOL_NOT_SUPPORTED;
-+	}
- #ifdef HAVE_PTHREAD
- 	pthread_mutex_lock(&ifdh_context_mutex[ctn]);
- #endif
-@@ -447,7 +456,7 @@ IFDHControl(DWORD Lun, PUCHAR TxBuffer,
- #endif
- 		dad = 0x01;
- 		sad = 0x02;
--		lr = (unsigned short)(*RxLength);
-+		lr = (*RxLength > USHRT_MAX) ? USHRT_MAX : (unsigned short)(*RxLength);
- 		lc = (unsigned short)TxLength;
- 
- 		ret = CT_data(ctn, &dad, &sad, lc, TxBuffer, &lr, RxBuffer);
diff --git a/patches/openct-0.6.20/series b/patches/openct-0.6.20/series
deleted file mode 100644
index e1b5c45cfc00..000000000000
--- a/patches/openct-0.6.20/series
+++ /dev/null
@@ -1,4 +0,0 @@
-# generated by git-ptx-patches
-#tag:base --start-number 1
-0001-Handle-too-large-PC-SC-buffer-values.patch
-# 412ac4f5b443002e278d05ad793381f1  - git-ptx-patches magic
diff --git a/rules/openct.in b/rules/openct.in
deleted file mode 100644
index 88e62455b44c..000000000000
--- a/rules/openct.in
+++ /dev/null
@@ -1,54 +0,0 @@
-## SECTION=staging
-## old section:
-### SECTION=communication
-
-menuconfig OPENCT
-	tristate "openct                        "
-	select LIBLTDL
-	select LIBC_C
-	select LIBC_DL
-	select LIBC_PTHREAD	if OPENCT_PCSC
-	select PCSC_LITE	if OPENCT_PCSC
-	select LIBUSB		if OPENCT_USB
-	select LIBUSB_COMPAT	if OPENCT_USB
-	help
-	  OpenCT implements drivers for many card terminals, smart card
-	  readers, and usb crypto tokens. OpenCT can be used as CT-API or
-	  PC/SC Ifdhandler driver, but also directly.
-
-	  STAGING: remove in PTXdist 2026.03.0
-	  Unmaintained in PTXdist, upstream dead and fails to build with
-	  current toolchains.
-
-if OPENCT
-
-config OPENCT_USB
-	bool "USB Support"
-	help
-	  Add USB support.
-
-config OPENCT_API
-	bool "Use OpenCT API"
-	default y
-	help
-	  Add support for OpenCT communication.
-
-config OPENCT_PCSC
-	bool "Use PCSC"
-	default y
-	select OPENCT_API
-	help
-	  Use PCSC as the control daemon.
-
-config OPENCT_TOOLS
-	bool "Install utilities"
-	help
-	  Install also utilities like 'openct-tool', 'ifdhandler',
-	  'ifdproxy' and 'openct-control'.
-
-config OPENCT_SYSTEMD_UNIT
-	bool "install systemd unit"
-	depends on SYSTEMD
-	default y
-
-endif
diff --git a/rules/openct.make b/rules/openct.make
deleted file mode 100644
index d4f82876b2b6..000000000000
--- a/rules/openct.make
+++ /dev/null
@@ -1,85 +0,0 @@
-# -*-makefile-*-
-#
-# Copyright (C) 2010 by Juergen Beisert <jbe@pengutronix.de>
-#               2015 by Marc Kleine-Budde <mkl@pengutronix.de>
-#
-# For further information about the PTXdist project and license conditions
-# see the README file.
-#
-
-#
-# We provide this package
-#
-PACKAGES-$(PTXCONF_OPENCT) += openct
-
-#
-# Paths and names
-#
-OPENCT_VERSION		:= 0.6.20
-OPENCT_MD5		:= a1da3358ab798f1cb9232f1dbababc21
-OPENCT			:= openct-$(OPENCT_VERSION)
-OPENCT_SUFFIX		:= tar.gz
-OPENCT_URL		:= $(call ptx/mirror, SF, opensc/openct/$(OPENCT).$(OPENCT_SUFFIX))
-OPENCT_SOURCE		:= $(SRCDIR)/$(OPENCT).$(OPENCT_SUFFIX)
-OPENCT_DIR		:= $(BUILDDIR)/$(OPENCT)
-OPENCT_BUILD_OOT	:= YES
-OPENCT_LICENSE		:= LGPLv2
-
-# ----------------------------------------------------------------------------
-# Prepare
-# ----------------------------------------------------------------------------
-
-OPENCT_CONF_TOOL := autoconf
-OPENCT_CONF_OPT := \
-	$(CROSS_AUTOCONF_USR) \
-	--localstatedir=/ \
-	--$(call ptx/endis, PTXCONF_OPENCT_PCSC)-pcsc \
-	--$(call ptx/endis, PTXCONF_OPENCT_USB)-usb \
-	--disable-debug \
-	--disable-sunray \
-	--disable-sunrayclient \
-	--enable-shared \
-	--disable-static \
-	--with-bundle=/usr/lib/pcsc
-
-
-# ----------------------------------------------------------------------------
-# Target-Install
-# ----------------------------------------------------------------------------
-
-$(STATEDIR)/openct.targetinstall:
-	@$(call targetinfo)
-
-	@$(call install_init,  openct)
-	@$(call install_fixup, openct,PRIORITY,optional)
-	@$(call install_fixup, openct,SECTION,base)
-	@$(call install_fixup, openct,AUTHOR,"Juergen Beisert <jbe@pengutronix.de>")
-	@$(call install_fixup, openct,DESCRIPTION, "SmartCard environment")
-
-	@$(call install_lib, openct, 0, 0, 0644, libopenct)
-	@$(call install_copy, openct, 0, 0, 0755, -, /usr/sbin/ifdhandler)
-	@$(call install_copy, openct, 0, 0, 0755, -, /usr/sbin/openct-control)
-
-ifdef PTXCONF_OPENCT_PCSC
-	@$(call install_lib, openct, 0, 0, 0644, openct-ifd)
-endif
-ifdef PTXCONF_OPENCT_API
-	@$(call install_lib, openct, 0, 0, 0644, libopenctapi)
-endif
-ifdef PTXCONF_OPENCT_TOOLS
-	@$(call install_copy, openct, 0, 0, 0755, -, /usr/bin/openct-tool)
-	@$(call install_copy, openct, 0, 0, 0755, -, /usr/sbin/ifdproxy)
-endif
-	@$(call install_alternative, openct, 0, 0, 0644, /etc/openct.conf)
-
-ifdef PTXCONF_OPENCT_SYSTEMD_UNIT
-	@$(call install_alternative, openct, 0, 0, 0644, /usr/lib/systemd/system/openct.service)
-	@$(call install_link, openct, ../openct.service, \
-		/usr/lib/systemd/system/multi-user.target.wants/openct.service)
-	@$(call install_alternative, openct, 0, 0, 0644, /usr/lib/tmpfiles.d/openct.conf)
-endif
-
-	@$(call install_finish, openct)
-	@$(call touch)
-
-# vim: syntax=make
-- 
2.53.0




  parent reply	other threads:[~2026-05-04 12:53 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 12:12 [ptxdist] [PATCH 00/42] treewide: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 01/42] archivemount: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 02/42] argtable2: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 03/42] bing: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 04/42] calibrator: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 05/42] daemonize: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 06/42] dhex: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 07/42] dialog: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 08/42] frodo: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 09/42] gnuplot: " Thorsten Scherer
2026-05-04 12:12 ` [ptxdist] [PATCH 10/42] latencytop: " Thorsten Scherer
2026-05-04 12:13 ` [ptxdist] [PATCH 11/42] latrace: " Thorsten Scherer
2026-05-04 12:13 ` [ptxdist] [PATCH 12/42] libcli: " Thorsten Scherer
2026-05-04 12:13 ` [ptxdist] [PATCH 13/42] libgee: " Thorsten Scherer
2026-05-04 12:13 ` [ptxdist] [PATCH 14/42] libiodbc: " Thorsten Scherer
2026-05-04 12:13 ` [ptxdist] [PATCH 15/42] liblockfile: " Thorsten Scherer
2026-05-04 12:13 ` [ptxdist] [PATCH 16/42] libmikmod: " Thorsten Scherer
2026-05-04 12:13 ` [ptxdist] [PATCH 17/42] liburcu: " Thorsten Scherer
2026-05-04 12:13 ` [ptxdist] [PATCH 18/42] links: " Thorsten Scherer
2026-05-04 12:13 ` [ptxdist] [PATCH 19/42] lsuio: " Thorsten Scherer
2026-05-04 12:52 ` [ptxdist] [PATCH 20/42] ltt-control: " Thorsten Scherer
2026-05-04 12:52 ` [ptxdist] [PATCH 21/42] lua-filesystem: " Thorsten Scherer
2026-05-04 12:52 ` [ptxdist] [PATCH 22/42] media-session: " Thorsten Scherer
2026-05-04 12:52 ` [ptxdist] [PATCH 23/42] mtd-oopslog: " Thorsten Scherer
2026-05-04 12:53 ` Thorsten Scherer [this message]
2026-05-04 12:53 ` [ptxdist] [PATCH 25/42] pcmciautils: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 26/42] pslib: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 27/42] sched_switch: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 28/42] schedtool: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 29/42] sdl-gfx: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 30/42] sdl-ttf: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 31/42] sdl: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 32/42] sdl_image: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 33/42] sdl_mixer: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 34/42] setserial: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 35/42] smtpclient: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 36/42] ssmtp: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 37/42] supertux: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 38/42] utelnetd: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 39/42] wireshark: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 40/42] xerces: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 41/42] xterm: " Thorsten Scherer
2026-05-04 12:53 ` [ptxdist] [PATCH 42/42] zsync: " Thorsten Scherer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504125302.64467-1-t.scherer@eckelmann.de \
    --to=t.scherer@eckelmann.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox