From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 15 Apr 2026 15:52:48 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wD0fg-00CR4P-0G for lore@lore.pengutronix.de; Wed, 15 Apr 2026 15:52:48 +0200 Received: from [127.0.0.1] (helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wD0ff-0001EH-Vd; Wed, 15 Apr 2026 15:52:47 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1wD0fD-0008LD-9U; Wed, 15 Apr 2026 15:52:19 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wD0fD-005WOb-0L; Wed, 15 Apr 2026 15:52:19 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wD0fD-00000003rwX-0F3k; Wed, 15 Apr 2026 15:52:19 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Wed, 15 Apr 2026 15:52:19 +0200 Message-ID: <20260415135219.922334-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260413143012.417716-1-ada@thorsis.com> References: <20260413143012.417716-1-ada@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] util-linux: Fix missing ncurses dependencies X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 77f79b7a834736fde1474959a37babc6097a5e65. Michael [sent from post-receive hook] On Wed, 15 Apr 2026 15:52:18 +0200, Alexander Dahl wrote: > util-linux has an internal static library called lib_tcolors which > depends on ncurses. With the modular build approach introduced with > v2.41 some builds fail if tools are enabled which require that (e.g. > dmesg, lsblk, …), but no other tool is enabled which selects the ncurses > dependency. > > Signed-off-by: Alexander Dahl > Message-Id: <20260413143012.417716-1-ada@thorsis.com> > Signed-off-by: Michael Olbrich > > diff --git a/rules/util-linux.in b/rules/util-linux.in > index fd07a25c5f4a..ff68e5377141 100644 > --- a/rules/util-linux.in > +++ b/rules/util-linux.in > @@ -33,6 +33,7 @@ config UTIL_LINUX_LIBFDISK > config UTIL_LINUX_FDISKS > select UTIL_LINUX_LIBFDISK > select UTIL_LINUX_LIBSMARTCOLS > + select UTIL_LINUX_LIBTCOLORS > select UTIL_LINUX_USES_NCURSES > bool > > @@ -44,6 +45,10 @@ config UTIL_LINUX_USES_NCURSESW > depends on UTIL_LINUX_USES_NCURSES > default NCURSES_WIDE_CHAR > > +config UTIL_LINUX_LIBTCOLORS > + bool > + select UTIL_LINUX_USES_NCURSES > + > config UTIL_LINUX_USES_PAM > bool > > @@ -241,6 +246,7 @@ config UTIL_LINUX_LSBLK > select UTIL_LINUX_LIBBLKID > select UTIL_LINUX_LIBMOUNT > select UTIL_LINUX_LIBSMARTCOLS > + select UTIL_LINUX_LIBTCOLORS > prompt "lsblk" > help > The lsblk command lists information about all available or the > @@ -339,6 +345,7 @@ config UTIL_LINUX_CHMEM > > config UTIL_LINUX_DMESG > bool > + select UTIL_LINUX_LIBTCOLORS > depends on !BUSYBOX_DMESG || ALLYES > prompt "dmesg" > help > @@ -423,6 +430,7 @@ comment "BusyBox' ipcs is selected!" > > config UTIL_LINUX_IRQTOP > bool > + select UTIL_LINUX_LIBTCOLORS > select UTIL_LINUX_USES_NCURSES > prompt "irqtop" > help > @@ -653,6 +661,7 @@ config UTIL_LINUX_COLUMN > > config UTIL_LINUX_HEXDUMP > bool > + select UTIL_LINUX_LIBTCOLORS > depends on !BUSYBOX_HEXDUMP > prompt "hexdump" > help