Re: [ptxdist] [PATCH] kernel: Call chmod modules.builtin.modinfo for v6.x only

[Alexander Dahl via ptxdist <ptxdist@pengutronix.de>]

Hello Bruno,

Am Fri, Mar 27, 2026 at 01:43:29PM +0100 schrieb Bruno Thomsen:
> Hi Alexander,
> 
> Den fre. 27. mar. 2026 kl. 10.56 skrev Alexander Dahl via ptxdist
> <ptxdist@pengutronix.de>:
> >
> > kernel.install stage fails for kernel versions before v5.2 (which
> > introduced modules.builtin.modinfo in the first place) like this:
> >
> >       DEPMOD  4.9.327-rt197-tt
> >     depmod: WARNING: could not open modules.builtin.modinfo at [redacted]/platform-ncl/packages/linux-4.9.327/lib/modules/4.9.327-rt197-tt: No such file or directory
> >     chmod: cannot access '[redacted]/platform-ncl/packages/linux-4.9.327/lib/modules/*/modules.builtin.modinfo': No such file or directory
> >     make: *** [/usr/local/lib/ptxdist-2026.01.0/rules/kernel.make:287: [redacted]/platform-ncl/state/kernel.install] Error 1
> >     ptxdist install kernel  3,75s user 1,63s system 101% cpu 5,308 total
> >
> > The chmod fix is only necessary for kernel v6.18 which introduced the
> > faulty executable permissions.  It was fixed for v6.19 with kernel commit
> > 6d60354ea2f9 ("kbuild: Fix permissions of modules.builtin.modinfo").
> >
> > Suggested-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > Tested-by: Ruggero Rossi <rugrossi@googlemail.com>
> > Fixes: 844408110d04 ("kernel: fix modules.builtin.modinfo being executable")
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > ---
> >  rules/kernel.make | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/rules/kernel.make b/rules/kernel.make
> > index c1f10f62e..d366be714 100644
> > --- a/rules/kernel.make
> > +++ b/rules/kernel.make
> > @@ -285,7 +285,9 @@ $(STATEDIR)/kernel.install:
> >         @$(call targetinfo)
> >  ifdef PTXCONF_KERNEL_MODULES_INSTALL
> >         @$(call world/install, KERNEL)
> > +ifeq ($(KERNEL_VERSION_MAJOR),6)
> >         @chmod -x $(KERNEL_PKGDIR)/lib/modules/*/modules.builtin.modinfo
> > +endif
> 
> Good fix, but it will break when using kernel version 7.0 which is
> expected to be
> released next month. Maybe do something like this (untested):
> 
> ifeq ($(shell test $(KERNEL_VERSION_MAJOR) -ge 6; echo $$?),0)

I actually noticed the same thing: fix is for kernel v6 only,
and asked myself what's with v7 or later?

Turns out that's sufficient, because as written in the commit message:
only kernel v6.18 is affected.  There is no chmod necessary for
releases before _and_ after v6.18.  In other words: the chmod call
should be avoided for kernels up to v5.1 (intention of the patch), and
is neither necessary for v5.2 or later v5 kernels, nor is it necessary
for v7 and later (given there won't be regressions), because the flaw
was introduced with v6.18 and fixed with v6.19.  That's why I added a
note in the commit message.  I does not break things when calling on
all v6 kernels though.

I think Michael suggested to test on major version only, because it is
easier to implement and less likely to break?  Should we add a comment
in the makefile for clarifying or is git history enough?

Nevertheless, thanks for pointing it out.

Greets
Alex

> 
> /Bruno
> 
> >  endif
> >         @$(call world/dtb, KERNEL)
> >         @$(call world/dtbo, KERNEL)
> >
> > base-commit: eedd3da887e42dcc0e6ffb95a348107e2a5bcf4f
> > --
> > 2.47.3
> >
> >
>