From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 16 Jan 2026 09:31:24 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vgfEq-001tjT-1a for lore@lore.pengutronix.de; Fri, 16 Jan 2026 09:31:24 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vgfEp-0006mZ-Sk; Fri, 16 Jan 2026 09:31:23 +0100 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1vgfEh-0006lh-4O for ptxdist@pengutronix.de; Fri, 16 Jan 2026 09:31:15 +0100 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-432d2c7a8b9so1575843f8f.2 for ; Fri, 16 Jan 2026 00:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1768552274; x=1769157074; darn=pengutronix.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:date:from:from:to:cc:subject:date :message-id:reply-to; bh=RkNeiftkq7hIveOoScxq0W+jTAM+nJwb848uJsPYGyk=; b=bTuNIj9VjDF67ISeAb77pOV3KIPWg4kofaI86MTSZGYUvuexmA3vlNHfNyPWcAMAgL sKdrcmfltk/NIgoP2M8ObhCFKlci1dbkPzOVWo7IDkwhYCHpL8MEip1wiCnrqMKEgFDx 7bTCC337oJIYheUBWCJe2D9zpvyu4G5DYnsduwzs0sIOMDFk8T3PksrHVNYmXf3+y5in 3m/fTu4kLoOIOCA7rPgJjgLFtjaqiu5fQhSHFJRkKCJwG8LQBMV80PjvULKXVdp8WmZM vhpgAPMjLN2mRiByjFDNReEse3YaiGEUm23m2jHu2Z6CR3ChxSc2lOPWwK7LUb16UHOE tFgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768552274; x=1769157074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RkNeiftkq7hIveOoScxq0W+jTAM+nJwb848uJsPYGyk=; b=eQz3cJETWcqQTPn1cBsa263OTlZiqU0m3wsHxs3pN5ngHw7rADc9RqjrfHBGjr8XDQ pZ+qWxK4R3zjnA8UB2Jtj0pobKWyyo+fFWrjGKfehJxR/gYwds02r3LsbKLNgX9mdXJj ngPR9OeNc+2RZoGQYnnMDKsbtT3V+8AD8BGPG1kbdf1a5XwFNOeS3vh/rsk0uiKjejmq gTxq/p80IbUwRUybLUPMO7ocrCx+Q0OCV/S0j72RTXC5y08X5ofDYJezA2NaD51qO79v 8Ev9hKajqqyb2a2khmlU5bVxoXhQLsmOXmpIzKZHh8ViuhTztnWyZT1JKKaQBNYZ0t/8 IWbw== X-Gm-Message-State: AOJu0Ywkjvt3gf+DE35vBP3Pzj+f1Dn0J725WUnDGjYSIlXvNR+wMKbJ UvDTjFzteUdxNtSMUrJJ60OLhpm1TKRiUEKsTZ3FyXerQndSoH52e8lR X-Gm-Gg: AY/fxX7QAZisje9a0gNLT0yWRlYW8ZZPmrF9UWDuaatD+KIkkb0EfpmoZ3tlUR/5WFp IGSuhHxnPWkRxUnXaj1NUIv2yo4kQefxCTBl5K6KTDxNtyXiER5QcmXX0a1dNeThbT33lnTrJjK pI5bAbYv6Usju2Vr4aYTXanCw/48ES938fFGMLYKaZdeuOh3UwwpLjApsk4k3Jk7J1lfQJry/m3 WmfSPZnbcpxPaaQ7X/ydmWDPRDthH+2uEAA0ytBzdIuysxpqVgmPQ0Uc9oZ8y4ql26ZWt5TZMJV /3Fg+DDtmqvLvgACHOF90+c5ZnvDzYLTmwUqgUi0WGhFFuXr+Ya9Xr6BcEVTSkBiuAZewII+F3m ASWGQFDoANmve+EnDbRxNYMx0Ndqsskn2qad3Ras7+dOe7on1RHv8BhwkKRvoMfgXnRnTeo0XN7 /IricMj/5FgQAcvcGIOGNoHw0h1YFBTNlCpHMUObmaJ97UjE9Fuz71ELxPr7Ilae0oUI3lCj4kb srV X-Received: by 2002:a5d:5889:0:b0:430:ff81:2961 with SMTP id ffacd0b85a97d-4356a082ebfmr2295102f8f.51.1768552273999; Fri, 16 Jan 2026 00:31:13 -0800 (PST) Received: from laptop-RR (p200300c00f4234000d55ce212f53d7ee.dip0.t-ipconnect.de. [2003:c0:f42:3400:d55:ce21:2f53:d7ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569921f6esm3890430f8f.4.2026.01.16.00.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 00:31:13 -0800 (PST) X-Google-Original-From: ruggero rossi Date: Fri, 16 Jan 2026 09:31:12 +0100 To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Message-ID: <20260116093112.6b24bf56@laptop-RR> In-Reply-To: References: <20251210-modinfo-executable-v1-1-23c6f3fc999e@pengutronix.de> <20251212145210.3029772-1-m.olbrich@pengutronix.de> <20260112163053.28f8406f@laptop-RR> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=4.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [APPLIED] kernel: fix modules.builtin.modinfo being executable X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: ruggero rossi via ptxdist Reply-To: ptxdist@pengutronix.de Cc: ruggero rossi , Michael Olbrich , Fabian Pfitzner , ruggero rossi via ptxdist Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Tue, 13 Jan 2026 15:57:29 +0100 Uwe Kleine-K=C3=B6nig wrote: > Hello, >=20 > if "$fileName" >=20 > looks wrong to me. Either this gives you a "Permission denied" error, or > the file already has the x bit set :-) you are right. For some reason the [ -f ... ] disappeared. However the observation of Michael Olbrich > I don't like patterns like this, because it silently fails if there is a > typo. And we know, that this is only needed for 6.18 or later. And all > 6.x versions install this file. So maybe wrap it with: >=20 > ifeq ($(KERNEL_VERSION_MAJOR),6) > ... > endif >=20 made this workaround unnecessary. The patch now should be: -- /usr/local/lib/ptxdist-2026.01.0/rules/kernel.make 2025-12-12 09:44:06.000000000 +0100=20 +++ kernel.make 2026-01-13 10:36:36.840222985 +0100=20 @@ -285,8 +285,10 @@ @$(call targetinfo) ifdef PTXCONF_KERNEL_MODULES_INSTALL @$(call world/install, KERNEL) +ifeq ($(KERNEL_VERSION_MAJOR),6) @chmod -x $(KERNEL_PKGDIR)/lib/modules/*/modules.builtin.modinfo endif +endif @$(call world/dtb, KERNEL) @$(call world/dtbo, KERNEL) @$(call touch) reducing the changes against the original to a very minimum. Best regards Ruggero