From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 13 Jan 2026 10:48:34 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfb0s-000q1X-1Y for lore@lore.pengutronix.de; Tue, 13 Jan 2026 10:48:34 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vfb0r-0000o8-Sz; Tue, 13 Jan 2026 10:48:33 +0100 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1vfb0b-0000nd-A8 for ptxdist@pengutronix.de; Tue, 13 Jan 2026 10:48:19 +0100 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-64b7a38f07eso11230428a12.0 for ; Tue, 13 Jan 2026 01:48:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1768297696; x=1768902496; darn=pengutronix.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:date:from:from:to:cc:subject:date :message-id:reply-to; bh=t+0A8EuLNgYb/V3IYFp1z8V4oVwqCOS5K8P9ZmORP7A=; b=SIaLwjs3tQWxIjrBH3HCwFYzjGbyXpSXSJpxVzw7YA0cKispVhkzB/TdHSRh2h1rHR BkshZiuVUrl4KVosC1BjQUkveZ2i2/Jfn+5JUDaufH3naH/gwF/gpMA4rLluvNhy1pfg PCbDg9cYq4T53srQjs3+68Fu8PnVD2V2mqD/pxso2xgL9IDhSx1txYzvntgBwNgVEknd ZJjbIzmksk+wWmk/ya5UF5QbUdqc++zgytXkfR5TIH1cUwWYGQhwU4/ALKNKbH25ZvJB 142n3SBAkpQ9KIeuht8qdO9tYZs7X8UUfRMBOWC8UAm7bi2QD+xjxNu34dq/kCnkT1BS ZAEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768297696; x=1768902496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t+0A8EuLNgYb/V3IYFp1z8V4oVwqCOS5K8P9ZmORP7A=; b=jPHnhER/W3JsgtBilnvo//N+Hb+TV5itZb1FoAbWLICZaSQW3ssLZwKfYxVhX3wJTj I1i2hy1KSeqlODX36XYBq6wUnEDoFLoCyif4cJOFijKAyxPUK8B2WARMzYvuTx1QLFbX h20yVIhR3wymhMxUyAgzDjA/r0WZF/gqXCJ62RFjwZER3I1NUj/Aux///Ov0OAm7d9s+ fTVDK5J+ZljgVahTUvys5/tyFDDr8n6vQSogwa8acI1/7g9qTs3GZXHMqI0wojvsKdj0 JQch/yyzRTPYCiVNuklSF0jZxmrmcy3rJ9XQ3UmxWCsxgbUC0uarwq4kHGVzDiovjW0M 2yYA== X-Gm-Message-State: AOJu0Ywyv21dp+8/MdMRxG86YIlIL5sQz97qE3RiPr/4yxhdZ4xbPz// fpgczCbSvFJPkiSy+ovG2/Ih/AJb2hIZePLHWM5yD5p1qfO+JQ0V8/vb X-Gm-Gg: AY/fxX4qW/KX5PD8Cu6a0xhRA+xlAaFYae2/pPHvLdxfr6S0S7huBhKj+p2wANElaGg 7Kj8e/PLcIrY92lSZYhcRLDRgq217LKPkXxKHx1Si52ZzZXhuDNVg3ltqikALKI0ze54mRnYH+q zMzsy8hlM41MrCmDwZv2SdSnhpfYsGKhBv47owGtLneNSqPV3XSE+vOhFKX/5Usc3jrsGmG+uRN rFjyB7Rx/jbuB1yXgLPrM8QaCvcT+6VIWFlV3RX5ox6KnPeli2R/NoTSv84UtoRbN5djB3nZ3Bk vamlb9tpXgD6TCJTbj9fBQnMNvsJUV2PzFXj5LmtneKkhhKP/TXBtfvf7agxrstUoBVhm7Uil/W 28GIHr2zI92xkfg46/T/uFlvXMy3NsOtdG+TDxupCF1Cax4+lEQMyIGjNyKO+eyuQEt9TjC0/kT pDSIBF+iKfPozLTJtO66sJGS9dtVu97euR3FDxazJsCYbYhkmazmltQtW8Y6WBOfeHUu4= X-Google-Smtp-Source: AGHT+IFwS378G8AJ9YO2zvsQ/KRjOL43LVtxuIaSz+Wmjy+LH4Av03oVkZjH28Feg+GlCTBfspzIhA== X-Received: by 2002:a05:6402:2811:b0:649:927c:337c with SMTP id 4fb4d7f45d1cf-65097dfd568mr18420442a12.14.1768297696394; Tue, 13 Jan 2026 01:48:16 -0800 (PST) Received: from laptop-RR (p200300c00f1715001d531ac385371b16.dip0.t-ipconnect.de. [2003:c0:f17:1500:1d53:1ac3:8537:1b16]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507b8c3f89sm19660990a12.5.2026.01.13.01.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 01:48:16 -0800 (PST) X-Google-Original-From: ruggero rossi Date: Tue, 13 Jan 2026 10:48:15 +0100 To: Michael Olbrich Message-ID: <20260113104815.6cfcc112@laptop-RR> In-Reply-To: References: <20251210-modinfo-executable-v1-1-23c6f3fc999e@pengutronix.de> <20251212145210.3029772-1-m.olbrich@pengutronix.de> <20260112163053.28f8406f@laptop-RR> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=4.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [APPLIED] kernel: fix modules.builtin.modinfo being executable X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: ruggero rossi via ptxdist Reply-To: ptxdist@pengutronix.de Cc: ruggero rossi , Fabian Pfitzner , ruggero rossi via ptxdist Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi, >=20 > I don't like patterns like this, because it silently fails if there is a > typo. And we know, that this is only needed for 6.18 or later. And all > 6.x versions install this file. So maybe wrap it with: >=20 > ifeq ($(KERNEL_VERSION_MAJOR),6) > ... > endif >=20 > Michael >=20 In this case the patch is much simpler: -- /usr/local/lib/ptxdist-2026.01.0/rules/kernel.make 2025-12-12 09:44:06.000000000 +0100=20 +++ kernel.make 2026-01-13 10:36:36.840222985 +0100=20 @@ -285,8 +285,10 @@ @$(call targetinfo) ifdef PTXCONF_KERNEL_MODULES_INSTALL @$(call world/install, KERNEL) +ifeq ($(KERNEL_VERSION_MAJOR),6) @chmod -x $(KERNEL_PKGDIR)/lib/modules/*/modules.builtin.modinfo endif +endif @$(call world/dtb, KERNEL) @$(call world/dtbo, KERNEL) @$(call touch) =C3=8Dn my case I tested it successfully, and I think it would be nice to h= ave it included in the future. Best regards, Ruggero