mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: ruggero rossi via ptxdist <ptxdist@pengutronix.de>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: ruggero rossi <rugrossi@googlemail.com>,
	Fabian Pfitzner <f.pfitzner@pengutronix.de>,
	ruggero rossi via ptxdist <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] kernel: fix modules.builtin.modinfo being executable
Date: Tue, 13 Jan 2026 10:48:15 +0100	[thread overview]
Message-ID: <20260113104815.6cfcc112@laptop-RR> (raw)
In-Reply-To: <aWYK65rDnF65M82Y@pengutronix.de>

Hi,
> 
> I don't like patterns like this, because it silently fails if there is a
> typo. And we know, that this is only needed for 6.18 or later. And all
> 6.x versions install this file. So maybe wrap it with:
> 
> ifeq ($(KERNEL_VERSION_MAJOR),6)
> 	...
> endif
> 
> Michael
> 
In this case the patch is much simpler:

-- /usr/local/lib/ptxdist-2026.01.0/rules/kernel.make	2025-12-12
09:44:06.000000000 +0100 
+++ kernel.make	2026-01-13 10:36:36.840222985 +0100 
@@ -285,8 +285,10 @@
 	@$(call targetinfo)
 ifdef PTXCONF_KERNEL_MODULES_INSTALL
 	@$(call world/install, KERNEL)
+ifeq ($(KERNEL_VERSION_MAJOR),6)
 	@chmod -x $(KERNEL_PKGDIR)/lib/modules/*/modules.builtin.modinfo
 endif
+endif
 	@$(call world/dtb, KERNEL)
 	@$(call world/dtbo, KERNEL)
 	@$(call touch)

Ín my case I tested it successfully, and I think it would be nice to have
it included in the future.

Best regards,

Ruggero



  reply	other threads:[~2026-01-13  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 16:22 [ptxdist] [PATCH] " Fabian Pfitzner
2025-12-12 14:52 ` [ptxdist] [APPLIED] " Michael Olbrich
2026-01-12 15:30   ` ruggero rossi via ptxdist
2026-01-13  9:05     ` Michael Olbrich
2026-01-13  9:48       ` ruggero rossi via ptxdist [this message]
2026-01-13 14:57     ` Uwe Kleine-König
2026-01-16  8:31       ` ruggero rossi via ptxdist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113104815.6cfcc112@laptop-RR \
    --to=ptxdist@pengutronix.de \
    --cc=f.pfitzner@pengutronix.de \
    --cc=m.olbrich@pengutronix.de \
    --cc=rugrossi@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox