From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 12 Dec 2025 15:54:21 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vU4XF-00AheH-1K for lore@lore.pengutronix.de; Fri, 12 Dec 2025 15:54:21 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vU4XF-0006M1-5r; Fri, 12 Dec 2025 15:54:21 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vU4V8-0003XC-Rv; Fri, 12 Dec 2025 15:52:10 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vU4V8-005JKY-1F; Fri, 12 Dec 2025 15:52:10 +0100 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1vU4V8-0000000CiCE-1Onp; Fri, 12 Dec 2025 15:52:10 +0100 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Fri, 12 Dec 2025 15:52:10 +0100 Message-ID: <20251212145210.3029772-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251210-modinfo-executable-v1-1-23c6f3fc999e@pengutronix.de> References: <20251210-modinfo-executable-v1-1-23c6f3fc999e@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] kernel: fix modules.builtin.modinfo being executable X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Fabian Pfitzner Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 844408110d046a967ec1d588dd038d95a6065514. Michael [sent from post-receive hook] On Fri, 12 Dec 2025 15:52:10 +0100, Fabian Pfitzner wrote: > Since kernel commit a26a6c93edfe ("kbuild: Strip trailing padding bytes from > modules.builtin.modinfo") [1], the resulting modules.builtin.modinfo file gets > copied by objcopy resulting in an executable file. > > It seems, that objcopy detects this file as executable even though > the file is not executable at all. > > Fix this problem by removing the execution bit afterwards. > > I also send a patch upstream to the kernel [2]. > > [1] https://lore.kernel.org/all/20251105-kbuild-fix-builtin-modinfo-for-kmod-v1-1-b419d8ad4606@kernel.org > [2] https://lore.kernel.org/all/20251209-modinfo-executable-v1-1-ed0c553a4390@pengutronix.de/#t > > Signed-off-by: Fabian Pfitzner > Message-Id: <20251210-modinfo-executable-v1-1-23c6f3fc999e@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/kernel.make b/rules/kernel.make > index 9cdc95a91b8b..e974304043f6 100644 > --- a/rules/kernel.make > +++ b/rules/kernel.make > @@ -274,6 +274,7 @@ $(STATEDIR)/kernel.install: > @$(call targetinfo) > ifdef PTXCONF_KERNEL_MODULES_INSTALL > @$(call world/install, KERNEL) > + @chmod -x $(KERNEL_PKGDIR)/lib/modules/*/modules.builtin.modinfo > endif > @$(call world/dtb, KERNEL) > @$(call world/dtbo, KERNEL)