mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [APPLIED] libwebsockets: Make roles configurable
Date: Thu, 23 Oct 2025 15:13:46 +0200	[thread overview]
Message-ID: <20251023131346.1212537-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20251021131118.919834-8-ada@thorsis.com>

Thanks, applied as e328d8cfcb431a78051413297cd5d91a4907e8de.

Michael

[sent from post-receive hook]

On Thu, 23 Oct 2025 15:13:46 +0200, Alexander Dahl <ada@thorsis.com> wrote:
> Further reduce library size.
> 
> Quote from https://libwebsockets.org/
> 
> > "Roles" are wire protocol implementations …
> 
> So those are some kind of high level protocol support options here, and
> that's also what the CMake option help text in libwebsockets source
> suggests.
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20251021131118.919834-8-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/libwebsockets.in b/rules/libwebsockets.in
> index e10413604c9d..c27045502ba0 100644
> --- a/rules/libwebsockets.in
> +++ b/rules/libwebsockets.in
> @@ -19,6 +19,27 @@ menuconfig LIBWEBSOCKETS
>  
>  if LIBWEBSOCKETS
>  
> +menu "LWS roles                      "
> +
> +comment "not all roles are optional in this ptxdist package"
> +
> +config LIBWEBSOCKETS_ROLE_RAW_FILE
> +	bool
> +	prompt "raw files support"
> +	default y
> +
> +config LIBWEBSOCKETS_ROLE_WS
> +	bool
> +	prompt "websockets support"
> +	default y
> +
> +config LIBWEBSOCKETS_ROLE_H2
> +	bool
> +	prompt "http/2 support"
> +	default y
> +
> +endmenu
> +
>  config LIBWEBSOCKETS_TLS
>  	bool
>  	prompt "TLS (SSL) support"
> diff --git a/rules/libwebsockets.make b/rules/libwebsockets.make
> index 72fdd8a2907b..9c039f1d4956 100644
> --- a/rules/libwebsockets.make
> +++ b/rules/libwebsockets.make
> @@ -43,6 +43,12 @@ LIBWEBSOCKETS_CONF_OPT	:=  \
>  	-DLWS_PLAT_BAREMETAL=OFF \
>  	-DLWS_PLAT_FREERTOS=OFF \
>  	-DLWS_PLAT_OPTEE=OFF \
> +	-DLWS_ROLE_DBUS=OFF \
> +	-DLWS_ROLE_H1=ON \
> +	-DLWS_ROLE_MQTT=OFF \
> +	-DLWS_ROLE_RAW_FILE=$(call ptx/onoff, PTXCONF_LIBWEBSOCKETS_ROLE_RAW_FILE) \
> +	-DLWS_ROLE_RAW_PROXY=OFF \
> +	-DLWS_ROLE_WS=$(call ptx/onoff, PTXCONF_LIBWEBSOCKETS_ROLE_WS) \
>  	-DLWS_WITHOUT_DAEMONIZE=OFF \
>  	-DLWS_WITHOUT_EXTENSIONS=OFF \
>  	-DLWS_WITHOUT_TESTAPPS=ON \
> @@ -58,6 +64,7 @@ LIBWEBSOCKETS_CONF_OPT	:=  \
>  	-DLWS_WITH_EXTERNAL_POLL=ON \
>  	-DLWS_WITH_GLIB=$(call ptx/onoff, PTXCONF_LIBWEBSOCKETS_GLIB) \
>  	-DLWS_WITH_GZINFLATE=OFF \
> +	-DLWS_WITH_HTTP2=$(call ptx/onoff, PTXCONF_LIBWEBSOCKETS_ROLE_H2) \
>  	-DLWS_WITH_JPEG=OFF \
>  	-DLWS_WITH_JSONRPC=OFF \
>  	-DLWS_WITH_LHP=OFF \



  reply	other threads:[~2025-10-23 13:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 13:11 [ptxdist] [PATCH 0/8] libwebsockets: Pin down options and bump version Alexander Dahl via ptxdist
2025-10-21 13:11 ` [ptxdist] [PATCH 1/8] libwebsockets: Reorder conf opts Alexander Dahl via ptxdist
2025-10-23 13:13   ` [ptxdist] [APPLIED] " Michael Olbrich
2025-10-21 13:11 ` [ptxdist] [PATCH 2/8] libwebsockets: Add conf opt to disable -Werror Alexander Dahl via ptxdist
2025-10-23 13:13   ` [ptxdist] [APPLIED] " Michael Olbrich
2025-10-21 13:11 ` [ptxdist] [PATCH 3/8] libwebsockets: Make shared library build explicit Alexander Dahl via ptxdist
2025-10-23 13:13   ` [ptxdist] [APPLIED] " Michael Olbrich
2025-10-21 13:11 ` [ptxdist] [PATCH 4/8] libwebsockets: Remove tests and examples from build Alexander Dahl via ptxdist
2025-10-23 13:13   ` [ptxdist] [APPLIED] " Michael Olbrich
2025-10-21 13:11 ` [ptxdist] [PATCH 5/8] libwebsockets: Pin down more conf opts Alexander Dahl via ptxdist
2025-10-23 13:13   ` [ptxdist] [APPLIED] " Michael Olbrich
2025-10-21 13:11 ` [ptxdist] [PATCH 6/8] libwebsockets: version bump 4.3.3 -> 4.4.1 Alexander Dahl via ptxdist
2025-10-23 13:13   ` [ptxdist] [APPLIED] " Michael Olbrich
2025-10-21 13:11 ` [ptxdist] [PATCH 7/8] libwebsockets: Make roles configurable Alexander Dahl via ptxdist
2025-10-23 13:13   ` Michael Olbrich [this message]
2025-10-21 13:11 ` [ptxdist] [PATCH 8/8] libwebsockets: Pin down higher level config options Alexander Dahl via ptxdist
2025-10-23 13:13   ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251023131346.1212537-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox