From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 22 Sep 2025 13:04:50 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v0eLi-005vdf-2L for lore@lore.pengutronix.de; Mon, 22 Sep 2025 13:04:50 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1v0eLh-0008P1-8k; Mon, 22 Sep 2025 13:04:49 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v0eLJ-0007IS-Mo; Mon, 22 Sep 2025 13:04:25 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v0eLJ-002aBv-1b; Mon, 22 Sep 2025 13:04:25 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1v0eLJ-00000008iH0-1qRK; Mon, 22 Sep 2025 13:04:25 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Mon, 22 Sep 2025 13:04:25 +0200 Message-ID: <20250922110425.2076801-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250919100643.199174-3-ada@thorsis.com> References: <20250919100643.199174-3-ada@thorsis.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] libubootenv: Add option for installing tools X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 2468a48e9295b206a233c739e9b099824f9158e8. Michael [sent from post-receive hook] On Mon, 22 Sep 2025 13:04:25 +0200, Alexander Dahl wrote: > These tools can also be provided by the u-boot-tools package. > > This variant promises to be board independent, and comes with a library, > and has more features. > > Can be used as drop-in replacement for fw_printenv and fw_setenv. > Helpful for writing env to mmcblockXbootX which is ro by default, and > u-boot-tools does not handle that. > > Signed-off-by: Alexander Dahl > Message-Id: <20250919100643.199174-3-ada@thorsis.com> > Signed-off-by: Michael Olbrich > > diff --git a/rules/libubootenv.in b/rules/libubootenv.in > index 70f6d9863885..317a440fc0de 100644 > --- a/rules/libubootenv.in > +++ b/rules/libubootenv.in > @@ -1,15 +1,29 @@ > ## SECTION=system_libraries > > -config LIBUBOOTENV > +menuconfig LIBUBOOTENV > tristate > select HOST_CMAKE > select LIBYAML > select ZLIB > - prompt "libubootenv" > + prompt "libubootenv " > help > Generic library and tools to access and modify U-Boot > environment from User Space. > > https://github.com/sbabic/libubootenv > > +if LIBUBOOTENV > + > +config LIBUBOOTENV_TOOLS > + bool > + prompt "fw_printenv / fw_setenv" > + depends on !U_BOOT_TOOLS || ALLYES > + help > + Install fw_printenv and fw_setenv to target. > + > +comment "u-boot-tools is selected!" > + depends on U_BOOT_TOOLS > + > +endif > + > # vim: ft=kconfig noet tw=72 ts=8 sw=8 > diff --git a/rules/libubootenv.make b/rules/libubootenv.make > index d4e67815266b..769961dfa068 100644 > --- a/rules/libubootenv.make > +++ b/rules/libubootenv.make > @@ -51,6 +51,13 @@ $(STATEDIR)/libubootenv.targetinstall: > > @$(call install_lib, libubootenv, 0, 0, 0644, libubootenv) > > +ifdef PTXCONF_LIBUBOOTENV_TOOLS > +# # same path as the equivalents from u-boot-tools package > + @$(call install_copy, libubootenv, 0, 0, 0755, \ > + $(LIBUBOOTENV_PKGDIR)/usr/bin/fw_printenv, /usr/sbin/fw_printenv) > + @$(call install_link, libubootenv, fw_printenv, /usr/sbin/fw_setenv) > +endif > + > @$(call install_finish, libubootenv) > > @$(call touch)