From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 08 Sep 2025 09:24:26 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uvWEk-000Yki-0w for lore@lore.pengutronix.de; Mon, 08 Sep 2025 09:24:26 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uvWEj-0008WP-U0; Mon, 08 Sep 2025 09:24:25 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uvWEb-0007rR-Pf; Mon, 08 Sep 2025 09:24:17 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uvWEb-000D6v-1s; Mon, 08 Sep 2025 09:24:17 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1uvWEb-0000000Ej6P-2DuL; Mon, 08 Sep 2025 09:24:17 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Mon, 8 Sep 2025 09:24:17 +0200 Message-ID: <20250908072417.3509958-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250902143914.200156-1-f.pflug@pengutronix.de> References: <20250902143914.200156-1-f.pflug@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] rauc: Make mark-good.service optional X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Fabian Pflug Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 82f3e57038483f0f16e7da2f3a645b7863fb3adb. Michael [sent from post-receive hook] On Mon, 08 Sep 2025 09:24:17 +0200, Fabian Pflug wrote: > If you don't need the mark good service, because your descision if it is > good does not translate to systemd-target, but you handle it in your > application, you don't want the mark-good.service to run. > > Signed-off-by: Fabian Pflug > Message-Id: <20250902143914.200156-1-f.pflug@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/rauc.in b/rules/rauc.in > index ed951db024b9..7f260984d46a 100644 > --- a/rules/rauc.in > +++ b/rules/rauc.in > @@ -47,6 +47,16 @@ config RAUC_SERVICE > that communicate with each other via D-Bus interface. > Only deactivate this if you have a system that does not provide D-Bus! > > +config RAUC_MARK_GOOD > + bool > + prompt "Enable the rauc-mark-good systemd service" > + depends on RAUC_SERVICE && INITMETHOD_SYSTEMD > + default y > + help > + The service will start after boot-complete target has been reached and > + mark the currently booted slot as good. If your application does this > + after some additional checks, disable this. > + > config RAUC_NETWORK > bool > prompt "Enable network support" > diff --git a/rules/rauc.make b/rules/rauc.make > index a3a5071e5297..2f4aedcada26 100644 > --- a/rules/rauc.make > +++ b/rules/rauc.make > @@ -97,10 +97,12 @@ ifdef PTXCONF_INITMETHOD_SYSTEMD > @$(call install_alternative, rauc, 0, 0, 0644, \ > /usr/lib/systemd/system/rauc.service) > > +ifdef PTXCONF_RAUC_MARK_GOOD > @$(call install_alternative, rauc, 0, 0, 0644, \ > /usr/lib/systemd/system/rauc-mark-good.service) > @$(call install_link, rauc, ../rauc-mark-good.service, \ > /usr/lib/systemd/system/multi-user.target.wants/rauc-mark-good.service) > +endif > else > @$(call install_copy, rauc, 0, 0, 0755, -, \ > /usr/libexec/rauc-service.sh)