mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Fabian Pflug <f.pflug@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] rauc: Make mark-good.service optional
Date: Mon,  8 Sep 2025 09:24:17 +0200	[thread overview]
Message-ID: <20250908072417.3509958-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20250902143914.200156-1-f.pflug@pengutronix.de>

Thanks, applied as 82f3e57038483f0f16e7da2f3a645b7863fb3adb.

Michael

[sent from post-receive hook]

On Mon, 08 Sep 2025 09:24:17 +0200, Fabian Pflug <f.pflug@pengutronix.de> wrote:
> If you don't need the mark good service, because your descision if it is
> good does not translate to systemd-target, but you handle it in your
> application, you don't want the mark-good.service to run.
> 
> Signed-off-by: Fabian Pflug <f.pflug@pengutronix.de>
> Message-Id: <20250902143914.200156-1-f.pflug@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/rauc.in b/rules/rauc.in
> index ed951db024b9..7f260984d46a 100644
> --- a/rules/rauc.in
> +++ b/rules/rauc.in
> @@ -47,6 +47,16 @@ config RAUC_SERVICE
>  	  that communicate with each other via D-Bus interface.
>  	  Only deactivate this if you have a system that does not provide D-Bus!
>  
> +config RAUC_MARK_GOOD
> +	bool
> +	prompt "Enable the rauc-mark-good systemd service"
> +	depends on RAUC_SERVICE && INITMETHOD_SYSTEMD
> +	default y
> +	help
> +	  The service will start after boot-complete target has been reached and
> +	  mark the currently booted slot as good. If your application does this
> +	  after some additional checks, disable this.
> +
>  config RAUC_NETWORK
>  	bool
>  	prompt "Enable network support"
> diff --git a/rules/rauc.make b/rules/rauc.make
> index a3a5071e5297..2f4aedcada26 100644
> --- a/rules/rauc.make
> +++ b/rules/rauc.make
> @@ -97,10 +97,12 @@ ifdef PTXCONF_INITMETHOD_SYSTEMD
>  	@$(call install_alternative, rauc, 0, 0, 0644, \
>  		/usr/lib/systemd/system/rauc.service)
>  
> +ifdef PTXCONF_RAUC_MARK_GOOD
>  	@$(call install_alternative, rauc, 0, 0, 0644, \
>  		/usr/lib/systemd/system/rauc-mark-good.service)
>  	@$(call install_link, rauc, ../rauc-mark-good.service, \
>  		/usr/lib/systemd/system/multi-user.target.wants/rauc-mark-good.service)
> +endif
>  else
>  	@$(call install_copy, rauc, 0, 0, 0755, -, \
>  		/usr/libexec/rauc-service.sh)



      reply	other threads:[~2025-09-08  7:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 14:39 [ptxdist] [PATCH] " Fabian Pflug
2025-09-08  7:24 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250908072417.3509958-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=f.pflug@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox