[ptxdist] [PATCH] mosquitto: allow to overwrite .service

[ptxdist] [PATCH] mosquitto: allow to overwrite .service

[Fabian Pflug]

Use alternative instead of copy in order to provide your own
mosquitto.service file for easier changes.

Signed-off-by: Fabian Pflug <f.pflug@pengutronix.de>
---
 rules/mosquitto.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/mosquitto.make b/rules/mosquitto.make
index 239f1fe3c..ed10bb5f7 100644
--- a/rules/mosquitto.make
+++ b/rules/mosquitto.make
@@ -99,7 +99,7 @@ ifdef PTXCONF_MOSQUITTO_BROKER
 		/etc/mosquitto/mosquitto.conf)
 
 ifdef PTXCONF_MOSQUITTO_SYSTEMD_UNIT
-	@$(call install_copy, mosquitto, 0, 0, 0644, -, \
+	@$(call install_alternative, mosquitto, 0, 0, 0644, -, \
 		/usr/lib/systemd/system/mosquitto.service)
 	@$(call install_link, mosquitto, ../mosquitto.service, \
 		/usr/lib/systemd/system/multi-user.target.wants/mosquitto.service)
-- 
2.47.2

Re: [ptxdist] [PATCH] mosquitto: allow to overwrite .service

[Alexander Dahl via ptxdist]

Hello Fabian,

Am Wed, Sep 03, 2025 at 03:44:37PM +0200 schrieb Fabian Pflug:
> Use alternative instead of copy in order to provide your own
> mosquitto.service file for easier changes.
> 
> Signed-off-by: Fabian Pflug <f.pflug@pengutronix.de>
> ---
>  rules/mosquitto.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/mosquitto.make b/rules/mosquitto.make
> index 239f1fe3c..ed10bb5f7 100644
> --- a/rules/mosquitto.make
> +++ b/rules/mosquitto.make
> @@ -99,7 +99,7 @@ ifdef PTXCONF_MOSQUITTO_BROKER
>  		/etc/mosquitto/mosquitto.conf)
>  
>  ifdef PTXCONF_MOSQUITTO_SYSTEMD_UNIT
> -	@$(call install_copy, mosquitto, 0, 0, 0644, -, \
> +	@$(call install_alternative, mosquitto, 0, 0, 0644, -, \
>  		/usr/lib/systemd/system/mosquitto.service)

install_alternative does not need that dash '-' as 5th argument.
Does that even work like this?

Greets
Alex

>  	@$(call install_link, mosquitto, ../mosquitto.service, \
>  		/usr/lib/systemd/system/multi-user.target.wants/mosquitto.service)
> -- 
> 2.47.2
> 
> 

[ptxdist] [PATCH v2] mosquitto: allow to overwrite .service

[Fabian Pflug]

Use alternative instead of copy in order to provide your own
mosquitto.service file for easier changes.

Signed-off-by: Fabian Pflug <f.pflug@pengutronix.de>
---
Forgot to remove the "-," in the first version. Never manually change the
file, always copy and paste from your buildsystem... :(
Thanks for the hint Alexander Dahl

 rules/mosquitto.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/mosquitto.make b/rules/mosquitto.make
index 239f1fe3c..a836df897 100644
--- a/rules/mosquitto.make
+++ b/rules/mosquitto.make
@@ -99,7 +99,7 @@ ifdef PTXCONF_MOSQUITTO_BROKER
 		/etc/mosquitto/mosquitto.conf)
 
 ifdef PTXCONF_MOSQUITTO_SYSTEMD_UNIT
-	@$(call install_copy, mosquitto, 0, 0, 0644, -, \
+	@$(call install_alternative, mosquitto, 0, 0, 0644, \
 		/usr/lib/systemd/system/mosquitto.service)
 	@$(call install_link, mosquitto, ../mosquitto.service, \
 		/usr/lib/systemd/system/multi-user.target.wants/mosquitto.service)
-- 
2.47.2