From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Fri, 29 Aug 2025 11:49:17 +0200
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1urvjS-005m7m-0r
	for lore@lore.pengutronix.de;
	Fri, 29 Aug 2025 11:49:17 +0200
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1urvjR-0000dp-ES; Fri, 29 Aug 2025 11:49:17 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1urvgn-0004NI-BD; Fri, 29 Aug 2025 11:46:33 +0200
Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54])
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1urvgm-002hsv-2m;
 Fri, 29 Aug 2025 11:46:32 +0200
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.98.2)
 (envelope-from <mol@pengutronix.de>) id 1urvgm-0000000Azj6-3QGf;
 Fri, 29 Aug 2025 11:46:32 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Fri, 29 Aug 2025 11:46:32 +0200
Message-ID: <20250829094632.2620549-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.47.2
In-Reply-To: <20250827103642.3881930-3-m.tretter@pengutronix.de>
References: <20250827103642.3881930-3-m.tretter@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] optee: remove install_init
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Michael Tretter <m.tretter@pengutronix.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 6a35b4a5b93c4c96752a2affa165f7ec1fbaa9ab.

Michael

[sent from post-receive hook]

On Fri, 29 Aug 2025 11:46:32 +0200, Michael Tretter <m.tretter@pengutronix.de> wrote:
> The rule calls install_init twice. Once in the install stage and once in
> the targetinstall stage. If never calls install_finish.
> 
> Remove install_init, since the rule doesn't create a package.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> Message-Id: <20250827103642.3881930-3-m.tretter@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/optee.make b/rules/optee.make
> index 52a71962eeca..e0655565efc3 100644
> --- a/rules/optee.make
> +++ b/rules/optee.make
> @@ -61,7 +61,6 @@ OPTEE_OUT_DIR        := \
>  $(STATEDIR)/optee.install:
>  	@$(call targetinfo)
>  
> -	@$(call install_init, optee)
>  	@install -vd -m755 $(OPTEE_PKGDIR)/usr/lib/optee-os
>  	@cp -vr $(OPTEE_OUT_DIR)/$(OPTEE_LIB_DIR)/* $(OPTEE_PKGDIR)/usr/lib/optee-os
>  
> @@ -81,7 +80,6 @@ OPTEE_BINARIES := \
>  $(STATEDIR)/optee.targetinstall:
>  	@$(call targetinfo)
>  
> -	@$(call install_init, optee)
>  	@$(foreach binary, $(OPTEE_BINARIES), \
>  		$(call ptx/image-install, OPTEE, \
>  			$(OPTEE_OUT_DIR)/core/$(binary), \