From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 25 Jul 2025 16:34:27 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ufJVD-003cBP-09 for lore@lore.pengutronix.de; Fri, 25 Jul 2025 16:34:27 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ufJVC-0003th-Sg; Fri, 25 Jul 2025 16:34:26 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ufJUu-0003tT-0f; Fri, 25 Jul 2025 16:34:08 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ufJUt-00AEes-09; Fri, 25 Jul 2025 16:34:07 +0200 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ufJUs-005EEL-36; Fri, 25 Jul 2025 16:34:06 +0200 Date: Fri, 25 Jul 2025 16:34:06 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de, Bruno Thomsen , Markus Heidelberg Message-ID: <20250725143406.GI249918@pengutronix.de> Mail-Followup-To: ptxdist@pengutronix.de, Bruno Thomsen , Markus Heidelberg References: <20250716192255.4781-1-bruno.thomsen@gmail.com> <20250725-speculate-monogram-1c1c194e6937@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250725-speculate-monogram-1c1c194e6937@thorsis.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-IRC: #ptxdist @freenode Subject: Re: [ptxdist] [PATCH] templates: update vim modeline for makefile and kconfig files X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Fri, Jul 25, 2025 at 12:07:16PM +0200, Alexander Dahl via ptxdist wrote: > Hello, > > Am Fri, Jul 25, 2025 at 11:42:31AM +0200 schrieb Michael Olbrich: > > On Thu, Jul 24, 2025 at 11:35:34AM +0200, Bruno Thomsen wrote: > > > Den tors. 24. jul. 2025 kl. 09.51 skrev Markus Heidelberg : > > > > > > > > On Wed, Jul 23, 2025 at 07:03:42PM +0200, Bruno Thomsen wrote: > > > > > Den ons. 23. jul. 2025 kl. 09.11 skrev Michael Olbrich > > > > > : > > > > > > > > > > > > On Wed, Jul 16, 2025 at 09:22:55PM +0200, Bruno Thomsen wrote: > > > > > > > Setup sane editor default using vim modeline. > > > > > > > > > > > > > > sed -i "s/syntax=make/ft=make noet tw=72 ts=8 sw=8/g" rules/templates/*-make > > > > > > > > > > > > tw=72 is fine for the .in files. That will give a good flow for the help > > > > > > text. Most of the rest will be shorter anyways. > > > > > > > > > > > > But the makefiles have longer lines. The banner above the stage are already > > > > > > 78 chars wide and many of the variables at the top as well. > > > > > > And for the rest, readability really depends on the content and a defined > > > > > > textwidth suggests a hard limit that I don't want to set. > > > > > > > > > > > > Maybe a soft visual limit with cc=80 instead? > > > > > > > > > > [...] > > > > > > > > > > Maybe drop tw on both and use cc=80 on kconfig (as you suggested) > > > > > and cc=100 on makefiles? > > > > > > > > I don't think such a visual setting should be imposed on the user and > > > > could annoy some, myself included ;) > > > > > > > > Is this a problem in practice that has to be tackled at all? > > > > I do request more line-breaks when I review patches. It's not that often > > that I think we need urgent changes. But defining a good default in some > > way makes sense. > > > > > Indentation and file format are my primary reasons for adding modeline. > > > Make it much easier to work on when you switch between 5-10 formats > > > each day. > > > > So vim detect the file format for kconfig without any help. But I don't > > mind adding it explicitly. > > Not on my machine(s), at least not for files named 'package.in' like in > ptxdist. It does only set ft=kconfig automatically for files named > 'Kconfig' like in the linux kernel source tree. Right, I have file type detection code for that somewhere in my vim configuration... :-) Michael > > For 'noet ts=8 sw=8' we could also create a editorconfig file. That would > > work with more editors (with the appropriate plugins). > > +1 for that. > > > > Personally I like to have automation tell me when lines need to be broken, > > > as it can generally give you a hit if you should refactor a code section for > > > smaller indentation so it's easier to read. > > > > Lets do tw=80 for the .in files and no width limit (for now) for the .make > > files. > > Ack. > > Greets > Alex > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |