From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 25 Jul 2025 12:07:40 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ufFL2-003YEZ-1K for lore@lore.pengutronix.de; Fri, 25 Jul 2025 12:07:40 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ufFL2-0004vv-7g; Fri, 25 Jul 2025 12:07:40 +0200 Received: from mail.thorsis.com ([217.92.40.78]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ufFKo-0004vF-QM for ptxdist@pengutronix.de; Fri, 25 Jul 2025 12:07:27 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 97E0D14893A1; Fri, 25 Jul 2025 12:07:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1753438042; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=A9ANE2xz2OOXQzSiw1spul/ODsz8vkXSFE+bkFn1FC8=; b=rHs7w5blwWXFuLmRVjdAyyIPAAKp9V30t09gQ4EPTpmfVbJ8maP7bOMR3ttS0bbynfNu0w VoCLhemK6l32Wo0ajoomZze/TnJXqu0JUPL6VZ3bwB26PrRAttvjdZUQ6tC6SOdN8kRU6e AUle0cdXcTpkd4ZSzS0oTOSwvOE32rn+6G0qHvLQ+hFvuwqXJA6ctyR9I0gb/H+ki0ub3X dol82HZgmcjybtzmxc/v4KRSyGftGs0V/tR5+2QPz7opftUmPBwVOz8FugeR7HAlO0BUZ1 PwMBE+Jspf5CNyMzEFIMKyd3cTzXIfr3X5o/auXODrx5ZEWiYeTSbfQKKf/BTw== Date: Fri, 25 Jul 2025 12:07:16 +0200 To: ptxdist@pengutronix.de Message-ID: <20250725-speculate-monogram-1c1c194e6937@thorsis.com> Mail-Followup-To: ptxdist@pengutronix.de, Bruno Thomsen , Markus Heidelberg References: <20250716192255.4781-1-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] templates: update vim modeline for makefile and kconfig files X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Dahl via ptxdist Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl , Markus Heidelberg , Bruno Thomsen Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello, Am Fri, Jul 25, 2025 at 11:42:31AM +0200 schrieb Michael Olbrich: > On Thu, Jul 24, 2025 at 11:35:34AM +0200, Bruno Thomsen wrote: > > Den tors. 24. jul. 2025 kl. 09.51 skrev Markus Heidelberg : > > > > > > On Wed, Jul 23, 2025 at 07:03:42PM +0200, Bruno Thomsen wrote: > > > > Den ons. 23. jul. 2025 kl. 09.11 skrev Michael Olbrich > > > > : > > > > > > > > > > On Wed, Jul 16, 2025 at 09:22:55PM +0200, Bruno Thomsen wrote: > > > > > > Setup sane editor default using vim modeline. > > > > > > > > > > > > sed -i "s/syntax=make/ft=make noet tw=72 ts=8 sw=8/g" rules/templates/*-make > > > > > > > > > > tw=72 is fine for the .in files. That will give a good flow for the help > > > > > text. Most of the rest will be shorter anyways. > > > > > > > > > > But the makefiles have longer lines. The banner above the stage are already > > > > > 78 chars wide and many of the variables at the top as well. > > > > > And for the rest, readability really depends on the content and a defined > > > > > textwidth suggests a hard limit that I don't want to set. > > > > > > > > > > Maybe a soft visual limit with cc=80 instead? > > > > > > > > [...] > > > > > > > > Maybe drop tw on both and use cc=80 on kconfig (as you suggested) > > > > and cc=100 on makefiles? > > > > > > I don't think such a visual setting should be imposed on the user and > > > could annoy some, myself included ;) > > > > > > Is this a problem in practice that has to be tackled at all? > > I do request more line-breaks when I review patches. It's not that often > that I think we need urgent changes. But defining a good default in some > way makes sense. > > > Indentation and file format are my primary reasons for adding modeline. > > Make it much easier to work on when you switch between 5-10 formats > > each day. > > So vim detect the file format for kconfig without any help. But I don't > mind adding it explicitly. Not on my machine(s), at least not for files named 'package.in' like in ptxdist. It does only set ft=kconfig automatically for files named 'Kconfig' like in the linux kernel source tree. > For 'noet ts=8 sw=8' we could also create a editorconfig file. That would > work with more editors (with the appropriate plugins). +1 for that. > > Personally I like to have automation tell me when lines need to be broken, > > as it can generally give you a hit if you should refactor a code section for > > smaller indentation so it's easier to read. > > Lets do tw=80 for the .in files and no width limit (for now) for the .make > files. Ack. Greets Alex