From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 02 Jun 2025 13:59:54 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uM3pa-002x02-1O for lore@lore.pengutronix.de; Mon, 02 Jun 2025 13:59:54 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uM3pa-0001Qu-7a; Mon, 02 Jun 2025 13:59:54 +0200 Received: from mail.thorsis.com ([2003:a:e28:26e4::10]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uM3pM-0001Qk-QU for ptxdist@pengutronix.de; Mon, 02 Jun 2025 13:59:41 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0B00B14805D5; Mon, 2 Jun 2025 13:59:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1748865579; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=kGQT5Vx9fZ+RBymQO74+kDXu80EhC7pbWCt0GCT05M8=; b=eqZ8eXhNskgWxjnjL2FIMxASuq4m1uQYD9+6rQXGliGAnVQEHtuQS7WGcBD/eoxShDhW8i zsRrucDxTe5v5Qi7xIzDAHhCNUF9fE60FV5s5SaehFU0ss+4ZJf+HeVINjMZ07oHePiNvP ljMrhJOoQbcN82IxkYha/aT2fb9dOj5lioDr0xnr2DnTkpCRCllXmq0zPaGmS31e5kjIcN peTCcq9rYqN1K1H1Sd/+pV1b9Ra1Eii0xleCMkv82WC9me8HAR0yw2hWcZQ9gNLWtu5Ff8 qZmJ4iu+aO6buv10LLQDcaHLM4y8/AFbqJ7fY8hJ1Ryp7A9cnBOz/YhcpbKk8w== Date: Mon, 2 Jun 2025 13:59:34 +0200 To: Alexander Dahl via ptxdist Message-ID: <20250602-linguist-lurch-0f0a6433d879@thorsis.com> Mail-Followup-To: Alexander Dahl via ptxdist , Andreas Helmcke References: <20250602103057.299742-1-ada@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250602103057.299742-1-ada@thorsis.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 0/1] jq: license update and version bump X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Dahl via ptxdist Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl , Andreas Helmcke Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Moin, Am Mon, Jun 02, 2025 at 12:30:56PM +0200 schrieb Alexander Dahl via ptxdist: > Hello, > > jq 1.8.0 [1] was announced yesterday and fixes some security issues. > When trying to upgrade the package I noticed several things: > > 1. when I introduced the jq package back in 2018, ./configure was called > with `--without-oniguruma` > 2. that was silently dropped by Andreas with the version bump to 1.7 two > years ago, and from there libonig was installed to the target > 3. the version bump to 1.7.1 brought back the configure parameter like > this: `--with-oniguruma=prefix` > > The attached patch accounts for that extra lib and adds its license. > > Now after upgrading to jq v1.8.0 I get linker errors I don't understand > (see below), and I have no time to further investigate this. > (Maybe this is related to my old ptxdist version? Same failing result > with 2024.05.0 and 2024.11.0.) > > liboniguruma is an abandoned regex library. Is it really necessary for > us? What extra features does jq provide if compiled with that lib? Maybe that lib could be put into a separate package like buildroot or Debian have it? Might simplify the build and the license issue here. A > > If it is really necessary, maybe someone else wants to jump in for that > version bump and fix the linker problems, otherwise we could change back > to --without-oniguruma ? > > Greets > Alex > > Output of `ptxdist compile jq` with jq 1.8.0: > > libtool: link: /usr/bin/grep -E -e "^j[qv]_" ".libs/libjq.exp" > ".libs/libjq.expT" > libtool: link: mv -f ".libs/libjq.expT" ".libs/libjq.exp" > libtool: link: echo "{ global:" > .libs/libjq.ver > libtool: link: cat .libs/libjq.exp | /usr/local/lib/ptxdist-2024.05.0/bin/sed -e "s/\(.*\)/\1;/" >> .libs/libjq.ver > libtool: link: echo "local: *; };" >> .libs/libjq.ver > libtool: link: arm-v5te-linux-gnueabi-gcc -shared -fPIC -DPIC src/.libs/builtin.o src/.libs/bytecode.o src/.libs/compile.o src/.libs/execute.o src/.libs/jq_test.o src/.libs/jv.o src/.libs/jv_alloc.o src/.libs/jv_aux.o src/.libs/jv_dtoa.o src/.libs/jv_file.o src/.libs/jv_parse.o src/.libs/jv_print.o src/.libs/jv_unicode.o src/.libs/linker.o src/.libs/locfile.o src/.libs/util.o src/.libs/jv_dtoa_tsd.o vendor/decNumber/.libs/decContext.o vendor/decNumber/.libs/decNumber.o src/.libs/lexer.o src/.libs/parser.o -L./vendor/oniguruma/src -lm vendor/oniguruma/src/.libs/libonig.so -lpthread -g -O2 -Wl,-rpath -Wl,/usr/lib -pthread -Wl,-soname -Wl,libjq.so.1 -Wl,-version-script -Wl,.libs/libjq.ver -o .libs/libjq.so.1.0.4 > libtool: link: (cd ".libs" && rm -f "libjq.so.1" && ln -s "libjq.so.1.0.4" "libjq.so.1") > libtool: link: (cd ".libs" && rm -f "libjq.so" && ln -s "libjq.so.1.0.4" "libjq.so") > libtool: link: ( cd ".libs" && rm -f "libjq.la" && ln -s "../libjq.la" "libjq.la" ) > /bin/bash ./libtool --tag=CC --mode=link arm-v5te-linux-gnueabi-gcc -Wextra -Wall -Wno-unused-parameter -Wno-unused-function -Woverlength-strings -Wstrict-prototypes -I./vendor/oniguruma/src -g -O2 -pthread -o jq src/main.o libjq.la -lm -lpthread > libtool: link: arm-v5te-linux-gnueabi-gcc -Wextra -Wall -Wno-unused-parameter -Wno-unused-function -Woverlength-strings -Wstrict-prototypes -I./vendor/oniguruma/src -g -O2 -o jq src/main.o ./.libs/libjq.so -lm -lpthread -pthread > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: warning: libonig.so.5, needed by ./.libs/libjq.so, not found (try using -rpath or -rpath-link) > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ./.libs/libjq.so: undefined reference to `onig_error_code_to_str' > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ./.libs/libjq.so: undefined reference to `onig_free' > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ./.libs/libjq.so: undefined reference to `onig_region_free' > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ./.libs/libjq.so: undefined reference to `onig_new' > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ./.libs/libjq.so: undefined reference to `OnigSyntaxPerl_NG' > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ./.libs/libjq.so: undefined reference to `onig_foreach_name' > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ./.libs/libjq.so: undefined reference to `onig_search' > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ./.libs/libjq.so: undefined reference to `OnigEncodingUTF8' > /opt/OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi/gcc-13.2.1-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/lib/gcc/arm-v5te-linux-gnueabi/13.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ./.libs/libjq.so: undefined reference to `onig_region_new' > collect2: error: ld returned 1 exit status > make[2]: *** [Makefile:990: jq] Error 1 > > [1] https://github.com/jqlang/jq/releases/tag/jq-1.8.0 > > Alexander Dahl (1): > jq: Add liboniguruma license > > rules/jq.make | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > > base-commit: 31866e0b9c1215fa5e8b4dc8573adc8feb7428aa > -- > 2.39.5 > >