mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Markus Heidelberg via ptxdist <ptxdist@pengutronix.de>
To: <ptxdist@pengutronix.de>
Cc: Markus Heidelberg <m.heidelberg@cab.de>
Subject: [ptxdist] [PATCH v2] libgpiod: override location of python3-config
Date: Fri, 30 May 2025 15:25:11 +0200	[thread overview]
Message-ID: <20250530132511.150215-1-m.heidelberg@cab.de> (raw)
In-Reply-To: <aDcicVWDI1_YCkOA@KAN23-025>

It exists as python3.13-config (or whatever the minor version currently
is) in sysroot-cross directory.

Fixes the following error in libgpiod prepare stage:

  checking for python3-config... false
  configure: error: python3-config not found - needed for python bindings

However, python3-config isn't used at all to build the Python bindings
and ac_cv_prog_has_python_config could be set to any value except
"false" to fix the error.

Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
---

> So it would probably be better to just remove the python3-config check.
> I'll submit a patch upstream and when accepted submit it to PTXdist.

I submitted a patch upstream, but decided for the
ac_cv_prog_has_python_config solution for PTXdist.
It is less intrusive (no recreation of configure script necessary) and
avoids a new dependency HOST_AUTOTOOLS_AUTOCONF_ARCHIVE because of this
in configure.ac:

    # This needs autoconf-archive
    AX_CXX_COMPILE_STDCXX_17([ext], [mandatory])

 rules/libgpiod.make | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/rules/libgpiod.make b/rules/libgpiod.make
index a77acf146..6272333b5 100644
--- a/rules/libgpiod.make
+++ b/rules/libgpiod.make
@@ -51,7 +51,9 @@ LIBGPIOD_CONF_OPT	:= \
 
 LIBGPIOD_CONF_ENV := \
 	$(CROSS_ENV) \
-	$(if $(PTXCONF_LIBGPIOD_PYTHON3), ac_cv_path_PYTHON=$(CROSS_PYTHON3))
+	$(if $(PTXCONF_LIBGPIOD_PYTHON3), \
+		ac_cv_path_PYTHON=$(CROSS_PYTHON3) \
+		ac_cv_prog_has_python_config=python$(PYTHON3_MAJORMINOR)-config)
 
 LIBGPIOD_LDFLAGS:= -Wl,-rpath-link,$(LIBGPIOD_DIR)/lib/.libs
 
-- 
2.43.0




      reply	other threads:[~2025-05-30 13:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 12:21 [ptxdist] [PATCH] libgpiod: select HOST_SYSTEM_PYTHON3_DEV for Python bindings Markus Heidelberg via ptxdist
2025-05-25 13:50 ` Michael Olbrich
2025-05-27 11:28   ` Markus Heidelberg via ptxdist
2025-05-27 12:06     ` Michael Olbrich
2025-05-28 14:49       ` Markus Heidelberg via ptxdist
2025-05-30 13:25         ` Markus Heidelberg via ptxdist [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250530132511.150215-1-m.heidelberg@cab.de \
    --to=ptxdist@pengutronix.de \
    --cc=m.heidelberg@cab.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox