From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Sat, 17 May 2025 00:03:12 +0200
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1uG396-006JNM-0Z
	for lore@lore.pengutronix.de;
	Sat, 17 May 2025 00:03:12 +0200
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1uG395-0003GP-7H; Sat, 17 May 2025 00:03:11 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1uG38k-0002b8-Oa; Sat, 17 May 2025 00:02:50 +0200
Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54])
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1uG38k-0036WI-0Q;
 Sat, 17 May 2025 00:02:50 +0200
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1uG38k-000vcP-1i;
 Sat, 17 May 2025 00:02:50 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Sat, 17 May 2025 00:02:50 +0200
Message-Id: <20250516220250.221478-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250513192818.3075825-1-christian.melki@t2data.com>
References: <20250513192818.3075825-1-christian.melki@t2data.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] readline: Install libhistory.
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Christian Melki <christian.melki@t2data.com>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 8e28eab2722677cfe03ca8596e7b41af927f15d8.

Michael

[sent from post-receive hook]

On Sat, 17 May 2025 00:02:50 +0200, Christian Melki <christian.melki@t2data.com> wrote:
> libhistory is part of readline and provided as a separate .so.
> It's fairly small (about 1/10:th of readline and around 40k on my machine).
> I don't see a big point in ignoring to install it, esp. since there is no
> builtin option to turn off the header installs and similar.
> 
> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> Message-Id: <20250513192818.3075825-1-christian.melki@t2data.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/readline.make b/rules/readline.make
> index 47b05fde9000..3bbf03051f0c 100644
> --- a/rules/readline.make
> +++ b/rules/readline.make
> @@ -55,6 +55,7 @@ $(STATEDIR)/readline.targetinstall:
>  	@$(call install_fixup, readline,DESCRIPTION,missing)
>  
>  	@$(call install_lib, readline, 0, 0, 0644, libreadline)
> +	@$(call install_lib, readline, 0, 0, 0644, libhistory)
>  
>  ifdef PTXCONF_READLINE_ETC_INPUTRC
>  	@$(call install_alternative, readline, 0, 0, 0644, /etc/inputrc)