From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 09 May 2025 09:27:34 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uDI8s-003ior-2u for lore@lore.pengutronix.de; Fri, 09 May 2025 09:27:34 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uDI8s-0007gl-IA; Fri, 09 May 2025 09:27:34 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uDI6U-0005qU-G9; Fri, 09 May 2025 09:25:06 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uDI6U-001qrN-11; Fri, 09 May 2025 09:25:06 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uDI6U-00BEyv-0s; Fri, 09 May 2025 09:25:06 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Fri, 9 May 2025 09:25:06 +0200 Message-Id: <20250509072506.2679190-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250411142222.2721457-1-m.tretter@pengutronix.de> References: <20250411142222.2721457-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] glibc: install libmvec only if supported by architecture X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Michael Tretter Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as dcf1b0cdf95ab0f9870afc9284cadc159958ea1a. Michael [sent from post-receive hook] On Fri, 09 May 2025 09:25:06 +0200, Michael Tretter wrote: > If libmvec is available depends on the architecture and the glibc > version. Thus, it is not available on all architectures. > > This is a problem on a BSP that contains platforms with different > architectures, if some of the architectures have libmvec and others > don't. > > Respect PTXCONF_GLIBC_MVEC only on architectures that actually have > libmvec and ignore the setting otherwise. > > Signed-off-by: Michael Tretter > Message-Id: <20250411142222.2721457-1-m.tretter@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/glibc.make b/rules/glibc.make > index 2dd74a70fe80..74caeb31664b 100644 > --- a/rules/glibc.make > +++ b/rules/glibc.make > @@ -26,6 +26,17 @@ GLIBC_VERSION := $(call ptx/config-version, PTXCONF_GLIBC) > # Prepare > # ---------------------------------------------------------------------------- > > +GLIBC_INSTALL_MVEC := > +ifdef PTXCONF_ARCH_X86 > +GLIBC_INSTALL_MVEC := $(PTXCONF_GLIBC_MVEC) > +endif > +ifdef PTXCONF_ARCH_ARM64 > +# libmvec support has been added to AArch64 with glibc version 2.38 > +ifdef PTXCONF_GLIBC_2_38 > +GLIBC_INSTALL_MVEC := $(PTXCONF_GLIBC_MVEC) > +endif > +endif > + > $(STATEDIR)/glibc.prepare: > @$(call targetinfo) > ifdef PTXCONF_GLIBC_Y2038 > @@ -88,7 +99,7 @@ ifdef PTXCONF_GLIBC_M > @$(call install_copy_toolchain_lib, glibc, libm.so.6) > endif > > -ifdef PTXCONF_GLIBC_MVEC > +ifdef GLIBC_INSTALL_MVEC > @$(call install_copy_toolchain_lib, glibc, libmvec.so.1) > endif >