From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Michael Tretter <m.tretter@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] glibc: install libmvec only if supported by architecture
Date: Fri, 9 May 2025 09:25:06 +0200 [thread overview]
Message-ID: <20250509072506.2679190-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20250411142222.2721457-1-m.tretter@pengutronix.de>
Thanks, applied as dcf1b0cdf95ab0f9870afc9284cadc159958ea1a.
Michael
[sent from post-receive hook]
On Fri, 09 May 2025 09:25:06 +0200, Michael Tretter <m.tretter@pengutronix.de> wrote:
> If libmvec is available depends on the architecture and the glibc
> version. Thus, it is not available on all architectures.
>
> This is a problem on a BSP that contains platforms with different
> architectures, if some of the architectures have libmvec and others
> don't.
>
> Respect PTXCONF_GLIBC_MVEC only on architectures that actually have
> libmvec and ignore the setting otherwise.
>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> Message-Id: <20250411142222.2721457-1-m.tretter@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/glibc.make b/rules/glibc.make
> index 2dd74a70fe80..74caeb31664b 100644
> --- a/rules/glibc.make
> +++ b/rules/glibc.make
> @@ -26,6 +26,17 @@ GLIBC_VERSION := $(call ptx/config-version, PTXCONF_GLIBC)
> # Prepare
> # ----------------------------------------------------------------------------
>
> +GLIBC_INSTALL_MVEC :=
> +ifdef PTXCONF_ARCH_X86
> +GLIBC_INSTALL_MVEC := $(PTXCONF_GLIBC_MVEC)
> +endif
> +ifdef PTXCONF_ARCH_ARM64
> +# libmvec support has been added to AArch64 with glibc version 2.38
> +ifdef PTXCONF_GLIBC_2_38
> +GLIBC_INSTALL_MVEC := $(PTXCONF_GLIBC_MVEC)
> +endif
> +endif
> +
> $(STATEDIR)/glibc.prepare:
> @$(call targetinfo)
> ifdef PTXCONF_GLIBC_Y2038
> @@ -88,7 +99,7 @@ ifdef PTXCONF_GLIBC_M
> @$(call install_copy_toolchain_lib, glibc, libm.so.6)
> endif
>
> -ifdef PTXCONF_GLIBC_MVEC
> +ifdef GLIBC_INSTALL_MVEC
> @$(call install_copy_toolchain_lib, glibc, libmvec.so.1)
> endif
>
prev parent reply other threads:[~2025-05-09 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 14:22 [ptxdist] [PATCH] " Michael Tretter
2025-05-09 7:25 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250509072506.2679190-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=m.tretter@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox