[ptxdist] [PATCH] wpewebkit: add missing dependency to libatomic

[ptxdist] [PATCH] wpewebkit: add missing dependency to libatomic

[Artur Wiebe]

ldd /usr/lib/libWPEWebKit-2.0.so.1
        libatomic.so.1 => /usr/lib/libatomic.so.1 (0x000073edd6534000)
        ...

Signed-off-by: Artur Wiebe <artur@4wiebe.de>
---
 rules/wpewebkit.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/wpewebkit.in b/rules/wpewebkit.in
index 30a324529..8147205e9 100644
--- a/rules/wpewebkit.in
+++ b/rules/wpewebkit.in
@@ -12,6 +12,7 @@ menuconfig WPEWEBKIT
 	select HOST_SYSTEM_PYTHON3
 	select HOST_SYSTEM_RUBY
 	select ALSA_LIB				if WPEWEBKIT_WEBRTC
+	select GCCLIBS_ATOMIC			if RUNTIME
 	select GLIB
 	select LIBWPE
 	select CAIRO
-- 
2.49.0

Re: [ptxdist] [PATCH] wpewebkit: add missing dependency to libatomic

[Artur Wiebe]

Hi,

I just tested: libatomic is needed on x86_64 and aarch64 (arm64).
So I think it makes sense to select it.

Artur



On Tuesday, 25 March, 2025 22:01 CET, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:

> On Tue, 25 Mar 2025, 17.54 Artur Wiebe, <artur@4wiebe.de> wrote:
> 
> > ldd /usr/lib/libWPEWebKit-2.0.so.1
> >         libatomic.so.1 => /usr/lib/libatomic.so.1 (0x000073edd6534000)
> >         ...
> >
> > Signed-off-by: Artur Wiebe <artur@4wiebe.de>
> > ---
> >  rules/wpewebkit.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/rules/wpewebkit.in b/rules/wpewebkit.in
> > index 30a324529..8147205e9 100644
> > --- a/rules/wpewebkit.in
> > +++ b/rules/wpewebkit.in
> > @@ -12,6 +12,7 @@ menuconfig WPEWEBKIT
> >         select HOST_SYSTEM_PYTHON3
> >         select HOST_SYSTEM_RUBY
> >         select ALSA_LIB                         if WPEWEBKIT_WEBRTC
> > +       select GCCLIBS_ATOMIC                   if RUNTIME
> >
> 
> Hi
> 
> This is only needed on arm v5te but not never arm.
> 
> See this thread on similar issue:
> 
> https://lore.ptxdist.org/ptxdist/CAH+2xPDa_CzmajYfREfJFeYF1PeVBde-2CaiogwX2K4dyjnB5Q@mail.gmail.com/
> 
> /Bruno
> 
>         select GLIB
> >         select LIBWPE
> >         select CAIRO
> > --
> > 2.49.0
> >
> >
> >